[GitHub] [skywalking-swck] dashanji commented on a change in pull request #33: Add java agent injector manual.

[GitBox <gi...@apache.org>]

dashanji commented on a change in pull request #33:
URL: https://github.com/apache/skywalking-swck/pull/33#discussion_r715978633



##########
File path: config/operator/configmap/configmap.yaml
##########
@@ -45,17 +45,16 @@ data:
     # The service name in UI

Review comment:
       ok , 
   
   > The configmap and annotation template should shrink to a smaller size.
   > 
   > Would you please split the document into two separate files: one, from 1 to 3, goes to `docs/`. another, section 4, keeps in `docs/example`
   > 
   > The first document should contain the following steps:
   > 
   > 1. how to install an agent injector
   > 2. how to active agent injection. We have two granularities here: namespace and pod
   > 3. how to config the agent. injector supports a precedence order: annotation, confgmap and default configmap.
   > 4. how to config agent.
   > 5. how to config sidecar.
   
   
   
   > The configmap and annotation template should shrink to a smaller size.
   > 
   > Would you please split the document into two separate files: one, from 1 to 3, goes to `docs/`. another, section 4, keeps in `docs/example`
   > 
   > The first document should contain the following steps:
   > 
   > 1. how to install an agent injector
   > 2. how to active agent injection. We have two granularities here: namespace and pod
   > 3. how to config the agent. injector supports a precedence order: annotation, confgmap and default configmap.
   > 4. how to config agent.
   > 5. how to config sidecar.
   
   ok , I will clean the code and update doc.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org