You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "EricBrzezenski (via GitHub)" <gi...@apache.org> on 2023/03/22 01:44:23 UTC
[GitHub] [flink-web] EricBrzezenski opened a new pull request, #625: [FLINK-31081][Documentation] Updating Jira Dashboard links to point to the #Issue-tracker
EricBrzezenski opened a new pull request, #625:
URL: https://github.com/apache/flink-web/pull/625
I did leave a few links behind as it didn't seem appropriate to change them all given the context around the link.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-web] EricBrzezenski commented on pull request #625: [FLINK-31081][Documentation] Updating Jira Dashboard links to point to the #Issue-tracker
Posted by "EricBrzezenski (via GitHub)" <gi...@apache.org>.
EricBrzezenski commented on PR #625:
URL: https://github.com/apache/flink-web/pull/625#issuecomment-1482159235
I believe i addressed all the comments, thank you for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-web] XComp commented on a diff in pull request #625: [FLINK-31081][Documentation] Updating Jira Dashboard links to point to the #Issue-tracker
Posted by "XComp (via GitHub)" <gi...@apache.org>.
XComp commented on code in PR #625:
URL: https://github.com/apache/flink-web/pull/625#discussion_r1144751607
##########
docs/content/getting-help.md:
##########
@@ -58,7 +58,7 @@ Many members of the Flink community are active on [Stack Overflow](https://stack
## Found a Bug?
-If you observe an unexpected behavior that might be caused by a bug, you can search for reported bugs or file a bug report in [Flink's JIRA](https://issues.apache.org/jira/browse/FLINK).
+If you observe an unexpected behavior that might be caused by a bug, you can search for reported bugs or file a bug report in [Flink's JIRA](https://flink.apache.org/community.html#issue-tracker).
Review Comment:
```suggestion
If you observe an unexpected behavior that might be caused by a bug, you can search for reported bugs or file a bug report in [Flink's JIRA]({{< relref "community#issue-tracker" >}}).
```
I guess using the hugo references would be a better approach here because we are less reliant on the domain. WDYT?
##########
docs/content.zh/how-to-contribute/code-style-and-quality-pull-requests.md:
##########
@@ -27,7 +27,7 @@ Please understand that contributions that do not follow this guide will take lon
## 1. JIRA issue and Naming
-Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues).
+Make sure that the pull request corresponds to a [JIRA issue](https://flink.apache.org/community.html#issue-tracker).
Review Comment:
I would leave this one as is because this paragraph is more about creating PRs and not registering in Jira. You can create PRs for FLINK issues that were created by others.
##########
content/doap_flink.rdf:
##########
@@ -29,7 +29,7 @@
<asfext:pmc rdf:resource="http://flink.apache.org" />
<shortdesc>Fast and reliable large-scale data processing</shortdesc>
<description>Flink is an open source system for expressive, declarative, fast, and efficient data analysis. It combines the scalability and programming flexibility of distributed MapReduce-like platforms with the efficiency, out-of-core execution, and query optimization capabilities found in parallel databases.</description>
- <bug-database rdf:resource="https://issues.apache.org/jira/browse/FLINK" />
Review Comment:
This link should point to Jira, I guess.
##########
docs/content/how-to-contribute/documentation-style-guide.md:
##########
@@ -20,7 +20,7 @@ one pull request. If you are not familiar with the Chinese language, make sure
that your contribution is complemented by these additional steps:
* Open a
- [JIRA](https://issues.apache.org/jira/projects/FLINK/issues)
+ [JIRA](https://flink.apache.org/community.html#issue-tracker)
Review Comment:
using the Hugo reference here would be better, I guess.
##########
docs/content/how-to-contribute/code-style-and-quality-pull-requests.md:
##########
@@ -27,7 +27,7 @@ Please understand that contributions that do not follow this guide will take lon
## 1. JIRA issue and Naming
-Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues).
+Make sure that the pull request corresponds to a [JIRA issue](https://flink.apache.org/community.html#issue-tracker).
Review Comment:
I would leave this one as is because this paragraph is more about creating PRs and not registering in Jira. You can create PRs for FLINK issues that were created by others.
##########
docs/content/community.md:
##########
@@ -120,7 +120,7 @@ under the License.
## How do I get help from Apache Flink?
-There are many ways to get help from the Apache Flink community. The [mailing lists](#mailing-lists) are the primary place where all Flink committers are present. For user support and questions use the *user mailing list*. You can also join the community on [Slack](#slack). Some committers are also monitoring [Stack Overflow](#stack-overflow). Please remember to tag your questions with the *[apache-flink](http://stackoverflow.com/questions/tagged/apache-flink)* tag. Bugs and feature requests can either be discussed on the *dev mailing list* or on [Jira](https://issues.apache.org/jira/browse/FLINK). Those interested in contributing to Flink should check out the [contribution guide]({{< relref "how-to-contribute" >}}).
+There are many ways to get help from the Apache Flink community. The [mailing lists](#mailing-lists) are the primary place where all Flink committers are present. For user support and questions use the *user mailing list*. You can also join the community on [Slack](#slack). Some committers are also monitoring [Stack Overflow](#stack-overflow). Please remember to tag your questions with the *[apache-flink](http://stackoverflow.com/questions/tagged/apache-flink)* tag. Bugs and feature requests can either be discussed on the *dev mailing list* or on [Jira](#issue-tracker). Those interested in contributing to Flink should check out the [contribution guide]({{< relref "how-to-contribute" >}}).
Review Comment:
The Chinese version needs to be updated as well.
##########
docs/content/how-to-contribute/contribute-code.md:
##########
@@ -15,7 +15,7 @@ Apache Flink is maintained, improved, and extended by code contributions of volu
## Looking for what to contribute
If you have a good idea for the contribution, you can proceed to [the code contribution process](#code-contribution-process).
-If you are looking for what you could contribute, you can browse open Jira issues in [Flink's bug tracker](https://issues.apache.org/jira/projects/FLINK/issues),
+If you are looking for what you could contribute, you can browse open Jira issues in [Flink's bug tracker](https://flink.apache.org/community.html#issue-tracker),
Review Comment:
There is a another link to jira further down in the text of this markdown. Additionally, there's also a Chinese version of this text which we could update.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-web] XComp commented on a diff in pull request #625: [FLINK-31081][Documentation] Updating Jira Dashboard links to point to the #Issue-tracker
Posted by "XComp (via GitHub)" <gi...@apache.org>.
XComp commented on code in PR #625:
URL: https://github.com/apache/flink-web/pull/625#discussion_r1147543316
##########
docs/content.zh/how-to-contribute/documentation-style-guide.md:
##########
@@ -13,7 +13,7 @@ weight: 21
Flink 同时维护了 **英文** 和 **中文** 两种文档，当你拓展或者更新文档时，需要在 pull request 中包含两种语言版本。如果你不熟悉中文，确保本次贡献补充了如下额外操作：
* 开一个翻译的
- [JIRA](https://issues.apache.org/jira/projects/FLINK/issues)
+[JIRA]({{< relref "community" >}}#issue-tracker)
Review Comment:
Looks like that doesn't work properly. Tracker is translated into Chinese
##########
docs/content.zh/how-to-contribute/contribute-code.md:
##########
@@ -19,7 +19,7 @@ Apache Flink 是一个通过志愿者贡献的代码来维护、改进和扩展
## 寻找可贡献的内容
如果你已经有好的想法可以贡献，可以直接参考下面的 "代码贡献步骤"。
-如果你在寻找可贡献的内容，可以通过 [Flink 的问题跟踪列表](https://issues.apache.org/jira/projects/FLINK/issues) 浏览处于 open 状态且未被分配的 Jira 工单，然后根据 "代码贡献步骤" 中的描述来参与贡献。
+如果你在寻找可贡献的内容，可以通过 [Flink 的问题跟踪列表]({{< relref "community" >}}#issue-tracker) 浏览处于 open 状态且未被分配的 Jira 工单，然后根据 "代码贡献步骤" 中的描述来参与贡献。
Review Comment:
The reference doesn't work. The Chinese version has a "tracker" translated into Chinese.
##########
docs/content/getting-help.md:
##########
@@ -58,7 +58,7 @@ Many members of the Flink community are active on [Stack Overflow](https://stack
## Found a Bug?
-If you observe an unexpected behavior that might be caused by a bug, you can search for reported bugs or file a bug report in [Flink's JIRA](https://issues.apache.org/jira/browse/FLINK).
+If you observe an unexpected behavior that might be caused by a bug, you can search for reported bugs or file a bug report in [Flink's JIRA]({{< relref "community#issue-tracker" >}}).
Review Comment:
This one also exist in the Chinese version.
##########
docs/content.zh/community.md:
##########
@@ -120,7 +120,7 @@ under the License.
## 如何从 Apache Flink 获得帮助？
-我们可以通过多种方式从 Apache Flink 社区获得帮助。Flink committer 主要活跃在 [邮件列表](#mailing-lists)。对于用户支持和问题咨询，则可以通过 用户邮件列表 获得帮助。你还可以加入社区专属的 [Slack](#slack)。有些 Committer 同时会关注 [Stack Overflow](#stack-overflow)。请在提问的时候记得添加 *[apache-flink](http://stackoverflow.com/questions/tagged/apache-flink)* 的标签。问题反馈以及新特性的讨论则可以在 开发邮件列表 或者 [Jira](https://issues.apache.org/jira/browse/FLINK) 上进行讨论。有兴趣对 Flink 进行贡献的人请查阅 [贡献指南]({{< relref "how-to-contribute" >}}).
+我们可以通过多种方式从 Apache Flink 社区获得帮助。Flink committer 主要活跃在 [邮件列表](#mailing-lists)。对于用户支持和问题咨询，则可以通过 用户邮件列表 获得帮助。你还可以加入社区专属的 [Slack](#slack)。有些 Committer 同时会关注 [Stack Overflow](#stack-overflow)。请在提问的时候记得添加 *[apache-flink](http://stackoverflow.com/questions/tagged/apache-flink)* 的标签。问题反馈以及新特性的讨论则可以在 开发邮件列表 或者 [Jira](#issue-tracker) 上进行讨论。有兴趣对 Flink 进行贡献的人请查阅 [贡献指南]({{< relref "how-to-contribute" >}}).
Review Comment:
Looks like that doesn't work properly. Tracker is translated into Chinese
##########
docs/content.zh/how-to-contribute/code-style-and-quality-pull-requests.md:
##########
@@ -27,7 +27,7 @@ Please understand that contributions that do not follow this guide will take lon
## 1. JIRA issue and Naming
-Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues).
+Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/browse/FLINK).
Review Comment:
Both links work. No need to edit this, I guess
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-web] XComp merged pull request #625: [FLINK-31081][Documentation] Updating Jira Dashboard links to point to the #Issue-tracker
Posted by "XComp (via GitHub)" <gi...@apache.org>.
XComp merged PR #625:
URL: https://github.com/apache/flink-web/pull/625
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-web] EricBrzezenski commented on pull request #625: [FLINK-31081][Documentation] Updating Jira Dashboard links to point to the #Issue-tracker
Posted by "EricBrzezenski (via GitHub)" <gi...@apache.org>.
EricBrzezenski commented on PR #625:
URL: https://github.com/apache/flink-web/pull/625#issuecomment-1483698185
Removed all html changes, and fixed the links in the Chinese documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-web] XComp commented on pull request #625: [FLINK-31081][Documentation] Updating Jira Dashboard links to point to the #Issue-tracker
Posted by "XComp (via GitHub)" <gi...@apache.org>.
XComp commented on PR #625:
URL: https://github.com/apache/flink-web/pull/625#issuecomment-1484913324
Thanks for your contribution. I had did a tiny change to your code: The Chinese section's tag was not correct. Anyway, I fixed it, squashed the commits and created the website update.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org