[GitHub] [superset] ktmud commented on a change in pull request #18799: feat: remove loading indicator when typing in select

[GitBox <gi...@apache.org>]

ktmud commented on a change in pull request #18799:
URL: https://github.com/apache/superset/pull/18799#discussion_r809629508



##########
File path: superset-frontend/src/components/Select/Select.tsx
##########
@@ -63,12 +62,7 @@ type PickedSelectProps = Pick<
   | 'value'
 >;
 
-type OptionsProps = Exclude<AntdSelectAllProps['options'], undefined>;
-
-export interface OptionsType extends Omit<OptionsProps, 'label'> {
-  label?: string;
-  customLabel?: ReactNode;
-}

Review comment:
       Bycatch: `OptionsProps ` is `(OptionData | OptionGroupData)[]` so this interface extension has no effect.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org