checksums: new warnings

[Greg Stein <gs...@gmail.com>]

Hyrum,

I just noticed this in the compilation output recently:

subversion/libsvn_wc/adm_ops.c: In function 'process_committed_leaf':
subversion/libsvn_wc/adm_ops.c:358: warning: assignment discards
qualifiers from pointer target type

Looks like one of the patterns of your updates is creating new warnings.

In this particular case, it seems that the correct answer is to
further propagate the checksum out from process_committed_leaf(). That
is, have the function take an svn_checksum_t rather than a bare
digest.

Anyways... I wanted to hilite the issue in case you hadn't seen it.

Cheers,
-g

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: checksums: new warnings

["Hyrum K. Wright" <hy...@mail.utexas.edu>]

Greg Stein wrote:
> Hyrum,
> 
> I just noticed this in the compilation output recently:
> 
> subversion/libsvn_wc/adm_ops.c: In function 'process_committed_leaf':
> subversion/libsvn_wc/adm_ops.c:358: warning: assignment discards
> qualifiers from pointer target type
> 
> Looks like one of the patterns of your updates is creating new warnings.
> 
> In this particular case, it seems that the correct answer is to
> further propagate the checksum out from process_committed_leaf(). That
> is, have the function take an svn_checksum_t rather than a bare
> digest.
> 
> Anyways... I wanted to hilite the issue in case you hadn't seen it.

Thanks.  Hopefully this warning was easier to find as the number of deprecation
warnings has decreased.

In any case, r33379.

-Hyrum