[GitHub] [arrow] nevi-me commented on a change in pull request #9211: ARROW-11239: [Rust] Fixed equality with offsets and nulls

[GitBox <gi...@apache.org>]

nevi-me commented on a change in pull request #9211:
URL: https://github.com/apache/arrow/pull/9211#discussion_r566428889



##########
File path: rust/arrow/src/array/equal/boolean.rs
##########
@@ -77,20 +77,14 @@ pub(super) fn boolean_equal(
         let rhs_null_bytes = rhs_nulls.as_ref().unwrap().as_slice();
 
         (0..len).all(|i| {
-            let lhs_pos = lhs_start + i;
-            let rhs_pos = rhs_start + i;
+            let lhs_pos = lhs.offset() + lhs_start + i;
+            let rhs_pos = rhs.offset() + rhs_start + i;

Review comment:
       There was a comment from @mqy about moving this out of the iter, as it was hurting performance.
   It's unexpected that this wouldn't be hoisted out by the compiler, but IIWII.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org