[jira] [Resolved] (THRIFT-3791) Delphi pipe client may fail even in a non-error condition

["Jens Geyer (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/THRIFT-3791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jens Geyer resolved THRIFT-3791.
--------------------------------
       Resolution: Fixed
    Fix Version/s: 0.10.0

Committed, thanks!

> Delphi pipe client may fail even in a non-error condition
> ---------------------------------------------------------
>
>                 Key: THRIFT-3791
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3791
>             Project: Thrift
>          Issue Type: Bug
>          Components: Delphi - Library
>    Affects Versions: 1.0
>            Reporter: Kyle Johnson
>            Assignee: Jens Geyer
>             Fix For: 0.10.0
>
>         Attachments: THRIFT-3791-fix-for-calling-GetLastError-even-on-success.patch
>
>
> In TPipeStreamBase.ReadDirect(), the code performs a peek on the pipe.  If no data is available (bytes = 0), GetLastError is still checked, even though Microsoft documentation clearly states that not all functions set the last error code to 0 on success (https://msdn.microsoft.com/en-us/library/windows/desktop/ms679360(v=vs.85).aspx).  Furthermore, because PeekNamedPipe only mentions that GetLastError should be called on failure, the logic of the if test must be changed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)