You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by ah...@apache.org on 2020/02/13 11:49:01 UTC
[commons-numbers] branch master updated (b792580 -> f2fc031)
This is an automated email from the ASF dual-hosted git repository.
aherbert pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/commons-numbers.git.
from b792580 Merge branch 'NUMBERS-40__Matt'
new 9a8e1c5 Fixed spotbugs filter for JMH module.
new 10ec694 Removed version for plugins which are managed by commons parent.
new b73017f Update to parent 50
new f2fc031 Disable PMD analysis for benchmarking code.
The 4 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
commons-numbers-examples/examples-jmh/pom.xml | 2 ++
pom.xml | 10 ++++------
src/main/resources/spotbugs/spotbugs-exclude-filter.xml | 14 ++++++++++++--
3 files changed, 18 insertions(+), 8 deletions(-)
[commons-numbers] 02/04: Removed version for plugins which are
managed by commons parent.
Posted by ah...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
aherbert pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-numbers.git
commit 10ec6946c4181af301706dd8718171f7a8b0edf8
Author: aherbert <ah...@apache.org>
AuthorDate: Thu Feb 13 11:26:24 2020 +0000
Removed version for plugins which are managed by commons parent.
maven-compiler-plugin : 3.8.1 -> 3.8.1
maven-surefire-plugin : 2.22.0 -> 2.22.2
maven-failsafe-plugin : 2.22.0 -> 2.22.2
apache-rat-plugin : ${commons.rat.version}
maven-antrun-plugin : 1.7 -> 1.8
---
pom.xml | 5 -----
1 file changed, 5 deletions(-)
diff --git a/pom.xml b/pom.xml
index 9d13e2e..5692d47 100644
--- a/pom.xml
+++ b/pom.xml
@@ -207,7 +207,6 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
- <version>3.8.1</version>
<configuration>
<compilerArgs>
<!-- <arg>-verbose</arg> -->
@@ -218,11 +217,9 @@
<plugin>
<artifactId>maven-surefire-plugin</artifactId>
- <version>2.22.0</version>
</plugin>
<plugin>
<artifactId>maven-failsafe-plugin</artifactId>
- <version>2.22.0</version>
</plugin>
<plugin>
<artifactId>maven-assembly-plugin</artifactId>
@@ -316,7 +313,6 @@
<plugin>
<groupId>org.apache.rat</groupId>
<artifactId>apache-rat-plugin</artifactId>
- <version>${commons.rat.version}</version>
<configuration>
<!--
Needed for command-line access, e.g mvn apache-rat:rat and mvn apache-rat:check
@@ -516,7 +512,6 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-antrun-plugin</artifactId>
- <version>1.7</version>
<executions>
<execution>
<id>prepare-checkout</id>
[commons-numbers] 03/04: Update to parent 50
Posted by ah...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
aherbert pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-numbers.git
commit b73017f04eb65fbac02b0c650006e3231d9c9840
Author: aherbert <ah...@apache.org>
AuthorDate: Thu Feb 13 11:26:41 2020 +0000
Update to parent 50
---
pom.xml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/pom.xml b/pom.xml
index 5692d47..74eee73 100644
--- a/pom.xml
+++ b/pom.xml
@@ -21,7 +21,7 @@
<parent>
<groupId>org.apache.commons</groupId>
<artifactId>commons-parent</artifactId>
- <version>49</version>
+ <version>50</version>
</parent>
<groupId>org.apache.commons</groupId>
[commons-numbers] 04/04: Disable PMD analysis for benchmarking code.
Posted by ah...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
aherbert pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-numbers.git
commit f2fc03187d3bcad2d609f499572e674940f1cfa6
Author: aherbert <ah...@apache.org>
AuthorDate: Thu Feb 13 11:45:29 2020 +0000
Disable PMD analysis for benchmarking code.
---
commons-numbers-examples/examples-jmh/pom.xml | 2 ++
pom.xml | 3 +++
2 files changed, 5 insertions(+)
diff --git a/commons-numbers-examples/examples-jmh/pom.xml b/commons-numbers-examples/examples-jmh/pom.xml
index 6d9ff4c..544c24f 100644
--- a/commons-numbers-examples/examples-jmh/pom.xml
+++ b/commons-numbers-examples/examples-jmh/pom.xml
@@ -82,6 +82,8 @@
<jmh.version>1.22</jmh.version>
<uberjar.name>examples-jmh</uberjar.name>
<project.mainClass>org.openjdk.jmh.Main</project.mainClass>
+ <!-- Disable analysis for benchmarking code. -->
+ <pmd.skip>true</pmd.skip>
</properties>
<profiles>
diff --git a/pom.xml b/pom.xml
index 74eee73..55885c6 100644
--- a/pom.xml
+++ b/pom.xml
@@ -308,6 +308,9 @@
<rulesets>
<ruleset>${numbers.parent.dir}/src/main/resources/pmd/pmd-ruleset.xml</ruleset>
</rulesets>
+ <excludeRoots>
+ <excludeRoot>target/generated-sources</excludeRoot>
+ </excludeRoots>
</configuration>
</plugin>
<plugin>
[commons-numbers] 01/04: Fixed spotbugs filter for JMH module.
Posted by ah...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
aherbert pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-numbers.git
commit 9a8e1c53fe815eff7680726d31be50d5cd298f76
Author: aherbert <ah...@apache.org>
AuthorDate: Thu Feb 13 11:22:31 2020 +0000
Fixed spotbugs filter for JMH module.
Ignore the generated JMH files.
Ignore exposing internal array for test data classes in Performance
classes.
Fixed XML schema namespace.
---
src/main/resources/spotbugs/spotbugs-exclude-filter.xml | 14 ++++++++++++--
1 file changed, 12 insertions(+), 2 deletions(-)
diff --git a/src/main/resources/spotbugs/spotbugs-exclude-filter.xml b/src/main/resources/spotbugs/spotbugs-exclude-filter.xml
index 5d18f8e..c3012e8 100644
--- a/src/main/resources/spotbugs/spotbugs-exclude-filter.xml
+++ b/src/main/resources/spotbugs/spotbugs-exclude-filter.xml
@@ -22,9 +22,13 @@
put here to instruct spotbugs it must ignore them.
-->
<FindBugsFilter
- xmlns="https://github.com/spotbugs/filter/3.1.0"
+ xmlns="https://github.com/spotbugs/filter/3.0.0"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
- xsi:schemaLocation="https://github.com/spotbugs/filter/3.1.0 https://raw.githubusercontent.com/spotbugs/spotbugs/3.1.0/spotbugs/etc/findbugsfilter.xsd">
+ xsi:schemaLocation="https://github.com/spotbugs/filter/3.0.0 https://raw.githubusercontent.com/spotbugs/spotbugs/3.1.0/spotbugs/etc/findbugsfilter.xsd">
+
+ <Match>
+ <Class name="~.*\.jmh\..*generated\..*"/>
+ </Match>
<!-- Deliberately floating-point equality checks. -->
<Match>
@@ -38,4 +42,10 @@
<BugPattern name="FE_FLOATING_POINT_EQUALITY"/>
</Match>
+ <Match>
+ <!-- Benchmark state classes can expose internal representations -->
+ <Class name="~org.apache.commons.numbers.examples.jmh..*Performance.*"/>
+ <BugPattern name="EI_EXPOSE_REP"/>
+ </Match>
+
</FindBugsFilter>