You are viewing a plain text version of this content. The canonical link for it is here.

Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2021/03/18 14:47:27 UTC

[GitHub] [hadoop] steveloughran commented on a change in pull request #2778: HADOOP-13551. AWS metrics wire-up

steveloughran commented on a change in pull request #2778:
URL: https://github.com/apache/hadoop/pull/2778#discussion_r596941307



##########
File path: hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/DefaultS3ClientFactory.java
##########
@@ -70,22 +67,24 @@
       LoggerFactory.getLogger(DefaultS3ClientFactory.class);
 
   /**
-   * Create the client.
+   * Create the client by preparing the AwsConf configuration
+   * and then invoking {@link #buildAmazonS3Client(AWSCredentialsProvider, ClientConfiguration, S3ClientCreationParameters, String, boolean)}

Review comment:
       changed to @code; it was this that the javadocs were unhappy with




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org