You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2021/07/26 16:57:35 UTC
[GitHub] [activemq-artemis] franz1981 opened a new pull request #3672: ARTEMIS-3402 Split Brain detection should reject bad member updates
franz1981 opened a new pull request #3672:
URL: https://github.com/apache/activemq-artemis/pull/3672
https://issues.apache.org/jira/browse/ARTEMIS-3402
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] franz1981 commented on pull request #3672: ARTEMIS-3402 Split Brain detection should reject bad member updates
Posted by GitBox <gi...@apache.org>.
franz1981 commented on pull request #3672:
URL: https://github.com/apache/activemq-artemis/pull/3672#issuecomment-887254605
@clebertsuconic CI seems fine with this, although I've left the
```
memberInput.setLive(connector);
```
and I would like to understand what's its purpose
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] franz1981 commented on pull request #3672: ARTEMIS-3402 Split Brain detection should reject bad member updates
Posted by GitBox <gi...@apache.org>.
franz1981 commented on pull request #3672:
URL: https://github.com/apache/activemq-artemis/pull/3672#issuecomment-887351725
This is read to be reviewed now :+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] franz1981 edited a comment on pull request #3672: ARTEMIS-3402 Split Brain detection should reject bad member updates
Posted by GitBox <gi...@apache.org>.
franz1981 edited a comment on pull request #3672:
URL: https://github.com/apache/activemq-artemis/pull/3672#issuecomment-887254605
@clebertsuconic CI seems fine with this, although I've left the
```
memberInput.setLive(connector);
```
and I would like to understand what's its purpose
I'm now writing a test to save regressions to happen
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] franz1981 commented on pull request #3672: ARTEMIS-3402 Split Brain detection should reject bad member updates
Posted by GitBox <gi...@apache.org>.
franz1981 commented on pull request #3672:
URL: https://github.com/apache/activemq-artemis/pull/3672#issuecomment-887357468
Given the comment on https://github.com/apache/activemq-artemis/pull/3672#issuecomment-887184813 I'm going to merge it after few hours: the CI is already happy with it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] franz1981 edited a comment on pull request #3672: ARTEMIS-3402 Split Brain detection should reject bad member updates
Posted by GitBox <gi...@apache.org>.
franz1981 edited a comment on pull request #3672:
URL: https://github.com/apache/activemq-artemis/pull/3672#issuecomment-886869350
@clebertsuconic @brusdev that's a conservative version of the fix (still lack a test): I still don't understand
```java
memberInput.setLive(connector);
```
code path that's going to be taken if the proposed live is `null` iff split brain detection is enabled (that happen just with replication)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic commented on pull request #3672: ARTEMIS-3402 Split Brain detection should reject bad member updates
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on pull request #3672:
URL: https://github.com/apache/activemq-artemis/pull/3672#issuecomment-887959656
I don't remember the exact conditions I have seen on DNSSwitchTest. That was to fix the condition bought by the split brain.
I would have to debug again to give you some understanding. You could add some log.debug into that and view the information there.
as I said I'm happy with this if tests are good. Make sure you run DNSSwitchTest a couple of times manually on your laptop please.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] franz1981 commented on pull request #3672: ARTEMIS-3402 Split Brain detection should reject bad member updates
Posted by GitBox <gi...@apache.org>.
franz1981 commented on pull request #3672:
URL: https://github.com/apache/activemq-artemis/pull/3672#issuecomment-886869350
@clebertsuconic @brusdev that's a conservative version of the fix (still lack a test): I still don't understand
```java
memberInput.setLive(connector);
```
code path that's going to be taken if the proposed live is `null`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] franz1981 edited a comment on pull request #3672: ARTEMIS-3402 Split Brain detection should reject bad member updates
Posted by GitBox <gi...@apache.org>.
franz1981 edited a comment on pull request #3672:
URL: https://github.com/apache/activemq-artemis/pull/3672#issuecomment-887351725
This is ready to be reviewed now :+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic commented on pull request #3672: ARTEMIS-3402 Split Brain detection should reject bad member updates
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on pull request #3672:
URL: https://github.com/apache/activemq-artemis/pull/3672#issuecomment-887184813
If you tested (running the test suite) LGTM.
I feel like I missed the return on the code.
thanks for the fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] asfgit closed pull request #3672: ARTEMIS-3402 Split Brain detection should reject bad member updates
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3672:
URL: https://github.com/apache/activemq-artemis/pull/3672
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] franz1981 edited a comment on pull request #3672: ARTEMIS-3402 Split Brain detection should reject bad member updates
Posted by GitBox <gi...@apache.org>.
franz1981 edited a comment on pull request #3672:
URL: https://github.com/apache/activemq-artemis/pull/3672#issuecomment-886869350
@clebertsuconic @brusdev that's a conservative version of the fix (still lack a test): I still don't understand
```java
memberInput.setLive(connector);
```
code path that's going to be taken if the proposed live is `null` only if the split brain detection is enabled (that happen just with replication)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org