You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by patricker <gi...@git.apache.org> on 2016/09/10 04:13:32 UTC

[GitHub] nifi pull request #1000: NIFI-2754

GitHub user patricker opened a pull request:

    https://github.com/apache/nifi/pull/1000

    NIFI-2754

    If the Active queue is empty and the number of FlowFiles added to the queue is perfectly splitable by the current Swap size (100000 Flow Files / 20000 files per swap file = 5 with no remainder), then no FlowFiles will move to Active and all will remain in Swap.
    
    Apart from NIFI-2754, there was also a style violation in the existing code, which I fixed.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/patricker/nifi NIFI-2754

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/1000.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1000
    
----
commit 7bdbcab17873be60f52a56a4cfa9b012c2857ad9
Author: Peter Wicks <pw...@micron.com>
Date:   2016-09-10T04:10:01Z

    NIFI-2754

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #1000: NIFI-2754

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/nifi/pull/1000


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #1000: NIFI-2754

Posted by markap14 <gi...@git.apache.org>.
Github user markap14 commented on the issue:

    https://github.com/apache/nifi/pull/1000
  
    @patricker @mcgilman looking at the PR, I do think that this will resolve the specific use case that you're running into, Peter. I think, though, that it is addressing a very specific corner case and could actually be solved a little more generally, though. Instead of changing the number of swap files based on the specific condition of `activeQueue.size() == 0 && numSwapFiles > 0 && swapQueue.size() % SWAP_RECORD_POLL_SIZE == 0` what do you think of just calling `migrateSwapToActive()` at the beginning of the `writeSwapFilesIfNecessary()`? This should also ensure that we keep with the same ordering guarantees that we have provided throughout the rest of the class.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #1000: NIFI-2754

Posted by mcgilman <gi...@git.apache.org>.
Github user mcgilman commented on the issue:

    https://github.com/apache/nifi/pull/1000
  
    Thanks for the PR @patricker! The proposed solution makes sense to me but I would love to get @markap14 input before signing off as I know he's much more familiar with this part of the codebase.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #1000: NIFI-2754

Posted by patricker <gi...@git.apache.org>.
Github user patricker commented on the issue:

    https://github.com/apache/nifi/pull/1000
  
    @markap14 I changed the code per your suggestion and the test I wrote still worked as expected.
    PR updated.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #1000: NIFI-2754

Posted by mcgilman <gi...@git.apache.org>.
Github user mcgilman commented on the issue:

    https://github.com/apache/nifi/pull/1000
  
    Thanks @patricker! Following Mark's suggestion and your update, I've gone ahead and merged this into master.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---