You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@openwhisk.apache.org by st...@apache.org on 2023/05/31 01:00:04 UTC

[openwhisk] branch master updated: Finish setup on error (#5419)

This is an automated email from the ASF dual-hosted git repository.

style95 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/openwhisk.git


The following commit(s) were added to refs/heads/master by this push:
     new 88156c3c3 Finish setup on error (#5419)
88156c3c3 is described below

commit 88156c3c382dff013dc9f636ac49f0a39886cbce
Author: Dominic Kim <st...@apache.org>
AuthorDate: Wed May 31 09:59:56 2023 +0900

    Finish setup on error (#5419)
    
    * Fast-fail on errors
    
    * Fix an indentation error
    
    * Fail the setup script on an error
---
 .github/workflows/0-on-demand.yaml     |  3 +++
 .github/workflows/1-unit.yaml          |  5 ++++-
 .github/workflows/2-system.yaml        |  5 ++++-
 .github/workflows/3-multi-runtime.yaml |  5 ++++-
 .github/workflows/4-standalone.yaml    |  5 ++++-
 .github/workflows/5-scheduler.yaml     |  5 ++++-
 .github/workflows/6-performance.yaml   | 17 ++++++++++-------
 tools/github/setup.sh                  |  2 ++
 8 files changed, 35 insertions(+), 12 deletions(-)

diff --git a/.github/workflows/0-on-demand.yaml b/.github/workflows/0-on-demand.yaml
index a39a379d9..33c3480fe 100644
--- a/.github/workflows/0-on-demand.yaml
+++ b/.github/workflows/0-on-demand.yaml
@@ -64,6 +64,9 @@ env:
 jobs:
   openwhisk:
     runs-on: ubuntu-22.04
+    continue-on-error: false
+      strategy:
+        fail-fast: true
     steps:
       - name: Checkout
         uses: actions/checkout@v3
diff --git a/.github/workflows/1-unit.yaml b/.github/workflows/1-unit.yaml
index c52bfd43a..57914249c 100644
--- a/.github/workflows/1-unit.yaml
+++ b/.github/workflows/1-unit.yaml
@@ -49,11 +49,14 @@ env:
 
   # github
   GH_BUILD: ${{ github.event_name }}-${{ github.sha }}
-  GH_BRANCH: ${{ github.head_ref || github.ref_name }} 
+  GH_BRANCH: ${{ github.head_ref || github.ref_name }}
 
 jobs:
   openwhisk:
     runs-on: ubuntu-22.04
+    continue-on-error: false
+    strategy:
+      fail-fast: true
     steps:
       - name: Checkout
         uses: actions/checkout@v3
diff --git a/.github/workflows/2-system.yaml b/.github/workflows/2-system.yaml
index 5e8b2f8ba..1ac72c224 100644
--- a/.github/workflows/2-system.yaml
+++ b/.github/workflows/2-system.yaml
@@ -44,11 +44,14 @@ env:
 
   # github
   GH_BUILD: ${{ github.event_name }}-${{ github.sha }}
-  GH_BRANCH: ${{ github.head_ref || github.ref_name }} 
+  GH_BRANCH: ${{ github.head_ref || github.ref_name }}
 
 jobs:
   openwhisk:
     runs-on: ubuntu-22.04
+    continue-on-error: false
+    strategy:
+      fail-fast: true
     steps:
       - name: Checkout
         uses: actions/checkout@v3
diff --git a/.github/workflows/3-multi-runtime.yaml b/.github/workflows/3-multi-runtime.yaml
index c25c45584..3ed3601ea 100644
--- a/.github/workflows/3-multi-runtime.yaml
+++ b/.github/workflows/3-multi-runtime.yaml
@@ -44,11 +44,14 @@ env:
 
   # github
   GH_BUILD: ${{ github.event_name }}-${{ github.sha }}
-  GH_BRANCH: ${{ github.head_ref || github.ref_name }} 
+  GH_BRANCH: ${{ github.head_ref || github.ref_name }}
 
 jobs:
   openwhisk:
     runs-on: ubuntu-22.04
+    continue-on-error: false
+    strategy:
+      fail-fast: true
     steps:
       - name: Checkout
         uses: actions/checkout@v3
diff --git a/.github/workflows/4-standalone.yaml b/.github/workflows/4-standalone.yaml
index 022763a30..a5dc2b97b 100644
--- a/.github/workflows/4-standalone.yaml
+++ b/.github/workflows/4-standalone.yaml
@@ -44,11 +44,14 @@ env:
 
   # github
   GH_BUILD: ${{ github.event_name }}-${{ github.sha }}
-  GH_BRANCH: ${{ github.head_ref || github.ref_name }} 
+  GH_BRANCH: ${{ github.head_ref || github.ref_name }}
 
 jobs:
   openwhisk:
     runs-on: ubuntu-22.04
+    continue-on-error: false
+    strategy:
+      fail-fast: true
     steps:
       - name: Checkout
         uses: actions/checkout@v3
diff --git a/.github/workflows/5-scheduler.yaml b/.github/workflows/5-scheduler.yaml
index 78742c0e3..678f4e973 100644
--- a/.github/workflows/5-scheduler.yaml
+++ b/.github/workflows/5-scheduler.yaml
@@ -44,11 +44,14 @@ env:
 
   # github
   GH_BUILD: ${{ github.event_name }}-${{ github.sha }}
-  GH_BRANCH: ${{ github.head_ref || github.ref_name }} 
+  GH_BRANCH: ${{ github.head_ref || github.ref_name }}
 
 jobs:
   openwhisk:
     runs-on: ubuntu-22.04
+    continue-on-error: false
+    strategy:
+      fail-fast: true
     steps:
       - name: Checkout
         uses: actions/checkout@v3
diff --git a/.github/workflows/6-performance.yaml b/.github/workflows/6-performance.yaml
index ff3c81867..0837a670c 100644
--- a/.github/workflows/6-performance.yaml
+++ b/.github/workflows/6-performance.yaml
@@ -44,11 +44,14 @@ env:
 
   # github
   GH_BUILD: ${{ github.event_name }}-${{ github.sha }}
-  GH_BRANCH: ${{ github.head_ref || github.ref_name }} 
+  GH_BRANCH: ${{ github.head_ref || github.ref_name }}
 
 jobs:
   openwhisk:
     runs-on: ubuntu-22.04
+    continue-on-error: false
+    strategy:
+      fail-fast: true
     steps:
       - name: Checkout
         uses: actions/checkout@v3
@@ -79,9 +82,9 @@ jobs:
       - run: OPENWHISK_HOST="172.17.0.1" USERS="1" REQUESTS_PER_SEC="1" ./gradlew gatlingRun-org.apache.openwhisk.ColdBlockingInvokeSimulation
         continue-on-error: true
       - name: Slack Notification
-        run: > 
-             ./tools/github/writeOnSlack.sh
-             "[$TEST_SUITE]" ${{ steps.tests.outcome }} on ${GH_BUILD}
-             $'\nbranch:' $GH_BRANCH
-             $'\nmessage:' "$(git log -1 --oneline | cat)"
-             $'\nCheck GitHub logs for results'
+        run: >
+          ./tools/github/writeOnSlack.sh
+          "[$TEST_SUITE]" ${{ steps.tests.outcome }} on ${GH_BUILD}
+          $'\nbranch:' $GH_BRANCH
+          $'\nmessage:' "$(git log -1 --oneline | cat)"
+          $'\nCheck GitHub logs for results'
diff --git a/tools/github/setup.sh b/tools/github/setup.sh
index aefb21047..c975696c7 100755
--- a/tools/github/setup.sh
+++ b/tools/github/setup.sh
@@ -20,6 +20,8 @@
 #then echo skipping setup ; exit 0
 #fi
 
+set -e
+
 # retries a command for five times and exits with the non-zero exit if even after
 # the retries the command did not succeed.
 function retry() {