You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by xubo245 <gi...@git.apache.org> on 2017/10/10 13:20:56 UTC
[GitHub] carbondata pull request #1408: [CARBONDATA-1568] Optimize annotation of code
GitHub user xubo245 opened a pull request:
https://github.com/apache/carbondata/pull/1408
[CARBONDATA-1568] Optimize annotation of code
There are some improper places in code annotation by IDEA inspect code
We optimize annotation of code:
- Fix an error of Javadoc issues
- modify the expression of annotation
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/xubo245/carbondata docsOptimize
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/1408.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1408
----
commit 5fcfcf5888e0fc1d35a8f211b10090d0d9d6c39f
Author: xubo245 <60...@qq.com>
Date: 2017-10-10T12:59:46Z
[CARBONDATA-1568] Optimize annotation of code
----
---
[GitHub] carbondata issue #1408: [CARBONDATA-1568] Optimize annotation of code
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/1408
LGTM
---
[GitHub] carbondata issue #1408: [CARBONDATA-1568] Optimize annotation of code
Posted by chenliang613 <gi...@git.apache.org>.
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/1408
LGTM
---
[GitHub] carbondata issue #1408: [CARBONDATA-1568] Optimize annotation of code
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1408
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1080/
---
[GitHub] carbondata issue #1408: [CARBONDATA-1568] Optimize annotation of code
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1408
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/494/
---
[GitHub] carbondata issue #1408: [CARBONDATA-1568] Optimize annotation of code
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1408
Build Failed with Spark 1.6, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/370/
---
[GitHub] carbondata issue #1408: [CARBONDATA-1568] Optimize annotation of code
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1408
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/451/
---
[GitHub] carbondata pull request #1408: [CARBONDATA-1568] Optimize annotation of code
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/1408
---
[GitHub] carbondata issue #1408: [CARBONDATA-1568] Optimize annotation of code
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1408
Build Failed with Spark 1.6, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/326/
---
[GitHub] carbondata issue #1408: [CARBONDATA-1568] Optimize annotation of code
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1408
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1043/
---
[GitHub] carbondata issue #1408: [CARBONDATA-1568] Optimize annotation of code
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1408
Build Success with Spark 1.6, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/327/
---
[GitHub] carbondata issue #1408: [CARBONDATA-1568] Optimize annotation of code
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1408
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1122/
---
[GitHub] carbondata issue #1408: [CARBONDATA-1568] Optimize annotation of code
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1408
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/412/
---
[GitHub] carbondata issue #1408: [CARBONDATA-1568] Optimize annotation of code
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1408
Build Failed with Spark 1.6, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/289/
---
[GitHub] carbondata issue #1408: [CARBONDATA-1568] Optimize annotation of code
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1408
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1079/
---
[GitHub] carbondata issue #1408: [CARBONDATA-1568] Optimize annotation of code
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1408
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1126/
---
[GitHub] carbondata issue #1408: [CARBONDATA-1568] Optimize annotation of code
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1408
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/498/
---
[GitHub] carbondata pull request #1408: [CARBONDATA-1568] Optimize annotation of code
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1408#discussion_r143777860
--- Diff: integration/spark/src/main/scala/org/apache/carbondata/spark/CarbonDataFrameWriter.scala ---
@@ -59,8 +59,8 @@ class CarbonDataFrameWriter(val dataFrame: DataFrame) {
/**
* Firstly, saving DataFrame to CSV files
* Secondly, load CSV files
- * @param options
- * @param cc
+ * @param options CarbonOption
--- End diff --
add more explain for parameters.
---
[GitHub] carbondata issue #1408: [CARBONDATA-1568] Optimize annotation of code
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1408
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/452/
---