You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "xwm1992 (via GitHub)" <gi...@apache.org> on 2023/10/26 09:16:19 UTC
[PR] [ISSUE #4513]Add eventmesh filter & transform sub module (eventmesh)
xwm1992 opened a new pull request, #4514:
URL: https://github.com/apache/eventmesh/pull/4514
<!--
### Contribution Checklist
- Name the pull request in the form "[ISSUE #XXXX] Title of the pull request",
where *XXXX* should be replaced by the actual issue number.
Skip *[ISSUE #XXXX]* if there is no associated github issue for this pull request.
- Fill out the template below to describe the changes contributed by the pull request.
That will give reviewers the context they need to do the review.
- Each pull request should address only one issue.
Please do not mix up code from multiple issues.
- Each commit in the pull request should have a meaningful commit message.
- Once all items of the checklist are addressed, remove the above text and this checklist,
leaving only the filled out template below.
(The sections below can be removed for hotfixes of typos)
-->
<!--
(If this PR fixes a GitHub issue, please add `Fixes #<XXX>` or `Closes #<XXX>`.)
-->
Fixes #4513 .
### Motivation
*Explain the content here.*
*Explain why you want to make the changes and what problem you're trying to solve.*
### Modifications
*Describe the modifications you've done.*
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
Re: [PR] [ISSUE #4513]Add eventmesh filter & transform sub module (eventmesh)
Posted by "xwm1992 (via GitHub)" <gi...@apache.org>.
xwm1992 commented on code in PR #4514:
URL: https://github.com/apache/eventmesh/pull/4514#discussion_r1374004215
##########
settings.gradle:
##########
@@ -23,6 +23,8 @@ include 'eventmesh-common'
include 'eventmesh-starter'
include 'eventmesh-examples'
include 'eventmesh-spi'
+include 'eventmesh-filter'
+include 'eventmesh-transform'
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] [ISSUE #4513]Add eventmesh filter & transform sub module (eventmesh)
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #4514:
URL: https://github.com/apache/eventmesh/pull/4514#issuecomment-1780779323
## [Codecov](https://app.codecov.io/gh/apache/eventmesh/pull/4514?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#4514](https://app.codecov.io/gh/apache/eventmesh/pull/4514?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (ef9e609) into [master](https://app.codecov.io/gh/apache/eventmesh/commit/a717d3503af42de7c8757cbc4627caa71a9ee23a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (a717d35) will **decrease** coverage by `0.08%`.
> Report is 2 commits behind head on master.
> The diff coverage is `41.37%`.
> :exclamation: Current head ef9e609 differs from pull request most recent head 351da46. Consider uploading reports for the commit 351da46 to get more accurate results
```diff
@@ Coverage Diff @@
## master #4514 +/- ##
============================================
- Coverage 15.95% 15.88% -0.08%
- Complexity 1535 1540 +5
============================================
Files 713 729 +16
Lines 28711 28884 +173
Branches 2734 2742 +8
============================================
+ Hits 4580 4587 +7
- Misses 23650 23814 +164
- Partials 481 483 +2
```
| [Files](https://app.codecov.io/gh/apache/eventmesh/pull/4514?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...java/org/apache/eventmesh/filter/PatternEntry.java](https://app.codecov.io/gh/apache/eventmesh/pull/4514?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLWZpbHRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2ZpbHRlci9QYXR0ZXJuRW50cnkuamF2YQ==) | `85.71% <ø> (ø)` | |
| [...entmesh/filter/condition/AnythingButCondition.java](https://app.codecov.io/gh/apache/eventmesh/pull/4514?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLWZpbHRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2ZpbHRlci9jb25kaXRpb24vQW55dGhpbmdCdXRDb25kaXRpb24uamF2YQ==) | `20.00% <100.00%> (ø)` | |
| [.../eventmesh/filter/condition/ConditionsBuilder.java](https://app.codecov.io/gh/apache/eventmesh/pull/4514?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLWZpbHRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2ZpbHRlci9jb25kaXRpb24vQ29uZGl0aW9uc0J1aWxkZXIuamF2YQ==) | `80.95% <100.00%> (ø)` | |
| [...he/eventmesh/filter/condition/ExistsCondition.java](https://app.codecov.io/gh/apache/eventmesh/pull/4514?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLWZpbHRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2ZpbHRlci9jb25kaXRpb24vRXhpc3RzQ29uZGl0aW9uLmphdmE=) | `75.00% <ø> (ø)` | |
| [...e/eventmesh/filter/condition/NumericCondition.java](https://app.codecov.io/gh/apache/eventmesh/pull/4514?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLWZpbHRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2ZpbHRlci9jb25kaXRpb24vTnVtZXJpY0NvbmRpdGlvbi5qYXZh) | `44.44% <ø> (ø)` | |
| [...he/eventmesh/filter/condition/PrefixCondition.java](https://app.codecov.io/gh/apache/eventmesh/pull/4514?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLWZpbHRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2ZpbHRlci9jb25kaXRpb24vUHJlZml4Q29uZGl0aW9uLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [...eventmesh/filter/condition/SpecifiedCondition.java](https://app.codecov.io/gh/apache/eventmesh/pull/4514?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLWZpbHRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2ZpbHRlci9jb25kaXRpb24vU3BlY2lmaWVkQ29uZGl0aW9uLmphdmE=) | `100.00% <ø> (ø)` | |
| [...he/eventmesh/filter/condition/SuffixCondition.java](https://app.codecov.io/gh/apache/eventmesh/pull/4514?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLWZpbHRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2ZpbHRlci9jb25kaXRpb24vU3VmZml4Q29uZGl0aW9uLmphdmE=) | `100.00% <ø> (ø)` | |
| [...a/org/apache/eventmesh/filter/pattern/Pattern.java](https://app.codecov.io/gh/apache/eventmesh/pull/4514?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLWZpbHRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2ZpbHRlci9wYXR0ZXJuL1BhdHRlcm4uamF2YQ==) | `65.38% <ø> (ø)` | |
| [.../eventmesh/filter/patternbuild/PatternBuilder.java](https://app.codecov.io/gh/apache/eventmesh/pull/4514?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLWZpbHRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2ZpbHRlci9wYXR0ZXJuYnVpbGQvUGF0dGVybkJ1aWxkZXIuamF2YQ==) | `72.28% <ø> (ø)` | |
| ... and [10 more](https://app.codecov.io/gh/apache/eventmesh/pull/4514?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [25 files with indirect coverage changes](https://app.codecov.io/gh/apache/eventmesh/pull/4514/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] [ISSUE #4513]Add eventmesh filter & transform sub module (eventmesh)
Posted by "Pil0tXia (via GitHub)" <gi...@apache.org>.
Pil0tXia commented on code in PR #4514:
URL: https://github.com/apache/eventmesh/pull/4514#discussion_r1373439106
##########
eventmesh-filter/src/main/java/org/apache/eventmesh/filter/exception/JsonException.java:
##########
@@ -0,0 +1,34 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.eventmesh.filter.exception;
+
+/**
+ * Json format exception
+ */
+public class JsonException extends RuntimeException {
+
Review Comment:
We already has a same class at `org.apache.eventmesh.common.exception.JsonException`.
##########
settings.gradle:
##########
@@ -23,6 +23,8 @@ include 'eventmesh-common'
include 'eventmesh-starter'
include 'eventmesh-examples'
include 'eventmesh-spi'
+include 'eventmesh-filter'
+include 'eventmesh-transform'
Review Comment:
`filter` is a noun however `transform` is a verb. How about `eventmesh-transformer`?
##########
eventmesh-common/build.gradle:
##########
@@ -25,8 +25,8 @@ dependencies {
api "org.apache.commons:commons-text"
api "org.apache.commons:commons-lang3"
- implementation group: 'com.jayway.jsonpath', name: 'json-path', version: '2.7.0'
- implementation 'commons-net:commons-net:3.9.0'
+ api "com.jayway.jsonpath:json-path"
+// implementation 'commons-net:commons-net:3.9.0'
api "io.cloudevents:cloudevents-core"
Review Comment:
Is the comment here still useful?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] [ISSUE #4513]Add eventmesh filter & transform sub module (eventmesh)
Posted by "xwm1992 (via GitHub)" <gi...@apache.org>.
xwm1992 commented on code in PR #4514:
URL: https://github.com/apache/eventmesh/pull/4514#discussion_r1374004026
##########
eventmesh-common/build.gradle:
##########
@@ -25,8 +25,8 @@ dependencies {
api "org.apache.commons:commons-text"
api "org.apache.commons:commons-lang3"
- implementation group: 'com.jayway.jsonpath', name: 'json-path', version: '2.7.0'
- implementation 'commons-net:commons-net:3.9.0'
+ api "com.jayway.jsonpath:json-path"
+// implementation 'commons-net:commons-net:3.9.0'
api "io.cloudevents:cloudevents-core"
Review Comment:
fixed
##########
eventmesh-filter/src/main/java/org/apache/eventmesh/filter/exception/JsonException.java:
##########
@@ -0,0 +1,34 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.eventmesh.filter.exception;
+
+/**
+ * Json format exception
+ */
+public class JsonException extends RuntimeException {
+
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] [ISSUE #4513]Add eventmesh filter & transform sub module (eventmesh)
Posted by "mxsm (via GitHub)" <gi...@apache.org>.
mxsm merged PR #4514:
URL: https://github.com/apache/eventmesh/pull/4514
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org