[GitHub] [maven-checkstyle-plugin] rnveach opened a new pull request #14: remove deprecated method calls

[GitBox <gi...@apache.org>]

rnveach opened a new pull request #14: remove deprecated method calls
URL: https://github.com/apache/maven-checkstyle-plugin/pull/14
 
 
   Since maven-checkstyle upgrade it's default version of checkstyle, we are hoping that we can replace the use of deprecated methods. This replaces deprecated methods with their newer replacements.
   These methods have been deprecated since probably 8.2 but can't be removed from main repo because the plugin still uses them and this would break our own CI which relies on the plugin. This would break backward compatibility in the plugin as these only came around at 8.2.
   
   `ConfigurationLoader.loadConfiguration` is also deprecated but hasn't been converted yet because I wanted your input on how you wanted to convert `request.isOmitIgnoredModules()` to the enumeration `IgnoredModulesOptions` as there is no conversion method.
   
   > MCHECKSTYLE-XXX
   
   Let me know if you are willing to accept this and it needs a JIRA.
   
   > mvn -Prun-its clean verify
   
   This doesn't pass for me even on master.
   ````
   [INFO] --- maven-invoker-plugin:3.1.0:integration-test (integration-test) @ maven-checkstyle-plugin ---
   [INFO] Building: check-fail\pom.xml
   [INFO] run post-build script verify.groovy
   [INFO]           check-fail\pom.xml ............................... FAILED (0.5 s)
   [INFO]   The post-build script did not succeed. assert buildLog.text.contains( "You have 1 Checkstyle violation" )
          |        |    |
          |        |    false
          |        Running post-build script: D:\Rickys\Java\checkstyleWorkspaceEclipse\maven-checkstyle-plugin\target\it\check-fail\verify.groovy
          D:\Rickys\Java\checkstyleWorkspaceEclipse\maven-checkstyle-plugin\target\it\check-fail\build.log
   ````
   
   ---------------------------------------------
   
   Following this checklist to help us incorporate your 
   contribution quickly and easily:
   
    - [X] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MCHECKSTYLE) filed 
          for the change (usually before you start working on it).  Trivial changes like typos do not 
          require a JIRA issue.  Your pull request should address just this issue, without 
          pulling in other changes.
    - [X] Each commit in the pull request should have a meaningful subject line and body.
    - [ ] Format the pull request title like `[MCHECKSTYLE-XXX] - Fixes bug in ApproximateQuantiles`,
          where you replace `MCHECKSTYLE-XXX` with the appropriate JIRA issue. Best practice
          is to use the JIRA issue title in the pull request title and in the first line of the 
          commit message.
    - [X] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
    - [X] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will 
          be performed on your pull request automatically.
    - [ ] You have run the integration tests successfully (`mvn -Prun-its clean verify`).
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
   please ask on the developers list.
   
   To make clear that you license your contribution under 
   the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
    - [X] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
    - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services