[GitHub] [kafka] dajac commented on a change in pull request #7498: KAFKA-9023: Log request destination when the Producer gets disconnected

[GitBox <gi...@apache.org>]

dajac commented on a change in pull request #7498:
URL: https://github.com/apache/kafka/pull/7498#discussion_r520520725



##########
File path: clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java
##########
@@ -639,8 +644,9 @@ else if (error == Errors.CLUSTER_AUTHORIZATION_FAILED)
                             "topic-partition may not exist or the user may not have Describe access to it",
                         batch.topicPartition);
                 } else {
-                    log.warn("Received invalid metadata error in produce request on partition {} due to {}. Going " +
-                            "to request metadata update now", batch.topicPartition, error.exception(response.errorMessage).toString());
+                    log.warn("Received invalid metadata error in produce request on partition {} due to {}{}. Going " +
+                            "to request metadata update now", batch.topicPartition,
+                            error.exception(response.errorMessage).toString(), errorMessageSuffix);

Review comment:
       It seems that we will print out the `errorMessage` twice in this case. `error.exception(response.errorMessage)` returns an `ApiException` with the `errorMessage` so its string representation will include it, no? 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org