[GitHub] [cassandra] shyla226 commented on a diff in pull request #1295: CASSANDRA-17034: Memtable API

[GitBox <gi...@apache.org>]

shyla226 commented on code in PR #1295:
URL: https://github.com/apache/cassandra/pull/1295#discussion_r852572920


##########
src/java/org/apache/cassandra/db/commitlog/CommitLogReplayer.java:
##########
@@ -130,7 +130,16 @@ public static CommitLogReplayer construct(CommitLog commitLog, UUID localHostId)
                 }
             }
 
-            IntervalSet<CommitLogPosition> filter = persistedIntervals(cfs.getLiveSSTables(), truncatedAt, localHostId);
+            IntervalSet<CommitLogPosition> filter;
+            if (!cfs.memtableWritesAreDurable())
+            {
+                filter = persistedIntervals(cfs.getLiveSSTables(), truncatedAt, localHostId);
+            }
+            else
+            {
+                // everything is persisted and restored by the memtable itself
+                filter = new IntervalSet<>(CommitLogPosition.NONE, CommitLog.instance.getCurrentPosition());

Review Comment:
   When memtableWritesAreDurable, restore to a point in time does not get correct intervals with this IntervalSet 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org