You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/04/16 01:41:42 UTC

[GitHub] [spark] HyukjinKwon commented on a change in pull request #32193: [SPARK-35101][INFRA] Add GitHub status check in PR instead of a comment

HyukjinKwon commented on a change in pull request #32193:
URL: https://github.com/apache/spark/pull/32193#discussion_r614500505



##########
File path: .github/workflows/notify_test_workflow.yml
##########
@@ -14,6 +39,10 @@ jobs:
           github-token: ${{ secrets.GITHUB_TOKEN }}
           script: |
             const endpoint = "GET /repos/:owner/:repo/actions/workflows/:id/runs?&branch=:branch"
+
+            // TODO: Should use pull_request.user and pull_request.user.repos_url?
+            // If a different person creates a commit to another forked repo,
+            // it would be able to detect.

Review comment:
       ```suggestion
               // it wouldn't be able to detect.
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org