[GitHub] [oodt] IMS94 commented on a change in pull request #121: Refactor React OPSUI sample app

[GitBox <gi...@apache.org>]

IMS94 commented on a change in pull request #121:
URL: https://github.com/apache/oodt/pull/121#discussion_r666960922



##########
File path: react-components/oodt_opsui_sample_app/.env.development
##########
@@ -1,2 +0,0 @@
-REACT_APP_FM_REST_API_URL=http://localhost:8080/cas_product_war/jaxrs/v2

Review comment:
       Let's keep this file

##########
File path: react-components/oodt_opsui_sample_app/src/constants/connection.js
##########
@@ -14,9 +14,12 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-
 import axios from "axios";
 
 export const fmconnection = axios.create({
-  baseURL: "http://"+window.location.hostname+":8080/cas_product_war/jaxrs/v2"
+  baseURL: "http://localhost:8080/cas_product_war/jaxrs/v2"
 });
+
+export const wmconnection = axios.create({
+    baseURL: "http://localhost:8080/workflow_services_war/wmservice/v2"

Review comment:
       Let's use `env` variables here.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@oodt.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org