You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/03/19 13:16:30 UTC

[GitHub] [spark] cloud-fan commented on a change in pull request #27946: [SPARK-31181][SQL][TESTS] Remove the default value assumption on CREATE TABLE test cases

cloud-fan commented on a change in pull request #27946: [SPARK-31181][SQL][TESTS] Remove the default value assumption on CREATE TABLE test cases
URL: https://github.com/apache/spark/pull/27946#discussion_r395016223
 
 

 ##########
 File path: sql/core/src/test/resources/sql-tests/inputs/postgreSQL/create_view.sql
 ##########
 @@ -41,7 +41,7 @@ DROP TABLE emp;
 -- These views are left around mainly to exercise special cases in pg_dump.
 
 -- [SPARK-19842] Informational Referential Integrity Constraints Support in Spark
-CREATE TABLE view_base_table (key int /* PRIMARY KEY */, data varchar(20));
+CREATE TABLE view_base_table (key int /* PRIMARY KEY */, data varchar(20)) USING PARQUET;
 
 Review comment:
   Shall we keep the pgsql test as what it is in pgsql?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org