You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by "zstan (via GitHub)" <gi...@apache.org> on 2023/07/03 09:02:50 UTC
[GitHub] [calcite] zstan commented on a diff in pull request #3211: [CALCITE-5708] Change SUBSTRING result if either of parameters is NULL
zstan commented on code in PR #3211:
URL: https://github.com/apache/calcite/pull/3211#discussion_r1250522704
##########
core/src/test/java/org/apache/calcite/test/SqlValidatorTest.java:
##########
@@ -1040,6 +1040,11 @@ void testDyadicCollateOperator() {
.columnType("VARCHAR(1) NOT NULL");
expr("substring('a', 1, '3')")
.columnType("VARCHAR(1) NOT NULL");
+
+ // Correctly processed null string and params.
Review Comment:
done
##########
core/src/test/resources/sql/functions.iq:
##########
@@ -938,5 +938,19 @@ table(AUX.TBLFUN_IDENTITY(3)) as t3(v);
!ok
+# SUBSTRING
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org