You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@karaf.apache.org by Christian Schneider <ch...@die-schneider.net> on 2015/11/30 17:36:23 UTC
Automatic Jenkins builds for pull requests
Apache Artemis is doing automatic jenkins runs for all pull requests. I
think this is really helpful as the contributor gets some good feedback
about the state of his request.
It also lowers the work of the committers as they can wait until the
pull request is in a good state.
If no one minds I will also install this for karaf.
Christian
--
Christian Schneider
http://www.liquid-reality.de
Open Source Architect
http://www.talend.com
Re: Automatic Jenkins builds for pull requests
Posted by Andrea Cosentino <an...@yahoo.com.INVALID>.
I think is a very good idea.
Thank you.
--
Andrea Cosentino
---------------------------------
Apache Camel PMC Member
Email: ancosen1985@yahoo.com
Twitter: @oscerd2
Github: oscerd
On Monday, November 30, 2015 5:36 PM, Christian Schneider <ch...@die-schneider.net> wrote:
Apache Artemis is doing automatic jenkins runs for all pull requests. I
think this is really helpful as the contributor gets some good feedback
about the state of his request.
It also lowers the work of the committers as they can wait until the
pull request is in a good state.
If no one minds I will also install this for karaf.
Christian
--
Christian Schneider
http://www.liquid-reality.de
Open Source Architect
http://www.talend.com
Re: Automatic Jenkins builds for pull requests
Posted by Jean-Baptiste Onofré <jb...@nanthrax.net>.
Sure, let me take a look.
Thanks,
Regards
JB
On 12/01/2015 07:46 AM, Christian Schneider wrote:
> That sounds great.
>
> You might have noticed that the test builds I did all failed. I just
> changed the Readme in my test pull request.
> Can you take a look why the build does not work in the same way as the
> master build?
>
> I was not yet able to find the difference.
>
> Christian
>
> Am 01.12.2015 um 07:20 schrieb Jean-Baptiste Onofré:
>> At Spark, we have:
>> - a comment added by Jenkins with the result of the build including
>> the PR
>> - a mail on the mailing list (on reviews) when the PR is ready to be
>> reviewed (when the build is fine)
>>
>> I will add this too.
>>
>> Regards
>> JB
>>
>
--
Jean-Baptiste Onofré
jbonofre@apache.org
http://blog.nanthrax.net
Talend - http://www.talend.com
Re: Automatic Jenkins builds for pull requests
Posted by Christian Schneider <ch...@die-schneider.net>.
That sounds great.
You might have noticed that the test builds I did all failed. I just
changed the Readme in my test pull request.
Can you take a look why the build does not work in the same way as the
master build?
I was not yet able to find the difference.
Christian
Am 01.12.2015 um 07:20 schrieb Jean-Baptiste Onofré:
> At Spark, we have:
> - a comment added by Jenkins with the result of the build including
> the PR
> - a mail on the mailing list (on reviews) when the PR is ready to be
> reviewed (when the build is fine)
>
> I will add this too.
>
> Regards
> JB
>
Re: Automatic Jenkins builds for pull requests
Posted by Jean-Baptiste Onofré <jb...@nanthrax.net>.
At Spark, we have:
- a comment added by Jenkins with the result of the build including the PR
- a mail on the mailing list (on reviews) when the PR is ready to be
reviewed (when the build is fine)
I will add this too.
Regards
JB
On 11/30/2015 07:21 PM, Christian Schneider wrote:
> I just set up the karaf-pr build. Lets see how it works when the first
> pull request is changed.
>
> It would be great to also have the Jira Integration. Not sure if this is
> what you meant but I think in jira the main thing missing is to see the
> commits. Of course seeing the pullrequests that match a jira will also
> make a lot of sense.
>
> Christian
>
> Am 30.11.2015 um 18:41 schrieb Jean-Baptiste Onofré:
>> On Spark, we use jenkins build for PR + plug to Jira and mailing.
>>
>> I will setup the same in Karaf.
>>
>> Regards
>> JB
>>
>> On 11/30/2015 05:36 PM, Christian Schneider wrote:
>>> Apache Artemis is doing automatic jenkins runs for all pull requests. I
>>> think this is really helpful as the contributor gets some good feedback
>>> about the state of his request.
>>> It also lowers the work of the committers as they can wait until the
>>> pull request is in a good state.
>>>
>>> If no one minds I will also install this for karaf.
>>>
>>> Christian
>>>
>>
>
--
Jean-Baptiste Onofré
jbonofre@apache.org
http://blog.nanthrax.net
Talend - http://www.talend.com
Re: Automatic Jenkins builds for pull requests
Posted by Christian Schneider <ch...@die-schneider.net>.
I just set up the karaf-pr build. Lets see how it works when the first
pull request is changed.
It would be great to also have the Jira Integration. Not sure if this is
what you meant but I think in jira the main thing missing is to see the
commits. Of course seeing the pullrequests that match a jira will also
make a lot of sense.
Christian
Am 30.11.2015 um 18:41 schrieb Jean-Baptiste Onofré:
> On Spark, we use jenkins build for PR + plug to Jira and mailing.
>
> I will setup the same in Karaf.
>
> Regards
> JB
>
> On 11/30/2015 05:36 PM, Christian Schneider wrote:
>> Apache Artemis is doing automatic jenkins runs for all pull requests. I
>> think this is really helpful as the contributor gets some good feedback
>> about the state of his request.
>> It also lowers the work of the committers as they can wait until the
>> pull request is in a good state.
>>
>> If no one minds I will also install this for karaf.
>>
>> Christian
>>
>
Re: Automatic Jenkins builds for pull requests
Posted by Jean-Baptiste Onofré <jb...@nanthrax.net>.
On Spark, we use jenkins build for PR + plug to Jira and mailing.
I will setup the same in Karaf.
Regards
JB
On 11/30/2015 05:36 PM, Christian Schneider wrote:
> Apache Artemis is doing automatic jenkins runs for all pull requests. I
> think this is really helpful as the contributor gets some good feedback
> about the state of his request.
> It also lowers the work of the committers as they can wait until the
> pull request is in a good state.
>
> If no one minds I will also install this for karaf.
>
> Christian
>
--
Jean-Baptiste Onofré
jbonofre@apache.org
http://blog.nanthrax.net
Talend - http://www.talend.com