You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Rajat Khandelwal <ra...@gmail.com> on 2015/07/22 15:25:15 UTC

Review Request 36690: LENS-686: Repetitive add partition with same specs should fail after first time.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36690/
-----------------------------------------------------------

Review request for lens.


Bugs: LENS-686
    https://issues.apache.org/jira/browse/LENS-686


Repository: lens


Description
-------


Diffs
-----

  lens-api/src/main/java/org/apache/lens/api/APIResult.java d0483731e930eb456935041c6b73be3665b199bb 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java c8abca098f31c5a5c1ad6d2b69807a359637bd40 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/Storage.java 873aa490e37c0306dec57cda31880ffa5a332045 
  lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java bd31f8243f4871f1d2d6fe76997287f9be82b6ab 
  lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 646de8c1b53fb7cbd85895a4ad672e68311931f0 
  lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 2d0eba23750542f1dd916d3c62af656c4dc2767c 
  lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java cb9516b2d8ac72a85eba045c3e664e1080e89b48 
  lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 4eb52b9773a65c28d98055ea1114581be641c28c 

Diff: https://reviews.apache.org/r/36690/diff/


Testing
-------


Thanks,

Rajat Khandelwal


Re: Review Request 36690: LENS-686: Repetitive add partition with same specs should fail after first time.

Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36690/#review93111
-----------------------------------------------------------

Ship it!


Ship It!

- Amareshwari Sriramadasu


On July 27, 2015, 9:42 a.m., Rajat Khandelwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36690/
> -----------------------------------------------------------
> 
> (Updated July 27, 2015, 9:42 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-686
>     https://issues.apache.org/jira/browse/LENS-686
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> 
> Diffs
> -----
> 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 0ebc707dcbec895dae3af60feab1eaf0ab657048 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/Storage.java 873aa490e37c0306dec57cda31880ffa5a332045 
>   lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java d7a033e8b9719f870bc4a2b1eeb6a9858e48b8d1 
>   lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java cb7a5305aecb6956db0941911d329d00e103ec2f 
>   lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 2d0eba23750542f1dd916d3c62af656c4dc2767c 
>   lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java d6ef04d064c040a9131d5b2efbbce90f467f6841 
>   lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 22dfd553d47177d246efa772df34119f653cabc0 
> 
> Diff: https://reviews.apache.org/r/36690/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.865s]
> [INFO] Lens .............................................. SUCCESS [2.788s]
> [INFO] Lens API .......................................... SUCCESS [24.519s]
> [INFO] Lens API for server and extensions ................ SUCCESS [18.190s]
> [INFO] Lens Cube ......................................... SUCCESS [4:20.045s]
> [INFO] Lens DB storage ................................... SUCCESS [21.307s]
> [INFO] Lens Query Library ................................ SUCCESS [15.100s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:59.284s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [37.341s]
> [INFO] Lens Server ....................................... SUCCESS [5:30.477s]
> [INFO] Lens client ....................................... SUCCESS [37.122s]
> [INFO] Lens CLI .......................................... SUCCESS [2:33.439s]
> [INFO] Lens Examples ..................................... SUCCESS [8.652s]
> [INFO] Lens Distribution ................................. SUCCESS [8.560s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:21.089s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.839s]
> [INFO] Lens Regression ................................... SUCCESS [10.585s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 19:53.044s
> [INFO] Finished at: Mon Jul 27 09:40:40 UTC 2015
> [INFO] Final Memory: 194M/1853M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>


Re: Review Request 36690: LENS-686: Repetitive add partition with same specs should fail after first time.

Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36690/
-----------------------------------------------------------

(Updated July 27, 2015, 3:12 p.m.)


Review request for lens.


Bugs: LENS-686
    https://issues.apache.org/jira/browse/LENS-686


Repository: lens


Description
-------


Diffs (updated)
-----

  lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 0ebc707dcbec895dae3af60feab1eaf0ab657048 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/Storage.java 873aa490e37c0306dec57cda31880ffa5a332045 
  lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java d7a033e8b9719f870bc4a2b1eeb6a9858e48b8d1 
  lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java cb7a5305aecb6956db0941911d329d00e103ec2f 
  lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 2d0eba23750542f1dd916d3c62af656c4dc2767c 
  lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java d6ef04d064c040a9131d5b2efbbce90f467f6841 
  lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 22dfd553d47177d246efa772df34119f653cabc0 

Diff: https://reviews.apache.org/r/36690/diff/


Testing (updated)
-------

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules ............................. SUCCESS [1.865s]
[INFO] Lens .............................................. SUCCESS [2.788s]
[INFO] Lens API .......................................... SUCCESS [24.519s]
[INFO] Lens API for server and extensions ................ SUCCESS [18.190s]
[INFO] Lens Cube ......................................... SUCCESS [4:20.045s]
[INFO] Lens DB storage ................................... SUCCESS [21.307s]
[INFO] Lens Query Library ................................ SUCCESS [15.100s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:59.284s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [37.341s]
[INFO] Lens Server ....................................... SUCCESS [5:30.477s]
[INFO] Lens client ....................................... SUCCESS [37.122s]
[INFO] Lens CLI .......................................... SUCCESS [2:33.439s]
[INFO] Lens Examples ..................................... SUCCESS [8.652s]
[INFO] Lens Distribution ................................. SUCCESS [8.560s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:21.089s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [1.839s]
[INFO] Lens Regression ................................... SUCCESS [10.585s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 19:53.044s
[INFO] Finished at: Mon Jul 27 09:40:40 UTC 2015
[INFO] Final Memory: 194M/1853M
[INFO] ------------------------------------------------------------------------


Thanks,

Rajat Khandelwal


Re: Review Request 36690: LENS-686: Repetitive add partition with same specs should fail after first time.

Posted by Rajat Khandelwal <ra...@gmail.com>.

> On July 27, 2015, 10:41 a.m., Amareshwari Sriramadasu wrote:
> > lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java, line 357
> > <https://reviews.apache.org/r/36690/diff/5/?file=1020910#file1020910line357>
> >
> >     Can you update doc wrt what is returned? Applies to all changed methods.
> >     
> >     Also, should this return all partitions added or returning the number of partitions added is enough?

Returning number of partitions now. Added doc.


- Rajat


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36690/#review93073
-----------------------------------------------------------


On July 24, 2015, 5:41 p.m., Rajat Khandelwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36690/
> -----------------------------------------------------------
> 
> (Updated July 24, 2015, 5:41 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-686
>     https://issues.apache.org/jira/browse/LENS-686
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> 
> Diffs
> -----
> 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 0ebc707dcbec895dae3af60feab1eaf0ab657048 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/Storage.java 873aa490e37c0306dec57cda31880ffa5a332045 
>   lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java bd31f8243f4871f1d2d6fe76997287f9be82b6ab 
>   lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 646de8c1b53fb7cbd85895a4ad672e68311931f0 
>   lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 2d0eba23750542f1dd916d3c62af656c4dc2767c 
>   lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java d6ef04d064c040a9131d5b2efbbce90f467f6841 
>   lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 22dfd553d47177d246efa772df34119f653cabc0 
> 
> Diff: https://reviews.apache.org/r/36690/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.969s]
> [INFO] Lens .............................................. SUCCESS [3.037s]
> [INFO] Lens API .......................................... SUCCESS [23.808s]
> [INFO] Lens API for server and extensions ................ SUCCESS [19.100s]
> [INFO] Lens Cube ......................................... SUCCESS [6:37.899s]
> [INFO] Lens DB storage ................................... SUCCESS [19.622s]
> [INFO] Lens Query Library ................................ SUCCESS [15.168s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:49.229s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [34.989s]
> [INFO] Lens Server ....................................... SUCCESS [5:22.255s]
> [INFO] Lens client ....................................... SUCCESS [35.232s]
> [INFO] Lens CLI .......................................... SUCCESS [2:47.529s]
> [INFO] Lens Examples ..................................... SUCCESS [10.355s]
> [INFO] Lens Distribution ................................. SUCCESS [10.164s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:28.550s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.826s]
> [INFO] Lens Regression ................................... SUCCESS [11.717s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 22:13.285s
> [INFO] Finished at: Fri Jul 24 09:08:03 UTC 2015
> [INFO] Final Memory: 169M/928M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>


Re: Review Request 36690: LENS-686: Repetitive add partition with same specs should fail after first time.

Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36690/#review93073
-----------------------------------------------------------



lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java (line 357)
<https://reviews.apache.org/r/36690/#comment147333>

    Can you update doc wrt what is returned? Applies to all changed methods.
    
    Also, should this return all partitions added or returning the number of partitions added is enough?


- Amareshwari Sriramadasu


On July 24, 2015, 12:11 p.m., Rajat Khandelwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36690/
> -----------------------------------------------------------
> 
> (Updated July 24, 2015, 12:11 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-686
>     https://issues.apache.org/jira/browse/LENS-686
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> 
> Diffs
> -----
> 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 0ebc707dcbec895dae3af60feab1eaf0ab657048 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/Storage.java 873aa490e37c0306dec57cda31880ffa5a332045 
>   lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java bd31f8243f4871f1d2d6fe76997287f9be82b6ab 
>   lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 646de8c1b53fb7cbd85895a4ad672e68311931f0 
>   lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 2d0eba23750542f1dd916d3c62af656c4dc2767c 
>   lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java d6ef04d064c040a9131d5b2efbbce90f467f6841 
>   lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 22dfd553d47177d246efa772df34119f653cabc0 
> 
> Diff: https://reviews.apache.org/r/36690/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.969s]
> [INFO] Lens .............................................. SUCCESS [3.037s]
> [INFO] Lens API .......................................... SUCCESS [23.808s]
> [INFO] Lens API for server and extensions ................ SUCCESS [19.100s]
> [INFO] Lens Cube ......................................... SUCCESS [6:37.899s]
> [INFO] Lens DB storage ................................... SUCCESS [19.622s]
> [INFO] Lens Query Library ................................ SUCCESS [15.168s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:49.229s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [34.989s]
> [INFO] Lens Server ....................................... SUCCESS [5:22.255s]
> [INFO] Lens client ....................................... SUCCESS [35.232s]
> [INFO] Lens CLI .......................................... SUCCESS [2:47.529s]
> [INFO] Lens Examples ..................................... SUCCESS [10.355s]
> [INFO] Lens Distribution ................................. SUCCESS [10.164s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:28.550s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.826s]
> [INFO] Lens Regression ................................... SUCCESS [11.717s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 22:13.285s
> [INFO] Finished at: Fri Jul 24 09:08:03 UTC 2015
> [INFO] Final Memory: 169M/928M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>


Re: Review Request 36690: LENS-686: Repetitive add partition with same specs should fail after first time.

Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36690/
-----------------------------------------------------------

(Updated July 24, 2015, 5:41 p.m.)


Review request for lens.


Bugs: LENS-686
    https://issues.apache.org/jira/browse/LENS-686


Repository: lens


Description
-------


Diffs (updated)
-----

  lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 0ebc707dcbec895dae3af60feab1eaf0ab657048 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/Storage.java 873aa490e37c0306dec57cda31880ffa5a332045 
  lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java bd31f8243f4871f1d2d6fe76997287f9be82b6ab 
  lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 646de8c1b53fb7cbd85895a4ad672e68311931f0 
  lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 2d0eba23750542f1dd916d3c62af656c4dc2767c 
  lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java d6ef04d064c040a9131d5b2efbbce90f467f6841 
  lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 22dfd553d47177d246efa772df34119f653cabc0 

Diff: https://reviews.apache.org/r/36690/diff/


Testing
-------

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules ............................. SUCCESS [1.969s]
[INFO] Lens .............................................. SUCCESS [3.037s]
[INFO] Lens API .......................................... SUCCESS [23.808s]
[INFO] Lens API for server and extensions ................ SUCCESS [19.100s]
[INFO] Lens Cube ......................................... SUCCESS [6:37.899s]
[INFO] Lens DB storage ................................... SUCCESS [19.622s]
[INFO] Lens Query Library ................................ SUCCESS [15.168s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:49.229s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [34.989s]
[INFO] Lens Server ....................................... SUCCESS [5:22.255s]
[INFO] Lens client ....................................... SUCCESS [35.232s]
[INFO] Lens CLI .......................................... SUCCESS [2:47.529s]
[INFO] Lens Examples ..................................... SUCCESS [10.355s]
[INFO] Lens Distribution ................................. SUCCESS [10.164s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:28.550s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [1.826s]
[INFO] Lens Regression ................................... SUCCESS [11.717s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 22:13.285s
[INFO] Finished at: Fri Jul 24 09:08:03 UTC 2015
[INFO] Final Memory: 169M/928M
[INFO] ------------------------------------------------------------------------


Thanks,

Rajat Khandelwal


Re: Review Request 36690: LENS-686: Repetitive add partition with same specs should fail after first time.

Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36690/
-----------------------------------------------------------

(Updated July 24, 2015, 2:39 p.m.)


Review request for lens.


Bugs: LENS-686
    https://issues.apache.org/jira/browse/LENS-686


Repository: lens


Description
-------


Diffs (updated)
-----

  lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java 31666a09fdc9cde1629d0f1365ee1c635b5fa64e 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 0ebc707dcbec895dae3af60feab1eaf0ab657048 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/Storage.java 873aa490e37c0306dec57cda31880ffa5a332045 
  lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java bd31f8243f4871f1d2d6fe76997287f9be82b6ab 
  lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 646de8c1b53fb7cbd85895a4ad672e68311931f0 
  lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 2d0eba23750542f1dd916d3c62af656c4dc2767c 
  lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java d6ef04d064c040a9131d5b2efbbce90f467f6841 
  lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 22dfd553d47177d246efa772df34119f653cabc0 

Diff: https://reviews.apache.org/r/36690/diff/


Testing (updated)
-------

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules ............................. SUCCESS [1.969s]
[INFO] Lens .............................................. SUCCESS [3.037s]
[INFO] Lens API .......................................... SUCCESS [23.808s]
[INFO] Lens API for server and extensions ................ SUCCESS [19.100s]
[INFO] Lens Cube ......................................... SUCCESS [6:37.899s]
[INFO] Lens DB storage ................................... SUCCESS [19.622s]
[INFO] Lens Query Library ................................ SUCCESS [15.168s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:49.229s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [34.989s]
[INFO] Lens Server ....................................... SUCCESS [5:22.255s]
[INFO] Lens client ....................................... SUCCESS [35.232s]
[INFO] Lens CLI .......................................... SUCCESS [2:47.529s]
[INFO] Lens Examples ..................................... SUCCESS [10.355s]
[INFO] Lens Distribution ................................. SUCCESS [10.164s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:28.550s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [1.826s]
[INFO] Lens Regression ................................... SUCCESS [11.717s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 22:13.285s
[INFO] Finished at: Fri Jul 24 09:08:03 UTC 2015
[INFO] Final Memory: 169M/928M
[INFO] ------------------------------------------------------------------------


Thanks,

Rajat Khandelwal


Re: Review Request 36690: LENS-686: Repetitive add partition with same specs should fail after first time.

Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36690/
-----------------------------------------------------------

(Updated July 24, 2015, 1:54 p.m.)


Review request for lens.


Bugs: LENS-686
    https://issues.apache.org/jira/browse/LENS-686


Repository: lens


Description
-------


Diffs (updated)
-----

  lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 0ebc707dcbec895dae3af60feab1eaf0ab657048 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/Storage.java 873aa490e37c0306dec57cda31880ffa5a332045 
  lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java bd31f8243f4871f1d2d6fe76997287f9be82b6ab 
  lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 646de8c1b53fb7cbd85895a4ad672e68311931f0 
  lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 2d0eba23750542f1dd916d3c62af656c4dc2767c 
  lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java d6ef04d064c040a9131d5b2efbbce90f467f6841 
  lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 22dfd553d47177d246efa772df34119f653cabc0 

Diff: https://reviews.apache.org/r/36690/diff/


Testing
-------

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.066s]
[INFO] Lens .............................................. SUCCESS [3.138s]
[INFO] Lens API .......................................... SUCCESS [23.084s]
[INFO] Lens API for server and extensions ................ SUCCESS [18.173s]
[INFO] Lens Cube ......................................... SUCCESS [4:14.761s]
[INFO] Lens DB storage ................................... SUCCESS [20.385s]
[INFO] Lens Query Library ................................ SUCCESS [14.878s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:49.119s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [34.983s]
[INFO] Lens Server ....................................... SUCCESS [5:31.951s]
[INFO] Lens client ....................................... SUCCESS [35.743s]
[INFO] Lens CLI .......................................... SUCCESS [2:38.596s]
[INFO] Lens Examples ..................................... SUCCESS [8.297s]
[INFO] Lens Distribution ................................. SUCCESS [8.050s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:20.738s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [1.747s]
[INFO] Lens Regression ................................... SUCCESS [10.109s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 19:36.667s
[INFO] Finished at: Wed Jul 22 13:39:39 UTC 2015
[INFO] Final Memory: 175M/1316M
[INFO] ------------------------------------------------------------------------


Thanks,

Rajat Khandelwal


Re: Review Request 36690: LENS-686: Repetitive add partition with same specs should fail after first time.

Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36690/
-----------------------------------------------------------

(Updated July 22, 2015, 7:11 p.m.)


Review request for lens.


Bugs: LENS-686
    https://issues.apache.org/jira/browse/LENS-686


Repository: lens


Description
-------


Diffs (updated)
-----

  lens-api/src/main/java/org/apache/lens/api/APIResult.java d0483731e930eb456935041c6b73be3665b199bb 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java c8abca098f31c5a5c1ad6d2b69807a359637bd40 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/Storage.java 873aa490e37c0306dec57cda31880ffa5a332045 
  lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java bd31f8243f4871f1d2d6fe76997287f9be82b6ab 
  lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 646de8c1b53fb7cbd85895a4ad672e68311931f0 
  lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 2d0eba23750542f1dd916d3c62af656c4dc2767c 
  lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java cb9516b2d8ac72a85eba045c3e664e1080e89b48 
  lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 4eb52b9773a65c28d98055ea1114581be641c28c 

Diff: https://reviews.apache.org/r/36690/diff/


Testing (updated)
-------

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.066s]
[INFO] Lens .............................................. SUCCESS [3.138s]
[INFO] Lens API .......................................... SUCCESS [23.084s]
[INFO] Lens API for server and extensions ................ SUCCESS [18.173s]
[INFO] Lens Cube ......................................... SUCCESS [4:14.761s]
[INFO] Lens DB storage ................................... SUCCESS [20.385s]
[INFO] Lens Query Library ................................ SUCCESS [14.878s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:49.119s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [34.983s]
[INFO] Lens Server ....................................... SUCCESS [5:31.951s]
[INFO] Lens client ....................................... SUCCESS [35.743s]
[INFO] Lens CLI .......................................... SUCCESS [2:38.596s]
[INFO] Lens Examples ..................................... SUCCESS [8.297s]
[INFO] Lens Distribution ................................. SUCCESS [8.050s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:20.738s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [1.747s]
[INFO] Lens Regression ................................... SUCCESS [10.109s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 19:36.667s
[INFO] Finished at: Wed Jul 22 13:39:39 UTC 2015
[INFO] Final Memory: 175M/1316M
[INFO] ------------------------------------------------------------------------


Thanks,

Rajat Khandelwal