[jira] [Commented] (PROTON-1936) Support cross compiling to Windows from Linux

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PROTON-1936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17081713#comment-17081713 ] 

ASF GitHub Bot commented on PROTON-1936:
----------------------------------------

jiridanek commented on pull request #156: PROTON-1936: lower case include and updated ifdefs
URL: https://github.com/apache/qpid-proton/pull/156#discussion_r407172209
 
 

 ##########
 File path: c/src/platform/platform.h
 ##########
 @@ -81,7 +81,7 @@ int pni_vsnprintf(char *buf, size_t count, const char *fmt, va_list ap);
 
 #endif
 
-#if defined _MSC_VER || defined _OPENVMS
+#if defined _MSC_VER || defined(_WIN32) || defined _OPENVMS
 
 Review comment:
   I am surprised this is needed. I always believed mingw is a version of GCC, and therefore there wouldn't be a version of mingw that does not define the va_copy macro.
   
   It would be nice to switch to Visual Studio 2015+, and stop supporting 2013. Then there would be va_copy always defined even on MSVC.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Support cross compiling to Windows from Linux
> ---------------------------------------------
>
>                 Key: PROTON-1936
>                 URL: https://issues.apache.org/jira/browse/PROTON-1936
>             Project: Qpid Proton
>          Issue Type: Improvement
>          Components: proton-c
>    Affects Versions: proton-c-0.25.0
>            Reporter: Marcel Meulemans
>            Priority: Minor
>
> I am cross compiling proton for Windows via docker (multiarch/crossbuild) and running into a few minor issues that make it not work out of the box (mainly include file casing). Pull request will follow, more details there ... it would be nice if this made it upstream.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org