[jira] [Commented] (HBASE-19793) Minor improvements on Master/RS startup

["Duo Zhang (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-19793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16325555#comment-16325555 ] 

Duo Zhang commented on HBASE-19793:
-----------------------------------

Remove the instanceof check in the constructor of HRegionServer.
Make ZKWatcher, MasterAddressTracker and ClusterStatusTracker  final.
Remove the dependency of hadoop StringUtils, use commons lang3 instead.
Move setupClusterConnection after initializeZooKeeper since it will also load cluster id so we'd better make sure that cluster id has already been there.
Do not read cluster id again in initializeZooKeeper since for a HMaster we will load it earlier when we become active master.

> Minor improvements on Master/RS startup
> ---------------------------------------
>
>                 Key: HBASE-19793
>                 URL: https://issues.apache.org/jira/browse/HBASE-19793
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Duo Zhang
>            Assignee: Duo Zhang
>             Fix For: 2.0.0-beta-1
>
>         Attachments: HBASE-19793.patch
>
>
> Both ZooKeeper and hadoop FileSystem can do fencing, that means, if two processes try to create one file, only one of them can succeed. So I think we can move the initialization of ClusterId to the very beginning instead of only allow active master to do it.
> This may helps us solve the complicated dependency issue.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)