You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@climate.apache.org by jo...@apache.org on 2013/08/12 18:40:43 UTC

svn commit: r1513191 - in /incubator/climate/branches/RefactorInput/ocw: evaluation.py metrics.py

Author: joyce
Date: Mon Aug 12 16:40:43 2013
New Revision: 1513191

URL: http://svn.apache.org/r1513191
Log:
CLIMATE-137 - Fix casing of Metric.isUnary to match style guide

Modified:
    incubator/climate/branches/RefactorInput/ocw/evaluation.py
    incubator/climate/branches/RefactorInput/ocw/metrics.py

Modified: incubator/climate/branches/RefactorInput/ocw/evaluation.py
URL: http://svn.apache.org/viewvc/incubator/climate/branches/RefactorInput/ocw/evaluation.py?rev=1513191&r1=1513190&r2=1513191&view=diff
==============================================================================
--- incubator/climate/branches/RefactorInput/ocw/evaluation.py (original)
+++ incubator/climate/branches/RefactorInput/ocw/evaluation.py Mon Aug 12 16:40:43 2013
@@ -151,7 +151,7 @@ class Evaluation:
             logging.error(error)
             raise TypeError(error)
 
-        if metric.isUnary:
+        if metric.is_unary:
             self.unary_metrics.append(metric)
         else:
             self.metrics.append(metric)

Modified: incubator/climate/branches/RefactorInput/ocw/metrics.py
URL: http://svn.apache.org/viewvc/incubator/climate/branches/RefactorInput/ocw/metrics.py?rev=1513191&r1=1513190&r2=1513191&view=diff
==============================================================================
--- incubator/climate/branches/RefactorInput/ocw/metrics.py (original)
+++ incubator/climate/branches/RefactorInput/ocw/metrics.py Mon Aug 12 16:40:43 2013
@@ -34,7 +34,7 @@ class Metric():
                 By default a metric is expected to take two datasets.
         :type unary: Bool
         '''
-        self.isUnary = unary
+        self.is_unary = unary
 
     @abstractmethod
     def run(self, datasets):
@@ -60,7 +60,7 @@ class Bias(Metric):
         .. note::
            Overrides Metric.__init__()
         '''
-        self.isUnary = False
+        self.is_unary = False
 
     def run(self, datasets):
         '''Calculate the bias between a reference and target dataset.
@@ -88,7 +88,7 @@ class TemporalStdDev(Metric):
         .. note::
            Overrides Metric.__init__()
         '''
-        self.isUnary = True
+        self.is_unary = True
 
     def run(self, datasets):
         '''Calculate the temporal std. dev. for a datasets.