[GitHub] [ozone] rakeshadr commented on pull request #2108: HDDS-5061. Improve block commit

[GitBox <gi...@apache.org>]

rakeshadr commented on pull request #2108:
URL: https://github.com/apache/ozone/pull/2108#issuecomment-823479264


   > +1, thanks the fix @rakeshadr (one minor typo in `UnKnown`)
   > 
   > I tested it with a custom freon test which tried to create a new key with a blockid which is not allocated earlier:
   > 
   > ```
   > bash-4.2$ kinit -kt /etc/security/keytabs/scm.keytab scm/scm
   > bash-4.2$ ozone sh volume create /vol1 
   > bash-4.2$ ozone sh bucket create /vol1/bucket1^C
   > bash-4.2$ ozone sh volume create /vol1 
   > bash-4.2$ ozone sh bucket create /vol1/bucket1
   > bash-4.2$ ozone sh bucket create /vol1/bucket2
   > bash-4.2$ ozone sh bucket setacl -a user:testuser/scm@EXAMPLE.COM:a /vol1/bucket2
   > ACLs set successfully.
   > bash-4.2$ ozone sh volume setacl -a user:testuser/scm@EXAMPLE.COM:a /vol1
   > ACLs set successfully.
   > bash-4.2$ ozone sh key put /vol1/bucket1/key1 README.md 
   > bash-4.2$ ozone sh key info /vol1/bucket1/key1 | jq -r '.ozoneKeyLocations[0] | .localID'
   > 107544261427200000
   > ```
   > 
   > Now using the blockId which is allocated for key1 I tried to create a new key:
   > 
   > ```
   > bash-4.2$ kdestroy
   > bash-4.2$ kinit -kt /ect/security/keytabs/testuser.keytab testuser/scm
   > bash-4.2$ kinit -kt /etc/security/keytabs/testuser.keytab testuser/scm
   > bash-4.2$ ozone sh --verbose btpc --block-id 107544261427200000 --om om
   > 
   > 106097636080746497
   > 
   > key cretead /vol1/bucket2/key663262114
   > bash-4.2$ ozone sh --verbose btpc --block-id 107544261427200000 --om om
   > 
   > 106097641685188610
   > 
   > key cretead /vol1/bucket2/key1174965481
   > ```
   > 
   > The keys are created but it clearly visible that the key location is updated to the original one:
   > 
   > ```
   > bash-4.2$ ozone sh key cat /vol1/bucket2/key1174965481
   > ```
   > 
   > It's an empty fie, the content of the original block (`README.md`) is not visible.
   > 
   > (source of the the freon test is at https://github.com/elek/ozone/tree/block-token-test)
   
   Thanks @elek for the test result. I have committed the typo suggestion.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org