[GitHub] [airflow] potiuk commented on a diff in pull request #23662: Implement CronTriggerTimetable

[GitBox <gi...@apache.org>]

potiuk commented on code in PR #23662:
URL: https://github.com/apache/airflow/pull/23662#discussion_r933116528


##########
docs/apache-airflow/concepts/timetable.rst:
##########
@@ -55,15 +55,17 @@ Built In Timetables
 Airflow comes with several common timetables built in to cover the most common use cases. Additional timetables
 may be available in plugins.
 
+.. _CronTriggerTimetable
+
 CronTriggerTimetable
 ^^^^^^^^^^^^^^^^^^^^^^^^^
 
-Another timetable which accepts a cron expression. It behaves more compliant with standard cron than ``CronDataIntervalTimetable``.
+A cron compliant timetable.

Review Comment:
   Yeah. Cron-compliant is not good name. 
   
   I think "working as cron" as an idea is pretty sound as people have good mental model for how cron works in general. And we know traditionally Airflow is definitely not "working like cron" despite having "cron-like schedule definition".
   
   Something `cron-like triggering behaviour` (but that's also not a very cool name) is more something I'd use and @uranusjr is right that we should describe it in a bit more detail, especially that there are many cron variants bahving slightly difference. 
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org