You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/12/09 13:15:24 UTC

[GitHub] [kafka] mumrah commented on a change in pull request #9715: Upstream ApisUtils from kip-500

mumrah commented on a change in pull request #9715:
URL: https://github.com/apache/kafka/pull/9715#discussion_r539295919



##########
File path: core/src/main/scala/kafka/server/KafkaApis.scala
##########
@@ -98,6 +97,7 @@ import scala.annotation.nowarn
  * Logic to handle the various Kafka requests
  */
 class KafkaApis(val requestChannel: RequestChannel,
+                val apisUtils: ApisUtils,

Review comment:
       Thanks, @chia7712, I like this suggestion. I'll see if I can figure this out (I wasn't too happy with the utility class needing to be instantiated either)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org