You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tuscany.apache.org by an...@apache.org on 2007/07/31 12:05:24 UTC

svn commit: r561293 - /incubator/tuscany/java/sca/modules/databinding-sdo/src/main/java/org/apache/tuscany/sca/databinding/sdo/ImportSDOPostProcessor.java

Author: antelder
Date: Tue Jul 31 03:05:21 2007
New Revision: 561293

URL: http://svn.apache.org/viewvc?view=rev&rev=561293
Log:
Fix NPE when clazz not resolved

Modified:
    incubator/tuscany/java/sca/modules/databinding-sdo/src/main/java/org/apache/tuscany/sca/databinding/sdo/ImportSDOPostProcessor.java

Modified: incubator/tuscany/java/sca/modules/databinding-sdo/src/main/java/org/apache/tuscany/sca/databinding/sdo/ImportSDOPostProcessor.java
URL: http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/databinding-sdo/src/main/java/org/apache/tuscany/sca/databinding/sdo/ImportSDOPostProcessor.java?view=diff&rev=561293&r1=561292&r2=561293
==============================================================================
--- incubator/tuscany/java/sca/modules/databinding-sdo/src/main/java/org/apache/tuscany/sca/databinding/sdo/ImportSDOPostProcessor.java (original)
+++ incubator/tuscany/java/sca/modules/databinding-sdo/src/main/java/org/apache/tuscany/sca/databinding/sdo/ImportSDOPostProcessor.java Tue Jul 31 03:05:21 2007
@@ -56,7 +56,7 @@
                 String factoryName = getFactoryClassName(artifactURI);
                 ClassReference clazz = new ClassReference(factoryName);
                 clazz = contribution.getModelResolver().resolveModel(ClassReference.class, clazz);
-                if (clazz.getClass() != null) {
+                if (clazz.getJavaClass() != null) {
                     try {
                         //check if it's a SDO factory by introspecting INSTANCE field
                         if (isSDOFactory(clazz.getJavaClass())) {



---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-commits-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-commits-help@ws.apache.org


Re: svn commit: r561293 - /incubator/tuscany/java/sca/modules/databinding-sdo/src/main/java/org/apache/tuscany/sca/databinding/sdo/ImportSDOPostProcessor.java

Posted by ant elder <an...@apache.org>.
On 7/31/07, antelder@apache.org <an...@apache.org> wrote:
>
> Author: antelder
> Date: Tue Jul 31 03:05:21 2007
> New Revision: 561293
>
> URL: http://svn.apache.org/viewvc?view=rev&rev=561293
> Log:
> Fix NPE when clazz not resolved
>
> Modified:
>
>     incubator/tuscany/java/sca/modules/databinding-sdo/src/main/java/org/apache/tuscany/sca/databinding/sdo/ImportSDOPostProcessor.java
>
> Modified:
> incubator/tuscany/java/sca/modules/databinding-sdo/src/main/java/org/apache/tuscany/sca/databinding/sdo/ImportSDOPostProcessor.java
> URL:
> http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/databinding-sdo/src/main/java/org/apache/tuscany/sca/databinding/sdo/ImportSDOPostProcessor.java?view=diff&rev=561293&r1=561292&r2=561293
>
> ==============================================================================
> ---
> incubator/tuscany/java/sca/modules/databinding-sdo/src/main/java/org/apache/tuscany/sca/databinding/sdo/ImportSDOPostProcessor.java
> (original)
> +++
> incubator/tuscany/java/sca/modules/databinding-sdo/src/main/java/org/apache/tuscany/sca/databinding/sdo/ImportSDOPostProcessor.java
> Tue Jul 31 03:05:21 2007
> @@ -56,7 +56,7 @@
>                  String factoryName = getFactoryClassName(artifactURI);
>                  ClassReference clazz = new ClassReference(factoryName);
>                  clazz = contribution.getModelResolver().resolveModel(
> ClassReference.class, clazz);
> -                if (clazz.getClass() != null) {
> +                if (clazz.getJavaClass() != null) {
>                      try {
>                          //check if it's a SDO factory by introspecting
> INSTANCE field
>                          if (isSDOFactory(clazz.getJavaClass())) {



The  actual cause of this problem seems to be a different bug where the
class name is prefixed with "WEB-INF\classes\" when running in a webapp so
the classes never get resolved. Although that doesn't seem to stop things
from still working ok so I'm not sure what this is code is really trying to
do? Can see this by debugging with a break point in the above code and
running the new helloworld sdo webapp sample.

   ...ant