You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by kk...@apache.org on 2012/11/12 21:21:17 UTC
svn commit: r1408439 - in /tomcat/tc7.0.x/trunk: ./
test/org/apache/catalina/valves/TestAccessLogValve.java
test/org/apache/juli/TestDateFormatCache.java
Author: kkolinko
Date: Mon Nov 12 20:21:17 2012
New Revision: 1408439
URL: http://svn.apache.org/viewvc?rev=1408439&view=rev
Log:
Merged revision 1408438 from tomcat/trunk:
For https://issues.apache.org/bugzilla/show_bug.cgi?id=54044
Add test for org.apache.juli.DateFormatCache.
It is port of the test of AccessLogValve.DateFormatCache.
I am using reflection to get interesting fields, so no need to change field visibilities.
Added:
tomcat/tc7.0.x/trunk/test/org/apache/juli/TestDateFormatCache.java
- copied unchanged from r1408438, tomcat/trunk/test/org/apache/juli/TestDateFormatCache.java
Modified:
tomcat/tc7.0.x/trunk/ (props changed)
tomcat/tc7.0.x/trunk/test/org/apache/catalina/valves/TestAccessLogValve.java
Propchange: tomcat/tc7.0.x/trunk/
------------------------------------------------------------------------------
Merged /tomcat/trunk:r1408438
Modified: tomcat/tc7.0.x/trunk/test/org/apache/catalina/valves/TestAccessLogValve.java
URL: http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/test/org/apache/catalina/valves/TestAccessLogValve.java?rev=1408439&r1=1408438&r2=1408439&view=diff
==============================================================================
--- tomcat/tc7.0.x/trunk/test/org/apache/catalina/valves/TestAccessLogValve.java (original)
+++ tomcat/tc7.0.x/trunk/test/org/apache/catalina/valves/TestAccessLogValve.java Mon Nov 12 20:21:17 2012
@@ -26,6 +26,8 @@ import org.junit.Test;
public class TestAccessLogValve {
+ // Note that there is a similar test:
+ // org.apache.juli.TestDateFormatCache.testBug54044()
@Test
public void testBug54044() throws Exception {
@@ -77,7 +79,7 @@ public class TestAccessLogValve {
expected[0] = generateExpected(sdf, 0);
Assert.assertArrayEquals(expected, dfc.cLFCache.cache);
- // Jump ahead far enough that the entire cache will need tp be cleared
+ // Jump ahead far enough that the entire cache will need to be cleared
dfc.getFormat(42 * 1000);
for (int i = 0; i < cacheSize; i++) {
expected[i] = null;
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org