[GitHub] feng-tao commented on issue #4590: [AIRFLOW-3727] Change references of is_localized to is_aware

[GitBox <gi...@apache.org>]

feng-tao commented on issue #4590: [AIRFLOW-3727] Change references of is_localized to is_aware
URL: https://github.com/apache/airflow/pull/4590#issuecomment-457770324
 
 
   I don't think this is correct. I can't find is_aware in timezone file. And the ticket clearly says:
   ```https://airflow.apache.org/timezone.html] says:
   {quote}You can use timezone.is_aware() and timezone.is_naive() to determine whether datetimes are aware or naive.
   {quote}
   But the right method name is {{timezone.is_localized}}, not {{timezone.is_aware}}.
    (Or, should we add {{timezone.is_aware}} as an alias of {{timezone.is_localized}}, to be congruent with {{timezone.make_aware}} and {{timezone.make_naive}}?)
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services