You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/10/28 10:05:10 UTC
[GitHub] [maven-surefire] SimonBaars opened a new pull request, #573: [SUREFIRE-2122] Document workaround for maven-shade-plugin in IntelliJ
SimonBaars opened a new pull request, #573:
URL: https://github.com/apache/maven-surefire/pull/573
Following this checklist to help us incorporate your contribution quickly and easily:
- [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SUREFIRE-2122) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line and body.
- [x] Format the pull request title like `[SUREFIRE-XXX] - Fixes bug in ApproximateQuantiles`,
where you replace `SUREFIRE-XXX` with the appropriate JIRA issue. Best practice
is to use the JIRA issue title in the pull request title and in the first line of the
commit message.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean install` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
- [ ] You have run the integration tests successfully (`mvn -Prun-its clean install`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] SimonBaars commented on a diff in pull request #573: [SUREFIRE-2122] Document workaround for maven-shade-plugin in IntelliJ
Posted by GitBox <gi...@apache.org>.
SimonBaars commented on code in PR #573:
URL: https://github.com/apache/maven-surefire/pull/573#discussion_r1007962774
##########
README.md:
##########
@@ -81,7 +81,10 @@ Build the Surefire project using **Maven 3.2.5+** and **JDK 1.8+**.
* Check module `surefire-grouper` has source folder `target/generated-sources/javacc`.
If not, add it manually in the module's project properties
-* Setup for development in [IntelliJ IDEA](https://www.jetbrains.com/idea/) should work out of the box.
+* Setup for development in [IntelliJ IDEA](https://www.jetbrains.com/idea/) works largely out of the box. There may be unresolved symbols because [IntelliJ does not support the maven-shade-plugin](https://youtrack.jetbrains.com/issue/IDEA-126596). As a workaround:
+
+ * In IntelliJ, right click `surefire-shared-utils/pom.xml` and choose "Maven" -> "Ignore Projects". Don't remove the module if prompted.
+ * Right click the parent `pom.xml` and choose "Maven" -> "Reload project"
Review Comment:
Hey, thanks for the feedback! I checked, and indeed your instructions also work. W.r.t. this:
> * Setup for development in [IntelliJ IDEA](https://www.jetbrains.com/idea/) should work out of the box.
I propose changing it to reflect these setup steps. I'll update my PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] mthmulders commented on pull request #573: [SUREFIRE-2122] Document workaround for maven-shade-plugin in IntelliJ
Posted by GitBox <gi...@apache.org>.
mthmulders commented on PR #573:
URL: https://github.com/apache/maven-surefire/pull/573#issuecomment-1294993269
Thanks a lot for your contribution, @SimonBaars!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] slawekjaranowski commented on a diff in pull request #573: [SUREFIRE-2122] Document workaround for maven-shade-plugin in IntelliJ
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on code in PR #573:
URL: https://github.com/apache/maven-surefire/pull/573#discussion_r1007931668
##########
README.md:
##########
@@ -81,7 +81,10 @@ Build the Surefire project using **Maven 3.2.5+** and **JDK 1.8+**.
* Check module `surefire-grouper` has source folder `target/generated-sources/javacc`.
If not, add it manually in the module's project properties
-* Setup for development in [IntelliJ IDEA](https://www.jetbrains.com/idea/) should work out of the box.
+* Setup for development in [IntelliJ IDEA](https://www.jetbrains.com/idea/) works largely out of the box. There may be unresolved symbols because [IntelliJ does not support the maven-shade-plugin](https://youtrack.jetbrains.com/issue/IDEA-126596). As a workaround:
+
+ * In IntelliJ, right click `surefire-shared-utils/pom.xml` and choose "Maven" -> "Ignore Projects". Don't remove the module if prompted.
+ * Right click the parent `pom.xml` and choose "Maven" -> "Reload project"
Review Comment:
Ignoring module is not needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] slawekjaranowski commented on a diff in pull request #573: [SUREFIRE-2122] Document workaround for maven-shade-plugin in IntelliJ
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on code in PR #573:
URL: https://github.com/apache/maven-surefire/pull/573#discussion_r1007907761
##########
README.md:
##########
@@ -81,7 +81,10 @@ Build the Surefire project using **Maven 3.2.5+** and **JDK 1.8+**.
* Check module `surefire-grouper` has source folder `target/generated-sources/javacc`.
If not, add it manually in the module's project properties
-* Setup for development in [IntelliJ IDEA](https://www.jetbrains.com/idea/) should work out of the box.
+* Setup for development in [IntelliJ IDEA](https://www.jetbrains.com/idea/) works largely out of the box. There may be unresolved symbols because [IntelliJ does not support the maven-shade-plugin](https://youtrack.jetbrains.com/issue/IDEA-126596). As a workaround:
+
+ * In IntelliJ, right click `surefire-shared-utils/pom.xml` and choose "Maven" -> "Ignore Projects". Don't remove the module if prompted.
+ * Right click the parent `pom.xml` and choose "Maven" -> "Reload project"
Review Comment:
Steps for Eclipse are also needed for InteliJ
- install ... shared
- compile ... grouper
After it you need select `ide-development` in Maven project and refresh
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] SimonBaars commented on pull request #573: [SUREFIRE-2122] Document workaround for maven-shade-plugin in IntelliJ
Posted by GitBox <gi...@apache.org>.
SimonBaars commented on PR #573:
URL: https://github.com/apache/maven-surefire/pull/573#issuecomment-1295054611
@slawekjaranowski The PR still shows in "waiting" status. The documentation is not clear whether the [hacktoberfest-accepted](https://github.com/apache/maven-surefire/labels/hacktoberfest-accepted) label trumps the `not closed` rule. Let's hope it's fine 🙏🏼 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] slawekjaranowski commented on pull request #573: [SUREFIRE-2122] Document workaround for maven-shade-plugin in IntelliJ
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on PR #573:
URL: https://github.com/apache/maven-surefire/pull/573#issuecomment-1295013130
@mthmulders - I afraid that PR with closed status - will be not accepted by hacktoberfest 😄
@SimonBaars can you check it?
From https://hacktoberfest.com/participation/
> Your PR/MR must not be a draft to be considered accepted.
> If your PR/MR is being accepted for Hacktoberfest via an overall approving review it must also not be closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] slawekjaranowski commented on a diff in pull request #573: [SUREFIRE-2122] Document workaround for maven-shade-plugin in IntelliJ
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on code in PR #573:
URL: https://github.com/apache/maven-surefire/pull/573#discussion_r1007993661
##########
README.md:
##########
@@ -81,7 +81,10 @@ Build the Surefire project using **Maven 3.2.5+** and **JDK 1.8+**.
* Check module `surefire-grouper` has source folder `target/generated-sources/javacc`.
If not, add it manually in the module's project properties
-* Setup for development in [IntelliJ IDEA](https://www.jetbrains.com/idea/) should work out of the box.
+* Setup for development in [IntelliJ IDEA](https://www.jetbrains.com/idea/) works largely out of the box. There may be unresolved symbols because [IntelliJ does not support the maven-shade-plugin](https://youtrack.jetbrains.com/issue/IDEA-126596). As a workaround:
+
+ * In IntelliJ, right click `surefire-shared-utils/pom.xml` and choose "Maven" -> "Ignore Projects". Don't remove the module if prompted.
+ * Right click the parent `pom.xml` and choose "Maven" -> "Reload project"
Review Comment:
Thanks.
Please also check instruction by second hands 😄
You can before test clean .m2/repository to be sure that works from scratch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] mthmulders closed pull request #573: [SUREFIRE-2122] Document workaround for maven-shade-plugin in IntelliJ
Posted by GitBox <gi...@apache.org>.
mthmulders closed pull request #573: [SUREFIRE-2122] Document workaround for maven-shade-plugin in IntelliJ
URL: https://github.com/apache/maven-surefire/pull/573
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] SimonBaars commented on a diff in pull request #573: [SUREFIRE-2122] Document workaround for maven-shade-plugin in IntelliJ
Posted by GitBox <gi...@apache.org>.
SimonBaars commented on code in PR #573:
URL: https://github.com/apache/maven-surefire/pull/573#discussion_r1007969531
##########
README.md:
##########
@@ -81,7 +81,10 @@ Build the Surefire project using **Maven 3.2.5+** and **JDK 1.8+**.
* Check module `surefire-grouper` has source folder `target/generated-sources/javacc`.
If not, add it manually in the module's project properties
-* Setup for development in [IntelliJ IDEA](https://www.jetbrains.com/idea/) should work out of the box.
+* Setup for development in [IntelliJ IDEA](https://www.jetbrains.com/idea/) works largely out of the box. There may be unresolved symbols because [IntelliJ does not support the maven-shade-plugin](https://youtrack.jetbrains.com/issue/IDEA-126596). As a workaround:
+
+ * In IntelliJ, right click `surefire-shared-utils/pom.xml` and choose "Maven" -> "Ignore Projects". Don't remove the module if prompted.
+ * Right click the parent `pom.xml` and choose "Maven" -> "Reload project"
Review Comment:
@slawekjaranowski I updated the PR to reflect these instructions, please have a look :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org