You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2017/05/11 19:25:47 UTC
[kudu-CR] [flags] fixed typo in group flag validation logic
Alexey Serbin has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6860
Change subject: [flags] fixed typo in group flag validation logic
......................................................................
[flags] fixed typo in group flag validation logic
This is a follow-up for e7334c2e6607ac0fa778499eda2df3f4cfcd3fe3.
This patch fixes the typo in the original commit and adds test coverage
for the case of multiple group validators in the validation pipeline.
Change-Id: Idfdc25d491941674fd7b86d8ffa33ff2e046703b
---
M src/kudu/util/flag_validators-test.cc
M src/kudu/util/flags.cc
2 files changed, 78 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/60/6860/1
--
To view, visit http://gerrit.cloudera.org:8080/6860
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idfdc25d491941674fd7b86d8ffa33ff2e046703b
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [flags] fixed typo in group flag validation logic
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: [flags] fixed typo in group flag validation logic
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/6860
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idfdc25d491941674fd7b86d8ffa33ff2e046703b
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] [flags] fixed typo in group flag validation logic
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged.
Change subject: [flags] fixed typo in group flag validation logic
......................................................................
[flags] fixed typo in group flag validation logic
This is a follow-up for e7334c2e6607ac0fa778499eda2df3f4cfcd3fe3.
This patch fixes the typo in the original commit and adds test coverage
for the case of multiple group validators in the validation pipeline.
Change-Id: Idfdc25d491941674fd7b86d8ffa33ff2e046703b
Reviewed-on: http://gerrit.cloudera.org:8080/6860
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
---
M src/kudu/util/flag_validators-test.cc
M src/kudu/util/flags.cc
2 files changed, 78 insertions(+), 5 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/6860
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idfdc25d491941674fd7b86d8ffa33ff2e046703b
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins