You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jmeter-dev@jakarta.apache.org by se...@apache.org on 2004/06/07 00:13:56 UTC
cvs commit: jakarta-jmeter/src/core/org/apache/jmeter/config/gui ArgumentsPanel.java SimpleConfigGui.java
sebb 2004/06/06 15:13:56
Modified: src/core/org/apache/jmeter/config/gui ArgumentsPanel.java
SimpleConfigGui.java
Log:
Reduce field visibility; make strings truly final by removing from array
Revision Changes Path
1.26 +7 -10 jakarta-jmeter/src/core/org/apache/jmeter/config/gui/ArgumentsPanel.java
Index: ArgumentsPanel.java
===================================================================
RCS file: /home/cvs/jakarta-jmeter/src/core/org/apache/jmeter/config/gui/ArgumentsPanel.java,v
retrieving revision 1.25
retrieving revision 1.26
diff -u -r1.25 -r1.26
--- ArgumentsPanel.java 28 May 2004 21:09:11 -0000 1.25
+++ ArgumentsPanel.java 6 Jun 2004 22:13:56 -0000 1.26
@@ -84,12 +84,9 @@
/** Command for removing a row from the table. */
private static final String DELETE = "delete";
- public static final String[] COLUMN_NAMES =
- {
- JMeterUtils.getResString("name"),
- JMeterUtils.getResString("value"),
- JMeterUtils.getResString("metadata")
- };
+ private static final String COLUMN_NAMES_0 = JMeterUtils.getResString("name");
+ private static final String COLUMN_NAMES_1 = JMeterUtils.getResString("value");
+ //NOTUSED private static final String COLUMN_NAMES_2 = JMeterUtils.getResString("metadata");
/**
* Create a new ArgumentsPanel as a standalone component.
@@ -371,8 +368,8 @@
tableModel =
new ObjectTableModel(
new String[] {
- COLUMN_NAMES[0],
- COLUMN_NAMES[1] },
+ COLUMN_NAMES_0,
+ COLUMN_NAMES_1 },
new Functor[] {new Functor("getName"),
new Functor("getValue")
},
1.9 +8 -10 jakarta-jmeter/src/core/org/apache/jmeter/config/gui/SimpleConfigGui.java
Index: SimpleConfigGui.java
===================================================================
RCS file: /home/cvs/jakarta-jmeter/src/core/org/apache/jmeter/config/gui/SimpleConfigGui.java,v
retrieving revision 1.8
retrieving revision 1.9
diff -u -r1.8 -r1.9
--- SimpleConfigGui.java 5 Mar 2004 01:33:48 -0000 1.8
+++ SimpleConfigGui.java 6 Jun 2004 22:13:56 -0000 1.9
@@ -77,11 +77,9 @@
private boolean displayName = true;
/** The names of the columns in the table. */
- public static final String[] COLUMN_NAMES = {
- JMeterUtils.getResString("name"),
- JMeterUtils.getResString("value"),
- JMeterUtils.getResString("metadata")
- };
+ private static final String COLUMN_NAMES_0 = JMeterUtils.getResString("name");
+ private static final String COLUMN_NAMES_1 = JMeterUtils.getResString("value");
+ //NOTUSED private static final String COLUMN_NAMES_2 = JMeterUtils.getResString("metadata");
/**
* Create a new standalone SimpleConfigGui.
@@ -158,8 +156,8 @@
{
el.setProperty(
new StringProperty(
- (String) model.getColumnValue(COLUMN_NAMES[0]),
- (String) model.getColumnValue(COLUMN_NAMES[1])));
+ (String) model.getColumnValue(COLUMN_NAMES_0),
+ (String) model.getColumnValue(COLUMN_NAMES_1)));
}
super.configureTestElement(el);
}
@@ -212,7 +210,7 @@
{
tableModel =
new PowerTableModel(
- new String[] { COLUMN_NAMES[0], COLUMN_NAMES[1] },
+ new String[] { COLUMN_NAMES_0, COLUMN_NAMES_1 },
new Class[] { String.class, String.class });
table = new JTable(tableModel);
---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org