[jira] Commented: (DROIDS-92) Externalize creation of Save handler from SaveCrawlingDroid so that the handler can be configured first

["Thorsten Scherler (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DROIDS-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12973541#action_12973541 ] 

Thorsten Scherler commented on DROIDS-92:
-----------------------------------------

thorsten@mcKenny:~/src/apache/droids$ patch -p0 < DROIDS-92_v1.patch 
(Stripping trailing CRs from patch.)
patching file droids-core/src/test/java/org/apache/droids/impl/SaveCrawlingDroid.java
(Stripping trailing CRs from patch.)
patching file droids-core/src/test/java/org/apache/droids/DroidsFactory.java
Hunk #1 FAILED at 27.
Hunk #2 FAILED at 104.
2 out of 2 hunks FAILED -- saving rejects to file droids-core/src/test/java/org/apache/droids/DroidsFactory.java.rej


I cannot apply the patch on revision 1051442.

Further the SaveCrawlingDroid is ATM more a test case rather then a configurable component. IMO it makes sense to create a new maven module "samples" and move this and other crawlers from the test folder to this module. 


> Externalize creation of Save handler from SaveCrawlingDroid so that the handler can be configured first
> -------------------------------------------------------------------------------------------------------
>
>                 Key: DROIDS-92
>                 URL: https://issues.apache.org/jira/browse/DROIDS-92
>             Project: Droids
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 0.0.1
>            Reporter: Eugen Paraschiv
>            Priority: Minor
>             Fix For: 0.0.1
>
>         Attachments: DROIDS-92_v1.patch
>
>
> The Save handler is instantiated withing SaveCrawlingDroid and thus, the client has no control over it - no way of setting properties on it and no way to inject another one. 
> As a solution, the Save handler should be injected into the SaveCrawlingDroid. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.