[GitHub] [pinot] zhtaoxiang commented on a diff in pull request #10290: Add a tight retry block to update ZK during endSegmentReplacement

["zhtaoxiang (via GitHub)" <gi...@apache.org>]

zhtaoxiang commented on code in PR #10290:
URL: https://github.com/apache/pinot/pull/10290#discussion_r1108166124


##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java:
##########
@@ -3433,31 +3433,16 @@ public String startReplaceSegments(String tableNameWithType, List<String> segmen
   public void endReplaceSegments(String tableNameWithType, String segmentLineageEntryId) {
     try {
       DEFAULT_RETRY_POLICY.attempt(() -> {

Review Comment:
   Do we still need this outer retry logic if the logic is retried when trying to update znode?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org