You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/05/01 18:22:49 UTC
[GitHub] [spark] rdblue commented on issue #24416: [SPARK-27521][SQL] move
data source v2 to catalyst module
rdblue commented on issue #24416: [SPARK-27521][SQL] move data source v2 to catalyst module
URL: https://github.com/apache/spark/pull/24416#issuecomment-488367154
Looks like this moved the v2 package and the vectorized package. Is it necessary to move `ArrowColumnVector`? That seems like an implementation class and not an interface.
Also, does it make sense to move `DataSourceRegister`? That seems like a part of v1 that we've just reused. Maybe we should add a method to TableProvider instead of moving the trait?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org