You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@forrest.apache.org by "David Crossley (JIRA)" <ji...@apache.org> on 2005/08/07 09:27:35 UTC

[jira] Created: (FOR-605) CSS enhancements needed for MOTD area inside Table of Contents

CSS enhancements needed for MOTD area inside Table of Contents
--------------------------------------------------------------

         Key: FOR-605
         URL: http://issues.apache.org/jira/browse/FOR-605
     Project: Forrest
        Type: Bug
    Versions: 0.8-dev    
    Reporter: David Crossley
     Fix For: 0.8-dev
 Attachments: 605-screenshot.png

The Message of the Day (MOTD) facility inserts a panel at  the top right of the Table of Contents (ToC). However this panel interferes with the flow of text in the ToC, forcing items to be line-wrapped to a narrow width. The MOTD is not properly implemented with CSS, probably needs its own definition.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Re: [jira] Commented: (FOR-605) CSS enhancements needed for MOTD area inside Table of Contents

Posted by "Gav...." <br...@brightontown.com.au>.
----- Original Message ----- 
From: "David Crossley" <cr...@apache.org>

| >Gav Wrote:
| > How about changing this example code to something that IS provided by
| > default,
| > maybe 'plugins_0_70' and 'plugins_0_80' or something ?
|
| Please send a patch to main/fresh-site/src/documentation/skinconf.xml

patch uploaded, seemed appropraite to create sub-task of FOR-605.
|
| > Also , I notice that the motd-option pattern does filenames as well as
| > recursive
| > handling of directory names.
|
| Well, it is just any pattern.

True, I haven't checked but can there be a != pattern too (anywhere but ...)

|
| > e.g. - 'index' will put a motd on every index.html page on the site.
| > e.g - 'samples' will put a motd on every page of every sub-directory of
| > /samples/
|
| Careful, that would also match a file at the top level
| called mysamplesfoo.html

So it does.
|
| > Is this documented anywhere?
|
| The only documentation is what you see in the skinconf.xml

Ok, I started a very brief doc of MOTD in the faq as a new entry, this
can be expanded on if need be with more code examples maybe.

Hopefully this will help answer the question such as that raised on the user 
list
earlier today.

Gav... 



-- 
No virus found in this outgoing message.
Checked by AVG Anti-Virus.
Version: 7.0.344 / Virus Database: 267.10.16/83 - Release Date: 26/08/2005


Re: [jira] Commented: (FOR-605) CSS enhancements needed for MOTD area inside Table of Contents

Posted by David Crossley <cr...@apache.org>.
Gav.... wrote:
>
> Anyway, I 'thought' it would just work as-is and never noticed until close 
> inspection
> that the example code given will not work unless altered to a valid provided 
> URI.
> The example code gives 'docs_0_70' and 'docs_0_80' as example pattern 
> strings.
> With the default seed site that is created howver, this uri's do not exist 
> and was
> where I was originally getting confused and wondering why it would not work.
> 
> How about changing this example code to something that IS provided by 
> default,
> maybe 'plugins_0_70' and 'plugins_0_80' or something ?

Okay, keep the defaults as simple as possible.
Perhaps "samples" as you suggest below.

Please send a patch to main/fresh-site/src/documentation/skinconf.xml

> Also , I notice that the motd-option pattern does filenames as well as 
> recursive
> handling of directory names.

Well, it is just any pattern.

> e.g. - 'index' will put a motd on every index.html page on the site.
> e.g - 'samples' will put a motd on every page of every sub-directory of 
> /samples/

Careful, that would also match a file at the top level
called mysamplesfoo.html

> Is this documented anywhere?

The only documentation is what you see in the skinconf.xml

> | Anything that you can do to improve that, or even do
> | somthing completely different, would be good.
> 
> Ok, no problem, will do. Below the menu where it is now as one location is 
> great
> as it is. The other one on the main motd-area I will shift to the right a 
> bit and remove
> some padding etc in surrounding areas and see if that improves things before 
> I
> think about putting it anywhere else, the current location makes sense.

Okay, one step at a time.

-David

Re: [jira] Commented: (FOR-605) CSS enhancements needed for MOTD area inside Table of Contents

Posted by "Gav...." <br...@brightontown.com.au>.
----- Original Message ----- 
From: "David Crossley"

|
| The MOTD is explained in a 'seed' site skinconf.xml
| You need to define a pattern for it to match the uri.

Yep, got it thanks. This is where I was enabling it by uncommenting the MOTD 
section.
(At least when I tried to do this at the beginning of August it was 
commented out by
default, a new seed site a just did seemed to have it enabled by default 
this time.)

Anyway, I 'thought' it would just work as-is and never noticed until close 
inspection
that the example code given will not work unless altered to a valid provided 
URI.
The example code gives 'docs_0_70' and 'docs_0_80' as example pattern 
strings.
With the default seed site that is created howver, this uri's do not exist 
and was
where I was originally getting confused and wondering why it would not work.

How about changing this example code to something that IS provided by 
default,
maybe 'plugins_0_70' and 'plugins_0_80' or something ?

Also , I notice that the motd-option pattern does filenames as well as 
recursive
handling of directory names.

e.g. - 'index' will put a motd on every index.html page on the site.
e.g - 'samples' will put a motd on every page of every sub-directory of 
/samples/

Is this documented anywhere?

|
| Looking at /forrest/site-author/skinconf.xml the MOTD
| is already enabled, so i am not sure what your question is.

Ignore that, I got my skinconf's mixed up.

|
| > Looking at http://forrest.apache.org/pluginDocs/plugins_0_80/index.html 
where it displays correctly it is a width problem somewhere.
| >
| > Due to long URL description links on pages that have motd also, this 
would probably be unresolvable with motd in its current position, CSS or 
not.
| >
| > Moving motd above or below might be a better idea, but I'll have a play 
and let you see what I come up with.
|
| The main idea was to be able to display a
| short message in a prominent place.
|
| There is often whitespace on the left of the
| table of contents. However, my implementation
| was not very good.
|
| Anything that you can do to improve that, or even do
| somthing completely different, would be good.

Ok, no problem, will do. Below the menu where it is now as one location is 
great
as it is. The other one on the main motd-area I will shift to the right a 
bit and remove
some padding etc in surrounding areas and see if that improves things before 
I
think about putting it anywhere else, the current location makes sense.

Gav... 



-- 
No virus found in this outgoing message.
Checked by AVG Anti-Virus.
Version: 7.0.344 / Virus Database: 267.10.15/80 - Release Date: 23/08/2005


Re: [jira] Commented: (FOR-605) CSS enhancements needed for MOTD area inside Table of Contents

Posted by David Crossley <cr...@apache.org>.
Gavin (JIRA) wrote:
>     [ http://issues.apache.org/jira/browse/FOR-605?page=comments#action_12317899 ] 
> 
> Gavin commented on FOR-605:
> ---------------------------
> 
> I removed the comment tags from the motd in /forrest/site-author/skinconf.xml but it has made no difference.
> Can you tell me how to enable motd so I can check it out.

Please ask questions on the mailing list rather than
the issue tracker. Keep the latter as concise as possible.

The MOTD is explained in a 'seed' site skinconf.xml
You need to define a pattern for it to match the uri.

Looking at /forrest/site-author/skinconf.xml the MOTD
is already enabled, so i am not sure what your question is.

> Looking at http://forrest.apache.org/pluginDocs/plugins_0_80/index.html where it displays correctly it is a width problem somewhere.
> 
> Due to long URL description links on pages that have motd also, this would probably be unresolvable with motd in its current position, CSS or not. 
> 
> Moving motd above or below might be a better idea, but I'll have a play and let you see what I come up with.

The main idea was to be able to display a
short message in a prominent place.

There is often whitespace on the left of the
table of contents. However, my implementation
was not very good.

Anything that you can do to improve that, or even do
somthing completely different, would be good.

-David

Re: [jira] Commented: (FOR-605) CSS enhancements needed for MOTD area inside Table of Contents

Posted by David Crossley <cr...@apache.org>.
David Crossley wrote:
> Gav.... wrote:
> 
> > Also , in regard to the differing screenshot that I get from your version, 
> > do you still see it as before or
> > as I now see it (see new screenshot of same page)
> 
> As before.
> 
> Hmmm, i thought that your issue report was saying
> that you had done some tweaks and now it looks
> better for you.
> 
> There is something strange happening then.
> Perhaps browser related. ... testing: yes,
> that was using Mac FireFox, different on Safari.
> I will try some other tests later today.
> 
> > , just wondering if 
> > something has been done somewhere or possibly you are set up
> > for 800x600 resolution whereas I am on 1024x768.?
> 
> Nope, this report was on an even bigger resolution
> screen than yours.

Aha, i finally understand what you were meaning by
"resolution". I do use browser windows that are
not full-screen. They are about 800 wide.

-David

> > I take it for now I just need to be looking at pelt basic.css and 
> > screen.css.
> 
> Start there, but there are other things involved, e.g.
> some CSS is generated by forrest, so you may need to
> look into the xslt and sitemaps. Concentrate on 'pelt'
> and 'common'.
> 
> You would learn a lot about forrest mechanisms by
> following the processing.
> 
> Personally i would not worry too much about this
> MOTD layout bug. It would be better to concentrate
> on the overall CSS cleanup for both the existing
> "skins" functionality (but only pelt) and the new
> "views" functionality.
> 
> -David

Re: [jira] Commented: (FOR-605) CSS enhancements needed for MOTD area inside Table of Contents

Posted by David Crossley <cr...@apache.org>.
Gav.... wrote:
> 
> | The project would be very pleased if you would refine all the CSS and get 
> | some consistency. Just do whatever you see fit, do it in stages. Don't think 
> | that we actually "designed" the layout for large screens. In fact we want 
> | ideal rendering for all clients.
> 
> Ok, will do. Is anyone else working on CSS I need to know about to liaise 
> with or not?

If there are then they can speak up if need be.
Best that you just get on with it. As i said, do it
in small stages. In that way everyone's SVN stays
up-to-date and your changes are merged with theirs.
If it is left too long, then that is more difficult.

> Also , in regard to the differing screenshot that I get from your version, 
> do you still see it as before or
> as I now see it (see new screenshot of same page)

As before.

Hmmm, i thought that your issue report was saying
that you had done some tweaks and now it looks
better for you.

There is something strange happening then.
Perhaps browser related. ... testing: yes,
that was using Mac FireFox, different on Safari.
I will try some other tests later today.

> , just wondering if 
> something has been done somewhere or possibly you are set up
> for 800x600 resolution whereas I am on 1024x768.?

Nope, this report was on an even bigger resolution
screen than yours.

> I take it for now I just need to be looking at pelt basic.css and 
> screen.css.

Start there, but there are other things involved, e.g.
some CSS is generated by forrest, so you may need to
look into the xslt and sitemaps. Concentrate on 'pelt'
and 'common'.

You would learn a lot about forrest mechanisms by
following the processing.

Personally i would not worry too much about this
MOTD layout bug. It would be better to concentrate
on the overall CSS cleanup for both the existing
"skins" functionality (but only pelt) and the new
"views" functionality.

-David

Re: [jira] Commented: (FOR-605) CSS enhancements needed for MOTD area inside Table of Contents

Posted by "Gav...." <br...@brightontown.com.au>.
----- Original Message ----- 
From: "David Crossley (JIRA)" <ji...@apache.org>
To: <de...@forrest.apache.org>
Sent: Thursday, August 25, 2005 9:27 AM
Subject: [jira] Commented: (FOR-605) CSS enhancements needed for MOTD area 
inside Table of Contents


|    [ 
http://issues.apache.org/jira/browse/FOR-605?page=comments#action_12319954 ]
|
| David Crossley commented on FOR-605:
| ------------------------------------
|
| That is an effect of just adding new features, without consolidating what 
we already have. At the last release, we urgently needed a way to show a 
prominent message, so  i just added that without regard.
|
| The project would be very pleased if you would refine all the CSS and get 
some consistency. Just do whatever you see fit, do it in stages. Don't think 
that we actually "designed" the layout for large screens. In fact we want 
ideal rendering for all clients.
|

Ok, will do. Is anyone else working on CSS I need to know about to liaise 
with or not?

Also , in regard to the differing screenshot that I get from your version, 
do you still see it as before or
as I now see it (see new screenshot of same page) , just wondering if 
something has been done somewhere or possibly you are set up
for 800x600 resolution whereas I am on 1024x768.?

I take it for now I just need to be looking at pelt basic.css and 
screen.css.

Gav...




-- 
No virus found in this outgoing message.
Checked by AVG Anti-Virus.
Version: 7.0.344 / Virus Database: 267.10.15/80 - Release Date: 23/08/2005


[jira] Commented: (FOR-605) CSS enhancements needed for MOTD area inside Table of Contents

Posted by "David Crossley (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/FOR-605?page=comments#action_12319954 ] 

David Crossley commented on FOR-605:
------------------------------------

That is an effect of just adding new features, without consolidating what we already have. At the last release, we urgently needed a way to show a prominent message, so  i just added that without regard.

The project would be very pleased if you would refine all the CSS and get some consistency. Just do whatever you see fit, do it in stages. Don't think that we actually "designed" the layout for large screens. In fact we want ideal rendering for all clients.


> CSS enhancements needed for MOTD area inside Table of Contents
> --------------------------------------------------------------
>
>          Key: FOR-605
>          URL: http://issues.apache.org/jira/browse/FOR-605
>      Project: Forrest
>         Type: Bug
>   Components: Skins (general issues)
>     Versions: 0.8-dev
>     Reporter: David Crossley
>      Fix For: 0.8-dev
>  Attachments: 605-screenshot.png, forrest_faq.png
>
> The Message of the Day (MOTD) facility inserts a panel at  the top right of the Table of Contents (ToC). However this panel interferes with the flow of text in the ToC, forcing items to be line-wrapped to a narrow width. The MOTD is not properly implemented with CSS, probably needs its own definition.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (FOR-605) CSS enhancements needed for MOTD area inside Table of Contents

Posted by "David Crossley (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FOR-605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David Crossley updated FOR-605:
-------------------------------

    Attachment: patch-FOR-605.txt

The attachment patch-FOR-605.txt adds structure as described at http://marc.info/?l=forrest-dev&m=118429841828956

Other bits of front-matter (e.g. header/notice) were previously commented-out of pelt skin. Not sure why - need to look at history.

> CSS enhancements needed for MOTD area inside Table of Contents
> --------------------------------------------------------------
>
>                 Key: FOR-605
>                 URL: https://issues.apache.org/jira/browse/FOR-605
>             Project: Forrest
>          Issue Type: Bug
>          Components: Skins (general issues)
>    Affects Versions: 0.8
>            Reporter: David Crossley
>            Assignee: Gavin
>         Attachments: 605-screenshot.png, forrest_faq.png, patch-FOR-605.txt
>
>
> The Message of the Day (MOTD) facility inserts a panel at  the top right of the Table of Contents (ToC). However this panel interferes with the flow of text in the ToC, forcing items to be line-wrapped to a narrow width. The MOTD is not properly implemented with CSS, probably needs its own definition.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (FOR-605) CSS enhancements needed for MOTD area inside Table of Contents

Posted by "Gavin (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FOR-605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gavin reassigned FOR-605:
-------------------------

    Assignee: Gavin

> CSS enhancements needed for MOTD area inside Table of Contents
> --------------------------------------------------------------
>
>                 Key: FOR-605
>                 URL: https://issues.apache.org/jira/browse/FOR-605
>             Project: Forrest
>          Issue Type: Bug
>          Components: Skins (general issues)
>    Affects Versions: 0.8
>            Reporter: David Crossley
>            Assignee: Gavin
>         Attachments: 605-screenshot.png, forrest_faq.png
>
>
> The Message of the Day (MOTD) facility inserts a panel at  the top right of the Table of Contents (ToC). However this panel interferes with the flow of text in the ToC, forcing items to be line-wrapped to a narrow width. The MOTD is not properly implemented with CSS, probably needs its own definition.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (FOR-605) CSS enhancements needed for MOTD area inside Table of Contents

Posted by "Gavin (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/FOR-605?page=comments#action_12320349 ] 

Gavin commented on FOR-605:
---------------------------

FOR 652 has been created for general CSS enhancements. The first enhancement of FOR 652 has been uploaded, if applied please see if the MOTD changes as part of it , are acceptable as a fix for this issue.

> CSS enhancements needed for MOTD area inside Table of Contents
> --------------------------------------------------------------
>
>          Key: FOR-605
>          URL: http://issues.apache.org/jira/browse/FOR-605
>      Project: Forrest
>         Type: Bug
>   Components: Skins (general issues)
>     Versions: 0.8-dev
>     Reporter: David Crossley
>      Fix For: 0.8-dev
>  Attachments: 605-screenshot.png, forrest_faq.png
>
> The Message of the Day (MOTD) facility inserts a panel at  the top right of the Table of Contents (ToC). However this panel interferes with the flow of text in the ToC, forcing items to be line-wrapped to a narrow width. The MOTD is not properly implemented with CSS, probably needs its own definition.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (FOR-605) CSS enhancements needed for MOTD area inside Table of Contents

Posted by "David Crossley (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/FOR-605?page=all ]

David Crossley updated FOR-605:
-------------------------------

    Attachment: 605-screenshot.png

> CSS enhancements needed for MOTD area inside Table of Contents
> --------------------------------------------------------------
>
>          Key: FOR-605
>          URL: http://issues.apache.org/jira/browse/FOR-605
>      Project: Forrest
>         Type: Bug
>     Versions: 0.8-dev
>     Reporter: David Crossley
>      Fix For: 0.8-dev
>  Attachments: 605-screenshot.png
>
> The Message of the Day (MOTD) facility inserts a panel at  the top right of the Table of Contents (ToC). However this panel interferes with the flow of text in the ToC, forcing items to be line-wrapped to a narrow width. The MOTD is not properly implemented with CSS, probably needs its own definition.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (FOR-605) CSS enhancements needed for MOTD area inside Table of Contents

Posted by "Gavin (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/FOR-605?page=comments#action_12317899 ] 

Gavin commented on FOR-605:
---------------------------

I removed the comment tags from the motd in /forrest/site-author/skinconf.xml but it has made no difference.
Can you tell me how to enable motd so I can check it out.

Looking at http://forrest.apache.org/pluginDocs/plugins_0_80/index.html where it displays correctly it is a width problem somewhere.

Due to long URL description links on pages that have motd also, this would probably be unresolvable with motd in its current position, CSS or not. 

Moving motd above or below might be a better idea, but I'll have a play and let you see what I come up with.

Gav...

> CSS enhancements needed for MOTD area inside Table of Contents
> --------------------------------------------------------------
>
>          Key: FOR-605
>          URL: http://issues.apache.org/jira/browse/FOR-605
>      Project: Forrest
>         Type: Bug
>     Versions: 0.8-dev
>     Reporter: David Crossley
>      Fix For: 0.8-dev
>  Attachments: 605-screenshot.png
>
> The Message of the Day (MOTD) facility inserts a panel at  the top right of the Table of Contents (ToC). However this panel interferes with the flow of text in the ToC, forcing items to be line-wrapped to a narrow width. The MOTD is not properly implemented with CSS, probably needs its own definition.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (FOR-605) CSS enhancements needed for MOTD area inside Table of Contents

Posted by "Gavin (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/FOR-605?page=comments#action_12320258 ] 

Gavin commented on FOR-605:
---------------------------

I am now working on the CSS and will patch and go as I progress, this MOTD issue will get sorted as a side effect of the revamp.

> CSS enhancements needed for MOTD area inside Table of Contents
> --------------------------------------------------------------
>
>          Key: FOR-605
>          URL: http://issues.apache.org/jira/browse/FOR-605
>      Project: Forrest
>         Type: Bug
>   Components: Skins (general issues)
>     Versions: 0.8-dev
>     Reporter: David Crossley
>      Fix For: 0.8-dev
>  Attachments: 605-screenshot.png, forrest_faq.png
>
> The Message of the Day (MOTD) facility inserts a panel at  the top right of the Table of Contents (ToC). However this panel interferes with the flow of text in the ToC, forcing items to be line-wrapped to a narrow width. The MOTD is not properly implemented with CSS, probably needs its own definition.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (FOR-605) CSS enhancements needed for MOTD area inside Table of Contents

Posted by "Gavin (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FOR-605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12512912 ] 

Gavin commented on FOR-605:
---------------------------

Ok, so this is applied now in /site-author/ and /fresh-site/ and can be seen in both the published docs and the forrest.zones for pelt skin.

MOTD I believe needs sorting out for dispatcher.

I tested in and got more or less identical results in the following :-

Windows XP and Vista : Firefox, Opera 9, IE 6, IE 7.
Linux  Ubuntu Feisty : Firefox, Epiphany.

Tested in Resolutions of 800x600 and above.

I will close this in a week if no other issues are found.

> CSS enhancements needed for MOTD area inside Table of Contents
> --------------------------------------------------------------
>
>                 Key: FOR-605
>                 URL: https://issues.apache.org/jira/browse/FOR-605
>             Project: Forrest
>          Issue Type: Bug
>          Components: Skins (general issues)
>    Affects Versions: 0.8
>            Reporter: David Crossley
>            Assignee: Gavin
>         Attachments: 605-screenshot.png, forrest_faq.png, patch-FOR-605.txt
>
>
> The Message of the Day (MOTD) facility inserts a panel at  the top right of the Table of Contents (ToC). However this panel interferes with the flow of text in the ToC, forcing items to be line-wrapped to a narrow width. The MOTD is not properly implemented with CSS, probably needs its own definition.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (FOR-605) CSS enhancements needed for MOTD area inside Table of Contents

Posted by "David Crossley (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/FOR-605?page=comments#action_12320269 ] 

David Crossley commented on FOR-605:
------------------------------------

Please create a new issue for general CSS enhancements, leaving this issue for the specific MOTD enhancements.

> CSS enhancements needed for MOTD area inside Table of Contents
> --------------------------------------------------------------
>
>          Key: FOR-605
>          URL: http://issues.apache.org/jira/browse/FOR-605
>      Project: Forrest
>         Type: Bug
>   Components: Skins (general issues)
>     Versions: 0.8-dev
>     Reporter: David Crossley
>      Fix For: 0.8-dev
>  Attachments: 605-screenshot.png, forrest_faq.png
>
> The Message of the Day (MOTD) facility inserts a panel at  the top right of the Table of Contents (ToC). However this panel interferes with the flow of text in the ToC, forcing items to be line-wrapped to a narrow width. The MOTD is not properly implemented with CSS, probably needs its own definition.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (FOR-605) CSS enhancements needed for MOTD area inside Table of Contents

Posted by "Ross Gardler (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/FOR-605?page=all ]

Ross Gardler updated FOR-605:
-----------------------------

    Fix Version:     (was: 0.8-dev)

> CSS enhancements needed for MOTD area inside Table of Contents
> --------------------------------------------------------------
>
>          Key: FOR-605
>          URL: http://issues.apache.org/jira/browse/FOR-605
>      Project: Forrest
>         Type: Bug
>   Components: Skins (general issues)
>     Versions: 0.8-dev
>     Reporter: David Crossley
>  Attachments: 605-screenshot.png, forrest_faq.png
>
> The Message of the Day (MOTD) facility inserts a panel at  the top right of the Table of Contents (ToC). However this panel interferes with the flow of text in the ToC, forcing items to be line-wrapped to a narrow width. The MOTD is not properly implemented with CSS, probably needs its own definition.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (FOR-605) CSS enhancements needed for MOTD area inside Table of Contents

Posted by "Gavin (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/FOR-605?page=all ]

Gavin updated FOR-605:
----------------------

    Attachment: forrest_faq.png

I am investigating this, and it seems there is doubled up use of margins and padding in adjacent areas of the stylesheet. For instance the width of a page within #content is #menu + #minitoc-area + #motd-area. All of these specify widths and margins and padding to differing degrees, and some overlap each other. I believe there is room here for much improvement. 

However, as this screenshot shows, it seems to be a lot better anyway than on Davids screenshot of the same page. We have to factor in resolution settings for different users and the fact you will always get word wrapping at 800x600 when the site is clearly more designed around 1024x762 users.

The stylesheets I would say need a good re-vamp and cleanup, there is a mix of using px,em,% when I think probably we should be using % a lot more and px a lot less.

> CSS enhancements needed for MOTD area inside Table of Contents
> --------------------------------------------------------------
>
>          Key: FOR-605
>          URL: http://issues.apache.org/jira/browse/FOR-605
>      Project: Forrest
>         Type: Bug
>   Components: Skins (general issues)
>     Versions: 0.8-dev
>     Reporter: David Crossley
>      Fix For: 0.8-dev
>  Attachments: 605-screenshot.png, forrest_faq.png
>
> The Message of the Day (MOTD) facility inserts a panel at  the top right of the Table of Contents (ToC). However this panel interferes with the flow of text in the ToC, forcing items to be line-wrapped to a narrow width. The MOTD is not properly implemented with CSS, probably needs its own definition.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Re: [jira] Commented: (FOR-605) CSS enhancements needed for MOTD area inside Table of Contents

Posted by "Gav..." <br...@brightontown.com.au>.
<quote who="David Crossley">
> David Crossley wrote:
>> Gav.... wrote:
>> >
>> > I am trying to re-organise header/abstract + MOTD + ToC into a
>> container
>> > div, but is a little difficult when some of the content/structure
>> comes from
>> > site-to-xhtml.xsl and some come from document-to-html.xsl and the 2nd
>> refers
>> > to the 1st !!
>>
>> I will try to help with this later next week.
>> Off now for a long weekend.
>
> I have a new structure now by adding a "div id=front-matter"
> and using a similar trick to the empty div for
> "skinconf-toc-page" in document-to-html.xsl.
>
> Not yet figured out the CSS. However, i ran out of time
> today so will try again late next week.

Good stuff, if you want you can attach or send what you got and I can work
on CSS this weekend.

Gav...

>
> -David
>


-- 
Gav...


Re: [jira] Commented: (FOR-605) CSS enhancements needed for MOTD area inside Table of Contents

Posted by David Crossley <cr...@apache.org>.
David Crossley wrote:
> Gav.... wrote:
> > 
> > I am trying to re-organise header/abstract + MOTD + ToC into a container
> > div, but is a little difficult when some of the content/structure comes from
> > site-to-xhtml.xsl and some come from document-to-html.xsl and the 2nd refers
> > to the 1st !!
> 
> I will try to help with this later next week.
> Off now for a long weekend.

I have a new structure now by adding a "div id=front-matter"
and using a similar trick to the empty div for
"skinconf-toc-page" in document-to-html.xsl.

Not yet figured out the CSS. However, i ran out of time
today so will try again late next week.

-David

Re: [jira] Commented: (FOR-605) CSS enhancements needed for MOTD area inside Table of Contents

Posted by David Crossley <cr...@apache.org>.
Gav.... wrote:
> 
> What would be the consequences of moving header/abstract into <body> ?
> 
> I am trying to re-organise header/abstract + MOTD + ToC into a container
> div, but is a little difficult when some of the content/structure comes from
> site-to-xhtml.xsl and some come from document-to-html.xsl and the 2nd refers
> to the 1st !!
>
> If I move header/abstract into the <body> then it all works fine and I have
> my master container div for these sections. CSS then makes it how we want.
> 
> I will have to rethink another strategy if I can not move the above though.
> 
> I will expand on the exact problem later, off to work.

I will try to help with this later next week.
Off now for a long weekend.

-David

Re: [jira] Commented: (FOR-605) CSS enhancements needed for MOTD area inside Table of Contents

Posted by "Gav..." <br...@brightontown.com.au>.
<quote who="David Crossley">
> Gav.... wrote:
>> From: David Crossley:
>> > Gav.... wrote:
>> > >
>> > > Ok, so 550036 has moved MOTD to the left and removed relative
>> > positioning.
>> > >
>> > > It looks much better than it did and does not overlap content.
>> > >
>> > > Where it was floated right, it caused all sorts of issues, not
>> easily
>> > > fixed due to the fact that MOTD and/or surrounding content divs and
>> > classes
>> > > could be optionally added/removed at any time. There is as far as I
>> can
>> > see
>> > > no good all round fix for this, taking browser sizes, browser
>> versions
>> > and
>> > > screen resolutions into account. The current fix works fine for all
>> > those
>> > > but may not 'look' as good as if it were prevalent on the right
>> side.
>> >
>> > It is a shame. The original right-hand position was also
>> > trying to utilise the whitespace at the right of the
>> > Table Of Contents (ToC). Option #1 has even more wasted space.
>>
>> Agree
>>
>> > > I do have one idea to improve the look and keep it where it is on
>> the
>> > > left, hopefully being an agreed final fix for this MOTD position.
>> > >
>> > > I would like to propose that we create a new MOTD class in the same
>> > > style as .note, .warning and .fixme. We'll give it a unique color
>> from
>> > > the rest but will be displayed in exactly the same way, from the
>> left
>> > going
>> > > as far across the screen as necessary, with a title section and
>> content
>> > > section the same as .note etc.
>> > >
>> > > We can call it .information with 'Information' being the default
>> label
>> > for
>> > > the top part which can be over-ridden with your own label, the MOTD
>> on
>> > the
>> > > current forrest index page would instead use this with a label of
>> > 'Latest
>> > > release 0.8', the content area then having '18 April 2007
>> Forrest-0.8
>> > > released: Features the Locationmap. (More)'
>> >
>> > There is no configuration for the "label" attribute.
>>
>> Sorry, mistake I meant :-
>>
>> <div class="note">
>> <div class="label">latest 0.8 release</div>
>> <div class="content">'18 April 2007 Forrest-0.8
>> released: Features the Locationmap. (More)
>> </div>
>> </div>
>>
>> but don't worry about it now ...
>
> No that is not what i meant. There is no
> configuration in skinconf.xml for "motd label".
> It is only a snippet of text, so it needs to be
> kept simple.
>
>> > Perhaps just use a concise box with slightly bigger
>> > border on all sides, using the existing colours.
>>
>> Ok, no problem.
>>
>> > > I'll do a mock up in a test-sample site and attach the graphic to
>> this
>> > issue
>> > > if you like but I'm sure you know what I mean.
>> > >
>> > > So we have choices :-
>> > >
>> > > 1. Keep it as I have changed it to currently - to the left and still
>> the
>> > > traditional MOTD.
>> >
>> > It wasn't a "traditional look". It was just a hack to fix
>> > the docs during the 0.7 release. No effort was spent on
>> > the look. I would prefer it to be more prominent CSS emphasis.
>> >
>> > > 2. Create a new version of MOTD in the style of .note etc -- still
>> > keeping
>> > > the same way that we apply the MOTD, just the style changes.
>> >
>> > I reckon that it would be too bulky and not stand
>> > out sufficiently.
>> >
>> > > 3. Revert and try something else, but it will be difficult to get it
>> > right
>> > > and keep it right for all scenarios. The above two will work in all
>> > > scenarios.
>> > >
>> > > 4. Something else.
>> > >
>> > > Thoughts ?
>> >
>> > Remember that these MOTD notes are intended to be
>> > very short. The content needs to also be able to
>> > fit into the bottom of the left-hand panel.
>> >
>> > We are already utilising the space to the right
>> > of the Title for Font Size and alternate formats,
>> > so cannot put it there.
>> >
>> > There are a number of pieces of "top matter".
>> > a) Title and its right-hand friends seem fine as-is.
>> > b) Optional header/abstract is shown above the ToC.
>> >
>> > Would it be possible to have a div for this second set?
>> > Then perhaps include the "motd" to the right-hand side.
>> > It should then collapse gracefully if those two
>> > pieces of content are missing. FLW.
>> >
>> > This is probably how i should have done it to
>> > start with, but was in a rush at the time.
>>
>> Ok, so enclose #MOTD and .abstract into a new div holding area.
>>
>> .abstract left and #motd floated right, if either one is missing
>> make sure the other still holds its place. If both are missing
>> the container div will collapse.
>>
>> Sounds like a plan.
>
> Actually i meant to include the Table of Contents too.
>
>  +-----------------------------------------------+
>  | +-----------------------------+-------------+ |
>  | |                             | Right Panel | |
>  | |  header/abstract            |             | |
>  | |                             |             | |
>  | +-----------------------------+             | |
>  | |                             |             | |
>  | |  Generated ToC              |             | |
>  | |                             |             | |
>  | |                             |             | |
>  | +-----------------------------+-------------+ |
>  +-----------------------------------------------+
>
> In the "Right Panel" would go the MOTD.
> Perhaps later other things could go there too.

Ok, I'll work on that design.
If the header/abstract and ToC are both missing I
should still try to keep MOTD to the right, even
though the other two left divs would be missing.


>
> This is easier with the Dispatcher of course.

Yes, once done on skins, I'll implement on pelt theme too.

Gav...

>
> -David
>


-- 
Gav...


RE: [jira] Commented: (FOR-605) CSS enhancements needed for MOTD area inside Table of Contents

Posted by "Gav...." <br...@brightontown.com.au>.

> -----Original Message-----
> From: David Crossley [mailto:crossley@apache.org]
> Sent: Tuesday, 26 June 2007 9:26 AM
> To: dev@forrest.apache.org
> Subject: Re: [jira] Commented: (FOR-605) CSS enhancements needed for MOTD
> area inside Table of Contents
> 
> Gav.... wrote:
> > From: David Crossley:
> > > Gav.... wrote:
> > > >
> > > > Ok, so 550036 has moved MOTD to the left and removed relative
> > > positioning.
> > > >
> > > > It looks much better than it did and does not overlap content.
> > > >
> > > > Where it was floated right, it caused all sorts of issues, not
> easily
> > > > fixed due to the fact that MOTD and/or surrounding content divs and
> > > classes
> > > > could be optionally added/removed at any time. There is as far as I
> can
> > > see
> > > > no good all round fix for this, taking browser sizes, browser
> versions
> > > and
> > > > screen resolutions into account. The current fix works fine for all
> > > those
> > > > but may not 'look' as good as if it were prevalent on the right
> side.
> > >
> > > It is a shame. The original right-hand position was also
> > > trying to utilise the whitespace at the right of the
> > > Table Of Contents (ToC). Option #1 has even more wasted space.
> >
> > Agree
> >
> > > > I do have one idea to improve the look and keep it where it is on
> the
> > > > left, hopefully being an agreed final fix for this MOTD position.
> > > >
> > > > I would like to propose that we create a new MOTD class in the same
> > > > style as .note, .warning and .fixme. We'll give it a unique color
> from
> > > > the rest but will be displayed in exactly the same way, from the
> left
> > > going
> > > > as far across the screen as necessary, with a title section and
> content
> > > > section the same as .note etc.
> > > >
> > > > We can call it .information with 'Information' being the default
> label
> > > for
> > > > the top part which can be over-ridden with your own label, the MOTD
> on
> > > the
> > > > current forrest index page would instead use this with a label of
> > > 'Latest
> > > > release 0.8', the content area then having '18 April 2007 Forrest-
> 0.8
> > > > released: Features the Locationmap. (More)'
> > >
> > > There is no configuration for the "label" attribute.
> >
> > Sorry, mistake I meant :-
> >
> > <div class="note">
> > <div class="label">latest 0.8 release</div>
> > <div class="content">'18 April 2007 Forrest-0.8
> > released: Features the Locationmap. (More)
> > </div>
> > </div>
> >
> > but don't worry about it now ...
> 
> No that is not what i meant. There is no
> configuration in skinconf.xml for "motd label".
> It is only a snippet of text, so it needs to be
> kept simple.
> 
> > > Perhaps just use a concise box with slightly bigger
> > > border on all sides, using the existing colours.
> >
> > Ok, no problem.
> >
> > > > I'll do a mock up in a test-sample site and attach the graphic to
> this
> > > issue
> > > > if you like but I'm sure you know what I mean.
> > > >
> > > > So we have choices :-
> > > >
> > > > 1. Keep it as I have changed it to currently - to the left and still
> the
> > > > traditional MOTD.
> > >
> > > It wasn't a "traditional look". It was just a hack to fix
> > > the docs during the 0.7 release. No effort was spent on
> > > the look. I would prefer it to be more prominent CSS emphasis.
> > >
> > > > 2. Create a new version of MOTD in the style of .note etc -- still
> > > keeping
> > > > the same way that we apply the MOTD, just the style changes.
> > >
> > > I reckon that it would be too bulky and not stand
> > > out sufficiently.
> > >
> > > > 3. Revert and try something else, but it will be difficult to get it
> > > right
> > > > and keep it right for all scenarios. The above two will work in all
> > > > scenarios.
> > > >
> > > > 4. Something else.
> > > >
> > > > Thoughts ?
> > >
> > > Remember that these MOTD notes are intended to be
> > > very short. The content needs to also be able to
> > > fit into the bottom of the left-hand panel.
> > >
> > > We are already utilising the space to the right
> > > of the Title for Font Size and alternate formats,
> > > so cannot put it there.
> > >
> > > There are a number of pieces of "top matter".
> > > a) Title and its right-hand friends seem fine as-is.
> > > b) Optional header/abstract is shown above the ToC.
> > >
> > > Would it be possible to have a div for this second set?
> > > Then perhaps include the "motd" to the right-hand side.
> > > It should then collapse gracefully if those two
> > > pieces of content are missing. FLW.
> > >
> > > This is probably how i should have done it to
> > > start with, but was in a rush at the time.
> >
> > Ok, so enclose #MOTD and .abstract into a new div holding area.
> >
> > .abstract left and #motd floated right, if either one is missing
> > make sure the other still holds its place. If both are missing
> > the container div will collapse.
> >
> > Sounds like a plan.
> 
> Actually i meant to include the Table of Contents too.
> 
>  +-----------------------------------------------+
>  | +-----------------------------+-------------+ |
>  | |                             | Right Panel | |
>  | |  header/abstract            |             | |
>  | |                             |             | |
>  | +-----------------------------+             | |
>  | |                             |             | |
>  | |  Generated ToC              |             | |
>  | |                             |             | |
>  | |                             |             | |
>  | +-----------------------------+-------------+ |
>  +-----------------------------------------------+
> 
> In the "Right Panel" would go the MOTD.
> Perhaps later other things could go there too.

What would be the consequences of moving header/abstract into <body> ?

I am trying to re-organise header/abstract + MOTD + ToC into a container
div, but is a little difficult when some of the content/structure comes from
site-to-xhtml.xsl and some come from document-to-html.xsl and the 2nd refers
to the 1st !!

If I move header/abstract into the <body> then it all works fine and I have
my master container div for these sections. CSS then makes it how we want.

I will have to rethink another strategy if I can not move the above though.

I will expand on the exact problem later, off to work.

Gav...

> 
> This is easier with the Dispatcher of course.
> 
> -David
> 
> 
> --
> No virus found in this incoming message.
> Checked by AVG Free Edition.
> Version: 7.5.472 / Virus Database: 269.9.8/869 - Release Date: 6/25/2007
> 5:32 PM


Re: [jira] Commented: (FOR-605) CSS enhancements needed for MOTD area inside Table of Contents

Posted by David Crossley <cr...@apache.org>.
Gav.... wrote:
> From: David Crossley:
> > Gav.... wrote:
> > >
> > > Ok, so 550036 has moved MOTD to the left and removed relative
> > positioning.
> > >
> > > It looks much better than it did and does not overlap content.
> > >
> > > Where it was floated right, it caused all sorts of issues, not easily
> > > fixed due to the fact that MOTD and/or surrounding content divs and
> > classes
> > > could be optionally added/removed at any time. There is as far as I can
> > see
> > > no good all round fix for this, taking browser sizes, browser versions
> > and
> > > screen resolutions into account. The current fix works fine for all
> > those
> > > but may not 'look' as good as if it were prevalent on the right side.
> > 
> > It is a shame. The original right-hand position was also
> > trying to utilise the whitespace at the right of the
> > Table Of Contents (ToC). Option #1 has even more wasted space.
> 
> Agree
> 
> > > I do have one idea to improve the look and keep it where it is on the
> > > left, hopefully being an agreed final fix for this MOTD position.
> > >
> > > I would like to propose that we create a new MOTD class in the same
> > > style as .note, .warning and .fixme. We'll give it a unique color from
> > > the rest but will be displayed in exactly the same way, from the left
> > going
> > > as far across the screen as necessary, with a title section and content
> > > section the same as .note etc.
> > >
> > > We can call it .information with 'Information' being the default label
> > for
> > > the top part which can be over-ridden with your own label, the MOTD on
> > the
> > > current forrest index page would instead use this with a label of
> > 'Latest
> > > release 0.8', the content area then having '18 April 2007 Forrest-0.8
> > > released: Features the Locationmap. (More)'
> > 
> > There is no configuration for the "label" attribute.
> 
> Sorry, mistake I meant :-
> 
> <div class="note">
> <div class="label">latest 0.8 release</div>
> <div class="content">'18 April 2007 Forrest-0.8
> released: Features the Locationmap. (More)
> </div>
> </div>
>
> but don't worry about it now ...

No that is not what i meant. There is no
configuration in skinconf.xml for "motd label".
It is only a snippet of text, so it needs to be
kept simple.

> > Perhaps just use a concise box with slightly bigger
> > border on all sides, using the existing colours.
> 
> Ok, no problem.
> 
> > > I'll do a mock up in a test-sample site and attach the graphic to this
> > issue
> > > if you like but I'm sure you know what I mean.
> > >
> > > So we have choices :-
> > >
> > > 1. Keep it as I have changed it to currently - to the left and still the
> > > traditional MOTD.
> > 
> > It wasn't a "traditional look". It was just a hack to fix
> > the docs during the 0.7 release. No effort was spent on
> > the look. I would prefer it to be more prominent CSS emphasis.
> > 
> > > 2. Create a new version of MOTD in the style of .note etc -- still
> > keeping
> > > the same way that we apply the MOTD, just the style changes.
> > 
> > I reckon that it would be too bulky and not stand
> > out sufficiently.
> > 
> > > 3. Revert and try something else, but it will be difficult to get it
> > right
> > > and keep it right for all scenarios. The above two will work in all
> > > scenarios.
> > >
> > > 4. Something else.
> > >
> > > Thoughts ?
> > 
> > Remember that these MOTD notes are intended to be
> > very short. The content needs to also be able to
> > fit into the bottom of the left-hand panel.
> > 
> > We are already utilising the space to the right
> > of the Title for Font Size and alternate formats,
> > so cannot put it there.
> > 
> > There are a number of pieces of "top matter".
> > a) Title and its right-hand friends seem fine as-is.
> > b) Optional header/abstract is shown above the ToC.
> > 
> > Would it be possible to have a div for this second set?
> > Then perhaps include the "motd" to the right-hand side.
> > It should then collapse gracefully if those two
> > pieces of content are missing. FLW.
> >
> > This is probably how i should have done it to
> > start with, but was in a rush at the time.
> 
> Ok, so enclose #MOTD and .abstract into a new div holding area.
> 
> .abstract left and #motd floated right, if either one is missing
> make sure the other still holds its place. If both are missing
> the container div will collapse.
> 
> Sounds like a plan.

Actually i meant to include the Table of Contents too.

 +-----------------------------------------------+
 | +-----------------------------+-------------+ |
 | |                             | Right Panel | |
 | |  header/abstract            |             | |
 | |                             |             | |
 | +-----------------------------+             | |
 | |                             |             | |
 | |  Generated ToC              |             | |
 | |                             |             | |
 | |                             |             | |
 | +-----------------------------+-------------+ |
 +-----------------------------------------------+

In the "Right Panel" would go the MOTD.
Perhaps later other things could go there too.

This is easier with the Dispatcher of course.

-David

RE: [jira] Commented: (FOR-605) CSS enhancements needed for MOTD area inside Table of Contents

Posted by "Gav...." <br...@brightontown.com.au>.

> -----Original Message-----
> From: David Crossley [mailto:crossley@apache.org]
> Sent: Monday, 25 June 2007 3:29 PM
> To: dev@forrest.apache.org
> Subject: Re: [jira] Commented: (FOR-605) CSS enhancements needed for MOTD
> area inside Table of Contents
> 
> Gav.... wrote:
> > Ok, so 550036 has moved MOTD to the left and removed relative
> positioning.
> >
> > It looks much better than it did and does not overlap content.
> >
> > Where it was floated right, it caused all sorts of issues, not easily
> > fixed due to the fact that MOTD and/or surrounding content divs and
> classes
> > could be optionally added/removed at any time. There is as far as I can
> see
> > no good all round fix for this, taking browser sizes, browser versions
> and
> > screen resolutions into account. The current fix works fine for all
> those
> > but may not 'look' as good as if it were prevalent on the right side.
> 
> It is a shame. The original right-hand position was also
> trying to utilise the whitespace at the right of the
> Table Of Contents (ToC). Option #1 has even more wasted space.

Agree

> 
> > I do have one idea to improve the look and keep it where it is on the
> > left, hopefully being an agreed final fix for this MOTD position.
> >
> > I would like to propose that we create a new MOTD class in the same
> > style as .note, .warning and .fixme. We'll give it a unique color from
> > the rest but will be displayed in exactly the same way, from the left
> going
> > as far across the screen as necessary, with a title section and content
> > section the same as .note etc.
> >
> > We can call it .information with 'Information' being the default label
> for
> > the top part which can be over-ridden with your own label, the MOTD on
> the
> > current forrest index page would instead use this with a label of
> 'Latest
> > release 0.8', the content area then having '18 April 2007 Forrest-0.8
> > released: Features the Locationmap. (More)'
> 
> There is no configuration for the "label" attribute.

Sorry, mistake I meant :-

<div class="note">
<div class="label">latest 0.8 release</div>
<div class="content">'18 April 2007 Forrest-0.8
released: Features the Locationmap. (More)
</div>
</div>

but don't worry about it now ...

> Perhaps just use a concise box with slightly bigger
> border on all sides, using the existing colours.

Ok, no problem.

> 
> > I'll do a mock up in a test-sample site and attach the graphic to this
> issue
> > if you like but I'm sure you know what I mean.
> >
> > So we have choices :-
> >
> > 1. Keep it as I have changed it to currently - to the left and still the
> > traditional MOTD.
> 
> It wasn't a "traditional look". It was just a hack to fix
> the docs during the 0.7 release. No effort was spent on
> the look. I would prefer it to be more prominent CSS emphasis.
> 
> > 2. Create a new version of MOTD in the style of .note etc -- still
> keeping
> > the same way that we apply the MOTD, just the style changes.
> 
> I reckon that it would be too bulky and not stand
> out sufficiently.
> 
> > 3. Revert and try something else, but it will be difficult to get it
> right
> > and keep it right for all scenarios. The above two will work in all
> > scenarios.
> >
> > 4. Something else.
> >
> > Thoughts ?
> 
> Remember that these MOTD notes are intended to be
> very short. The content needs to also be able to
> fit into the bottom of the left-hand panel.
> 
> We are already utilising the space to the right
> of the Title for Font Size and alternate formats,
> so cannot put it there.
> 
> There are a number of pieces of "top matter".
> a) Title and its right-hand friends seem fine as-is.
> b) Optional header/abstract is shown above the ToC.
> 
> Would it be possible to have a div for this second set?
> Then perhaps include the "motd" to the right-hand side.
> It should then collapse gracefully if those two
> pieces of content are missing. FLW.

Ok, so enclose #MOTD and .abstract into a new div holding area.

.abstract left and #motd floated right, if either one is missing
make sure the other still holds its place. If both are missing
the container div will collapse.

Sounds like a plan.

Gav...

> 
> This is probably how i should have done it to
> start with, but was in a rush at the time.
> 
> -David


Re: [jira] Commented: (FOR-605) CSS enhancements needed for MOTD area inside Table of Contents

Posted by David Crossley <cr...@apache.org>.
Gav.... wrote:
> Ok, so 550036 has moved MOTD to the left and removed relative positioning.
> 
> It looks much better than it did and does not overlap content.
>
> Where it was floated right, it caused all sorts of issues, not easily
> fixed due to the fact that MOTD and/or surrounding content divs and classes
> could be optionally added/removed at any time. There is as far as I can see
> no good all round fix for this, taking browser sizes, browser versions and 
> screen resolutions into account. The current fix works fine for all those
> but may not 'look' as good as if it were prevalent on the right side.

It is a shame. The original right-hand position was also
trying to utilise the whitespace at the right of the
Table Of Contents (ToC). Option #1 has even more wasted space.

> I do have one idea to improve the look and keep it where it is on the
> left, hopefully being an agreed final fix for this MOTD position.
> 
> I would like to propose that we create a new MOTD class in the same
> style as .note, .warning and .fixme. We'll give it a unique color from
> the rest but will be displayed in exactly the same way, from the left going
> as far across the screen as necessary, with a title section and content
> section the same as .note etc.
> 
> We can call it .information with 'Information' being the default label for
> the top part which can be over-ridden with your own label, the MOTD on the
> current forrest index page would instead use this with a label of 'Latest
> release 0.8', the content area then having '18 April 2007 Forrest-0.8
> released: Features the Locationmap. (More)'

There is no configuration for the "label" attribute.
Perhaps just use a concise box with slightly bigger
border on all sides, using the existing colours.

> I'll do a mock up in a test-sample site and attach the graphic to this issue
> if you like but I'm sure you know what I mean.
> 
> So we have choices :-
> 
> 1. Keep it as I have changed it to currently - to the left and still the
> traditional MOTD.

It wasn't a "traditional look". It was just a hack to fix
the docs during the 0.7 release. No effort was spent on
the look. I would prefer it to be more prominent CSS emphasis.

> 2. Create a new version of MOTD in the style of .note etc -- still keeping
> the same way that we apply the MOTD, just the style changes.

I reckon that it would be too bulky and not stand
out sufficiently.

> 3. Revert and try something else, but it will be difficult to get it right
> and keep it right for all scenarios. The above two will work in all
> scenarios.
> 
> 4. Something else.
> 
> Thoughts ?

Remember that these MOTD notes are intended to be
very short. The content needs to also be able to
fit into the bottom of the left-hand panel.

We are already utilising the space to the right
of the Title for Font Size and alternate formats,
so cannot put it there. 

There are a number of pieces of "top matter".
a) Title and its right-hand friends seem fine as-is.
b) Optional header/abstract is shown above the ToC.

Would it be possible to have a div for this second set?
Then perhaps include the "motd" to the right-hand side.
It should then collapse gracefully if those two
pieces of content are missing. FLW.

This is probably how i should have done it to
start with, but was in a rush at the time.

-David

RE: [jira] Commented: (FOR-605) CSS enhancements needed for MOTD area inside Table of Contents

Posted by "Gav...." <br...@brightontown.com.au>.
Ok, so 550036 has moved MOTD to the left and removed relative positioning.

It looks much better than it did and does not overlap content.
Where it was floated right, it caused all sorts of issues, not easily
fixed due to the fact that MOTD and/or surrounding content divs and classes
could be optionally added/removed at any time. There is as far as I can see
no good all round fix for this, taking browser sizes, browser versions and 
screen resolutions into account. The current fix works fine for all those
but may not 'look' as good as if it were prevalent on the right side.

I do have one idea to improve the look and keep it where it is on the
left, hopefully being an agreed final fix for this MOTD position.

I would like to propose that we create a new MOTD class in the same
style as .note, .warning and .fixme. We'll give it a unique color from
the rest but will be displayed in exactly the same way, from the left going
as far across the screen as necessary, with a title section and content
section the same as .note etc.

We can call it .information with 'Information' being the default label for
the top part which can be over-ridden with your own label, the MOTD on the
current forrest index page would instead use this with a label of 'Latest
release 0.8', the content area then having '18 April 2007 Forrest-0.8
released: Features the Locationmap. (More)'

I'll do a mock up in a test-sample site and attach the graphic to this issue
if you like but I'm sure you know what I mean.

So we have choices :-

1. Keep it as I have changed it to currently - to the left and still the
traditional MOTD.

2. Create a new version of MOTD in the style of .note etc -- still keeping
the same way that we apply the MOTD, just the style changes.

3. Revert and try something else, but it will be difficult to get it right
and keep it right for all scenarios. The above two will work in all
scenarios.

4. Something else.

Thoughts ?

(The site will reflect this update shortly, or use the proxy trick mentioned
on http://www.apache.org/dev/project-site.html for instant viewing.)

Gav...

> -----Original Message-----
> From: Gavin (JIRA) [mailto:jira@apache.org]
> Sent: Saturday, 23 June 2007 5:26 PM
> To: dev@forrest.apache.org
> Subject: [jira] Commented: (FOR-605) CSS enhancements needed for MOTD area
> inside Table of Contents
> 
> 
>     [ https://issues.apache.org/jira/browse/FOR-
> 605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-
> tabpanel#action_12507586 ]
> 
> Gavin commented on FOR-605:
> ---------------------------
> 
> This issue is more prevalent than ever, just look at the main forrest home
> page or even worse is http://forrest.apache.org/docs_0_90/index.html
> 
> 
> 
> > CSS enhancements needed for MOTD area inside Table of Contents
> > --------------------------------------------------------------
> >
> >                 Key: FOR-605
> >                 URL: https://issues.apache.org/jira/browse/FOR-605
> >             Project: Forrest
> >          Issue Type: Bug
> >          Components: Skins (general issues)
> >    Affects Versions: 0.8
> >            Reporter: David Crossley
> >            Assignee: Gavin
> >         Attachments: 605-screenshot.png, forrest_faq.png
> >
> >
> > The Message of the Day (MOTD) facility inserts a panel at  the top right
> of the Table of Contents (ToC). However this panel interferes with the
> flow of text in the ToC, forcing items to be line-wrapped to a narrow
> width. The MOTD is not properly implemented with CSS, probably needs its
> own definition.
> 
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.


[jira] Commented: (FOR-605) CSS enhancements needed for MOTD area inside Table of Contents

Posted by "Gavin (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FOR-605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12507586 ] 

Gavin commented on FOR-605:
---------------------------

This issue is more prevalent than ever, just look at the main forrest home page or even worse is http://forrest.apache.org/docs_0_90/index.html



> CSS enhancements needed for MOTD area inside Table of Contents
> --------------------------------------------------------------
>
>                 Key: FOR-605
>                 URL: https://issues.apache.org/jira/browse/FOR-605
>             Project: Forrest
>          Issue Type: Bug
>          Components: Skins (general issues)
>    Affects Versions: 0.8
>            Reporter: David Crossley
>            Assignee: Gavin
>         Attachments: 605-screenshot.png, forrest_faq.png
>
>
> The Message of the Day (MOTD) facility inserts a panel at  the top right of the Table of Contents (ToC). However this panel interferes with the flow of text in the ToC, forcing items to be line-wrapped to a narrow width. The MOTD is not properly implemented with CSS, probably needs its own definition.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (FOR-605) CSS enhancements needed for MOTD area inside Table of Contents

Posted by "Gavin (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FOR-605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12507665 ] 

Gavin commented on FOR-605:
---------------------------

Discussion started at http://marc.info/?l=forrest-dev&m=118260613009826&w=2 for a possible better solution.

> CSS enhancements needed for MOTD area inside Table of Contents
> --------------------------------------------------------------
>
>                 Key: FOR-605
>                 URL: https://issues.apache.org/jira/browse/FOR-605
>             Project: Forrest
>          Issue Type: Bug
>          Components: Skins (general issues)
>    Affects Versions: 0.8
>            Reporter: David Crossley
>            Assignee: Gavin
>         Attachments: 605-screenshot.png, forrest_faq.png
>
>
> The Message of the Day (MOTD) facility inserts a panel at  the top right of the Table of Contents (ToC). However this panel interferes with the flow of text in the ToC, forcing items to be line-wrapped to a narrow width. The MOTD is not properly implemented with CSS, probably needs its own definition.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (FOR-605) CSS enhancements needed for MOTD area inside Table of Contents

Posted by "Gavin (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FOR-605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gavin closed FOR-605.
---------------------

    Resolution: Fixed
      Assignee:     (was: Gavin)

> CSS enhancements needed for MOTD area inside Table of Contents
> --------------------------------------------------------------
>
>                 Key: FOR-605
>                 URL: https://issues.apache.org/jira/browse/FOR-605
>             Project: Forrest
>          Issue Type: Bug
>          Components: Skins (general issues)
>    Affects Versions: 0.8
>            Reporter: David Crossley
>         Attachments: 605-screenshot.png, forrest_faq.png, patch-FOR-605.txt
>
>
> The Message of the Day (MOTD) facility inserts a panel at  the top right of the Table of Contents (ToC). However this panel interferes with the flow of text in the ToC, forcing items to be line-wrapped to a narrow width. The MOTD is not properly implemented with CSS, probably needs its own definition.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (FOR-605) CSS enhancements needed for MOTD area inside Table of Contents

Posted by "Ross Gardler (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/FOR-605?page=all ]

Ross Gardler updated FOR-605:
-----------------------------

    Component: Skins (general issues)

> CSS enhancements needed for MOTD area inside Table of Contents
> --------------------------------------------------------------
>
>          Key: FOR-605
>          URL: http://issues.apache.org/jira/browse/FOR-605
>      Project: Forrest
>         Type: Bug
>   Components: Skins (general issues)
>     Versions: 0.8-dev
>     Reporter: David Crossley
>      Fix For: 0.8-dev
>  Attachments: 605-screenshot.png
>
> The Message of the Day (MOTD) facility inserts a panel at  the top right of the Table of Contents (ToC). However this panel interferes with the flow of text in the ToC, forcing items to be line-wrapped to a narrow width. The MOTD is not properly implemented with CSS, probably needs its own definition.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira