You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/01/25 20:08:03 UTC

[GitHub] [arrow] pitrou commented on a change in pull request #9317: ARROW-11377: [C++][CI] Add Thread Sanitizer nightly build

pitrou commented on a change in pull request #9317:
URL: https://github.com/apache/arrow/pull/9317#discussion_r564010378



##########
File path: cpp/build-support/run-test.sh
##########
@@ -65,14 +65,9 @@ function setup_sanitizers() {
 
   # Configure TSAN (ignored if this isn't a TSAN build).
   #
-  # Deadlock detection (new in clang 3.5) is disabled because:
-  # 1. The clang 3.5 deadlock detector crashes in some unit tests. It
-  #    needs compiler-rt commits c4c3dfd, 9a8efe3, and possibly others.
-  # 2. Many unit tests report lock-order-inversion warnings; they should be
-  #    fixed before reenabling the detector.
-  TSAN_OPTIONS="$TSAN_OPTIONS detect_deadlocks=0"
-  TSAN_OPTIONS="$TSAN_OPTIONS suppressions=$ROOT/build-support/tsan-suppressions.txt"

Review comment:
       Hmm, no, the removal is a mistake. Will re-add them (they're for CUDA).




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org