You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Dmytro Sen <ds...@hortonworks.com> on 2015/07/15 16:30:30 UTC
Review Request 36508: Final flag not preserved after enabling security
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36508/
-----------------------------------------------------------
Review request for Ambari, Jonathan Hurley and Nate Cole.
Bugs: AMBARI-12419
https://issues.apache.org/jira/browse/AMBARI-12419
Repository: ambari
Description
-------
The issue is noticed in an RU cluster where rolling upgrade has to be performed with ambari2.1.0. After installing dal bits we are setting final flag for a property 'tez.am.resource.memory.mb' to final which you can see in V3 config of the cluster. Then enabling security and HA is performed. After these operations we see that the final flag was turned off. Upon checking the versions, V4 doesn't have this final flag and changes between V3 and V4 is that, security is enabled at V4. (HiveServer2 Authentication is set to kerberos in V4 not in V3).
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ConfigureAction.java c717582
ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 8b4b1e2
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog170.java c54039f
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog200.java 2c9bf30
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog170Test.java 93f7f8c
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog200Test.java 484c18d
Diff: https://reviews.apache.org/r/36508/diff/
Testing
-------
unit tests are in progress
Thanks,
Dmytro Sen
Re: Review Request 36508: Final flag not preserved after enabling
security
Posted by Dmytro Sen <ds...@hortonworks.com>.
> On Июль 15, 2015, 3:22 п.п., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ConfigureAction.java, lines 449-462
> > <https://reviews.apache.org/r/36508/diff/2/?file=1012756#file1012756line449>
> >
> > I'm not sure what this Jira has to with upgrades. The description says that the config attributes are not preserved after enabling security.
> >
> > However, if you have found a problem with upgrades as well where we are not preserving attributes on an upgrade, this is the wrong place to do this work.
> >
> > It should probably be done as part of the UpgradeResourceProvider where it creates the new configurations when going from HDP 2.2 to 2.3
Fixing only enabling security in my new patch
- Dmytro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36508/#review91744
-----------------------------------------------------------
On Июль 15, 2015, 2:36 п.п., Dmytro Sen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36508/
> -----------------------------------------------------------
>
> (Updated Июль 15, 2015, 2:36 п.п.)
>
>
> Review request for Ambari, Jonathan Hurley and Nate Cole.
>
>
> Bugs: AMBARI-12419
> https://issues.apache.org/jira/browse/AMBARI-12419
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The issue is noticed in an RU cluster where rolling upgrade has to be performed with ambari2.1.0. After installing dal bits we are setting final flag for a property 'tez.am.resource.memory.mb' to final which you can see in V3 config of the cluster. Then enabling security and HA is performed. After these operations we see that the final flag was turned off. Upon checking the versions, V4 doesn't have this final flag and changes between V3 and V4 is that, security is enabled at V4. (HiveServer2 Authentication is set to kerberos in V4 not in V3).
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ConfigureAction.java c717582
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 8b4b1e2
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog170.java c54039f
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog200.java 2c9bf30
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog170Test.java 93f7f8c
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog200Test.java 484c18d
>
> Diff: https://reviews.apache.org/r/36508/diff/
>
>
> Testing
> -------
>
> unit tests are in progress
>
>
> Thanks,
>
> Dmytro Sen
>
>
Re: Review Request 36508: Final flag not preserved after enabling
security
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36508/#review91744
-----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ConfigureAction.java (lines 449 - 462)
<https://reviews.apache.org/r/36508/#comment145362>
I'm not sure what this Jira has to with upgrades. The description says that the config attributes are not preserved after enabling security.
However, if you have found a problem with upgrades as well where we are not preserving attributes on an upgrade, this is the wrong place to do this work.
It should probably be done as part of the UpgradeResourceProvider where it creates the new configurations when going from HDP 2.2 to 2.3
- Jonathan Hurley
On July 15, 2015, 10:36 a.m., Dmytro Sen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36508/
> -----------------------------------------------------------
>
> (Updated July 15, 2015, 10:36 a.m.)
>
>
> Review request for Ambari, Jonathan Hurley and Nate Cole.
>
>
> Bugs: AMBARI-12419
> https://issues.apache.org/jira/browse/AMBARI-12419
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The issue is noticed in an RU cluster where rolling upgrade has to be performed with ambari2.1.0. After installing dal bits we are setting final flag for a property 'tez.am.resource.memory.mb' to final which you can see in V3 config of the cluster. Then enabling security and HA is performed. After these operations we see that the final flag was turned off. Upon checking the versions, V4 doesn't have this final flag and changes between V3 and V4 is that, security is enabled at V4. (HiveServer2 Authentication is set to kerberos in V4 not in V3).
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ConfigureAction.java c717582
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 8b4b1e2
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog170.java c54039f
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog200.java 2c9bf30
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog170Test.java 93f7f8c
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog200Test.java 484c18d
>
> Diff: https://reviews.apache.org/r/36508/diff/
>
>
> Testing
> -------
>
> unit tests are in progress
>
>
> Thanks,
>
> Dmytro Sen
>
>
Re: Review Request 36508: Final flag not preserved after enabling
security
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36508/#review91768
-----------------------------------------------------------
Ship it!
Ship It!
- Nate Cole
On July 15, 2015, 1:14 p.m., Dmytro Sen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36508/
> -----------------------------------------------------------
>
> (Updated July 15, 2015, 1:14 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley and Nate Cole.
>
>
> Bugs: AMBARI-12419
> https://issues.apache.org/jira/browse/AMBARI-12419
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The issue is noticed in an RU cluster where rolling upgrade has to be performed with ambari2.1.0. After installing dal bits we are setting final flag for a property 'tez.am.resource.memory.mb' to final which you can see in V3 config of the cluster. Then enabling security and HA is performed. After these operations we see that the final flag was turned off. Upon checking the versions, V4 doesn't have this final flag and changes between V3 and V4 is that, security is enabled at V4. (HiveServer2 Authentication is set to kerberos in V4 not in V3).
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 8b4b1e2
> ambari-server/src/test/java/org/apache/ambari/server/state/ConfigHelperTest.java 1376d29
>
> Diff: https://reviews.apache.org/r/36508/diff/
>
>
> Testing
> -------
>
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ....................................... SUCCESS [6.261s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.073s]
> [INFO] Ambari Web ........................................ SUCCESS [44.994s]
> [INFO] Ambari Views ...................................... SUCCESS [3.141s]
> [INFO] Ambari Admin View ................................. SUCCESS [12.016s]
> [INFO] ambari-metrics .................................... SUCCESS [0.891s]
> [INFO] Ambari Metrics Common ............................. SUCCESS [2.405s]
> [INFO] Ambari Metrics Hadoop Sink ........................ SUCCESS [4.246s]
> [INFO] Ambari Metrics Flume Sink ......................... SUCCESS [2.049s]
> [INFO] Ambari Metrics Kafka Sink ......................... SUCCESS [3.349s]
> [INFO] Ambari Metrics Storm Sink ......................... SUCCESS [2.325s]
> [INFO] Ambari Metrics Collector .......................... SUCCESS [3:23.397s]
> [INFO] Ambari Metrics Monitor ............................ SUCCESS [3.840s]
> [INFO] Ambari Metrics Assembly ........................... SUCCESS [1:43.661s]
> [INFO] Ambari Server ..................................... SUCCESS [1:08:07.981s]
> [INFO] Ambari Agent ...................................... SUCCESS [20.250s]
> [INFO] Ambari Client ..................................... SUCCESS [0.073s]
> [INFO] Ambari Python Client .............................. SUCCESS [0.784s]
> [INFO] Ambari Groovy Client .............................. SUCCESS [12.384s]
> [INFO] Ambari Shell ...................................... SUCCESS [0.060s]
> [INFO] Ambari Python Shell ............................... SUCCESS [0.103s]
> [INFO] Ambari Groovy Shell ............................... SUCCESS [7.909s]
>
>
> Thanks,
>
> Dmytro Sen
>
>
Re: Review Request 36508: Final flag not preserved after enabling
security
Posted by Dmytro Sen <ds...@hortonworks.com>.
> On Июль 15, 2015, 5:22 п.п., Jonathan Hurley wrote:
> > Ship It!
>
> Jonathan Hurley wrote:
> So why did the original patch contain config attribute stuff for rolling upgrades? Did you also see an issue there as well? If so, we should open a Jira to track that.
RU calls org.apache.ambari.server.state.ConfigHelper#createConfigType() and doesn't pass attributes as a parameter when creates configs. I haven't check RU scenarios
- Dmytro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36508/#review91758
-----------------------------------------------------------
On Июль 15, 2015, 5:14 п.п., Dmytro Sen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36508/
> -----------------------------------------------------------
>
> (Updated Июль 15, 2015, 5:14 п.п.)
>
>
> Review request for Ambari, Jonathan Hurley and Nate Cole.
>
>
> Bugs: AMBARI-12419
> https://issues.apache.org/jira/browse/AMBARI-12419
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The issue is noticed in an RU cluster where rolling upgrade has to be performed with ambari2.1.0. After installing dal bits we are setting final flag for a property 'tez.am.resource.memory.mb' to final which you can see in V3 config of the cluster. Then enabling security and HA is performed. After these operations we see that the final flag was turned off. Upon checking the versions, V4 doesn't have this final flag and changes between V3 and V4 is that, security is enabled at V4. (HiveServer2 Authentication is set to kerberos in V4 not in V3).
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 8b4b1e2
> ambari-server/src/test/java/org/apache/ambari/server/state/ConfigHelperTest.java 1376d29
>
> Diff: https://reviews.apache.org/r/36508/diff/
>
>
> Testing
> -------
>
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ....................................... SUCCESS [6.261s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.073s]
> [INFO] Ambari Web ........................................ SUCCESS [44.994s]
> [INFO] Ambari Views ...................................... SUCCESS [3.141s]
> [INFO] Ambari Admin View ................................. SUCCESS [12.016s]
> [INFO] ambari-metrics .................................... SUCCESS [0.891s]
> [INFO] Ambari Metrics Common ............................. SUCCESS [2.405s]
> [INFO] Ambari Metrics Hadoop Sink ........................ SUCCESS [4.246s]
> [INFO] Ambari Metrics Flume Sink ......................... SUCCESS [2.049s]
> [INFO] Ambari Metrics Kafka Sink ......................... SUCCESS [3.349s]
> [INFO] Ambari Metrics Storm Sink ......................... SUCCESS [2.325s]
> [INFO] Ambari Metrics Collector .......................... SUCCESS [3:23.397s]
> [INFO] Ambari Metrics Monitor ............................ SUCCESS [3.840s]
> [INFO] Ambari Metrics Assembly ........................... SUCCESS [1:43.661s]
> [INFO] Ambari Server ..................................... SUCCESS [1:08:07.981s]
> [INFO] Ambari Agent ...................................... SUCCESS [20.250s]
> [INFO] Ambari Client ..................................... SUCCESS [0.073s]
> [INFO] Ambari Python Client .............................. SUCCESS [0.784s]
> [INFO] Ambari Groovy Client .............................. SUCCESS [12.384s]
> [INFO] Ambari Shell ...................................... SUCCESS [0.060s]
> [INFO] Ambari Python Shell ............................... SUCCESS [0.103s]
> [INFO] Ambari Groovy Shell ............................... SUCCESS [7.909s]
>
>
> Thanks,
>
> Dmytro Sen
>
>
Re: Review Request 36508: Final flag not preserved after enabling
security
Posted by Jonathan Hurley <jh...@hortonworks.com>.
> On July 15, 2015, 1:22 p.m., Jonathan Hurley wrote:
> > Ship It!
So why did the original patch contain config attribute stuff for rolling upgrades? Did you also see an issue there as well? If so, we should open a Jira to track that.
- Jonathan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36508/#review91758
-----------------------------------------------------------
On July 15, 2015, 1:14 p.m., Dmytro Sen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36508/
> -----------------------------------------------------------
>
> (Updated July 15, 2015, 1:14 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley and Nate Cole.
>
>
> Bugs: AMBARI-12419
> https://issues.apache.org/jira/browse/AMBARI-12419
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The issue is noticed in an RU cluster where rolling upgrade has to be performed with ambari2.1.0. After installing dal bits we are setting final flag for a property 'tez.am.resource.memory.mb' to final which you can see in V3 config of the cluster. Then enabling security and HA is performed. After these operations we see that the final flag was turned off. Upon checking the versions, V4 doesn't have this final flag and changes between V3 and V4 is that, security is enabled at V4. (HiveServer2 Authentication is set to kerberos in V4 not in V3).
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 8b4b1e2
> ambari-server/src/test/java/org/apache/ambari/server/state/ConfigHelperTest.java 1376d29
>
> Diff: https://reviews.apache.org/r/36508/diff/
>
>
> Testing
> -------
>
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ....................................... SUCCESS [6.261s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.073s]
> [INFO] Ambari Web ........................................ SUCCESS [44.994s]
> [INFO] Ambari Views ...................................... SUCCESS [3.141s]
> [INFO] Ambari Admin View ................................. SUCCESS [12.016s]
> [INFO] ambari-metrics .................................... SUCCESS [0.891s]
> [INFO] Ambari Metrics Common ............................. SUCCESS [2.405s]
> [INFO] Ambari Metrics Hadoop Sink ........................ SUCCESS [4.246s]
> [INFO] Ambari Metrics Flume Sink ......................... SUCCESS [2.049s]
> [INFO] Ambari Metrics Kafka Sink ......................... SUCCESS [3.349s]
> [INFO] Ambari Metrics Storm Sink ......................... SUCCESS [2.325s]
> [INFO] Ambari Metrics Collector .......................... SUCCESS [3:23.397s]
> [INFO] Ambari Metrics Monitor ............................ SUCCESS [3.840s]
> [INFO] Ambari Metrics Assembly ........................... SUCCESS [1:43.661s]
> [INFO] Ambari Server ..................................... SUCCESS [1:08:07.981s]
> [INFO] Ambari Agent ...................................... SUCCESS [20.250s]
> [INFO] Ambari Client ..................................... SUCCESS [0.073s]
> [INFO] Ambari Python Client .............................. SUCCESS [0.784s]
> [INFO] Ambari Groovy Client .............................. SUCCESS [12.384s]
> [INFO] Ambari Shell ...................................... SUCCESS [0.060s]
> [INFO] Ambari Python Shell ............................... SUCCESS [0.103s]
> [INFO] Ambari Groovy Shell ............................... SUCCESS [7.909s]
>
>
> Thanks,
>
> Dmytro Sen
>
>
Re: Review Request 36508: Final flag not preserved after enabling
security
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36508/#review91758
-----------------------------------------------------------
Ship it!
Ship It!
- Jonathan Hurley
On July 15, 2015, 1:14 p.m., Dmytro Sen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36508/
> -----------------------------------------------------------
>
> (Updated July 15, 2015, 1:14 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley and Nate Cole.
>
>
> Bugs: AMBARI-12419
> https://issues.apache.org/jira/browse/AMBARI-12419
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The issue is noticed in an RU cluster where rolling upgrade has to be performed with ambari2.1.0. After installing dal bits we are setting final flag for a property 'tez.am.resource.memory.mb' to final which you can see in V3 config of the cluster. Then enabling security and HA is performed. After these operations we see that the final flag was turned off. Upon checking the versions, V4 doesn't have this final flag and changes between V3 and V4 is that, security is enabled at V4. (HiveServer2 Authentication is set to kerberos in V4 not in V3).
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 8b4b1e2
> ambari-server/src/test/java/org/apache/ambari/server/state/ConfigHelperTest.java 1376d29
>
> Diff: https://reviews.apache.org/r/36508/diff/
>
>
> Testing
> -------
>
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ....................................... SUCCESS [6.261s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.073s]
> [INFO] Ambari Web ........................................ SUCCESS [44.994s]
> [INFO] Ambari Views ...................................... SUCCESS [3.141s]
> [INFO] Ambari Admin View ................................. SUCCESS [12.016s]
> [INFO] ambari-metrics .................................... SUCCESS [0.891s]
> [INFO] Ambari Metrics Common ............................. SUCCESS [2.405s]
> [INFO] Ambari Metrics Hadoop Sink ........................ SUCCESS [4.246s]
> [INFO] Ambari Metrics Flume Sink ......................... SUCCESS [2.049s]
> [INFO] Ambari Metrics Kafka Sink ......................... SUCCESS [3.349s]
> [INFO] Ambari Metrics Storm Sink ......................... SUCCESS [2.325s]
> [INFO] Ambari Metrics Collector .......................... SUCCESS [3:23.397s]
> [INFO] Ambari Metrics Monitor ............................ SUCCESS [3.840s]
> [INFO] Ambari Metrics Assembly ........................... SUCCESS [1:43.661s]
> [INFO] Ambari Server ..................................... SUCCESS [1:08:07.981s]
> [INFO] Ambari Agent ...................................... SUCCESS [20.250s]
> [INFO] Ambari Client ..................................... SUCCESS [0.073s]
> [INFO] Ambari Python Client .............................. SUCCESS [0.784s]
> [INFO] Ambari Groovy Client .............................. SUCCESS [12.384s]
> [INFO] Ambari Shell ...................................... SUCCESS [0.060s]
> [INFO] Ambari Python Shell ............................... SUCCESS [0.103s]
> [INFO] Ambari Groovy Shell ............................... SUCCESS [7.909s]
>
>
> Thanks,
>
> Dmytro Sen
>
>
Re: Review Request 36508: Final flag not preserved after enabling
security
Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36508/
-----------------------------------------------------------
(Updated Июль 15, 2015, 5:14 п.п.)
Review request for Ambari, Jonathan Hurley and Nate Cole.
Bugs: AMBARI-12419
https://issues.apache.org/jira/browse/AMBARI-12419
Repository: ambari
Description
-------
The issue is noticed in an RU cluster where rolling upgrade has to be performed with ambari2.1.0. After installing dal bits we are setting final flag for a property 'tez.am.resource.memory.mb' to final which you can see in V3 config of the cluster. Then enabling security and HA is performed. After these operations we see that the final flag was turned off. Upon checking the versions, V4 doesn't have this final flag and changes between V3 and V4 is that, security is enabled at V4. (HiveServer2 Authentication is set to kerberos in V4 not in V3).
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 8b4b1e2
ambari-server/src/test/java/org/apache/ambari/server/state/ConfigHelperTest.java 1376d29
Diff: https://reviews.apache.org/r/36508/diff/
Testing (updated)
-------
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Main ....................................... SUCCESS [6.261s]
[INFO] Apache Ambari Project POM ......................... SUCCESS [0.073s]
[INFO] Ambari Web ........................................ SUCCESS [44.994s]
[INFO] Ambari Views ...................................... SUCCESS [3.141s]
[INFO] Ambari Admin View ................................. SUCCESS [12.016s]
[INFO] ambari-metrics .................................... SUCCESS [0.891s]
[INFO] Ambari Metrics Common ............................. SUCCESS [2.405s]
[INFO] Ambari Metrics Hadoop Sink ........................ SUCCESS [4.246s]
[INFO] Ambari Metrics Flume Sink ......................... SUCCESS [2.049s]
[INFO] Ambari Metrics Kafka Sink ......................... SUCCESS [3.349s]
[INFO] Ambari Metrics Storm Sink ......................... SUCCESS [2.325s]
[INFO] Ambari Metrics Collector .......................... SUCCESS [3:23.397s]
[INFO] Ambari Metrics Monitor ............................ SUCCESS [3.840s]
[INFO] Ambari Metrics Assembly ........................... SUCCESS [1:43.661s]
[INFO] Ambari Server ..................................... SUCCESS [1:08:07.981s]
[INFO] Ambari Agent ...................................... SUCCESS [20.250s]
[INFO] Ambari Client ..................................... SUCCESS [0.073s]
[INFO] Ambari Python Client .............................. SUCCESS [0.784s]
[INFO] Ambari Groovy Client .............................. SUCCESS [12.384s]
[INFO] Ambari Shell ...................................... SUCCESS [0.060s]
[INFO] Ambari Python Shell ............................... SUCCESS [0.103s]
[INFO] Ambari Groovy Shell ............................... SUCCESS [7.909s]
Thanks,
Dmytro Sen
Re: Review Request 36508: Final flag not preserved after enabling
security
Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36508/
-----------------------------------------------------------
(Updated Июль 15, 2015, 4:54 п.п.)
Review request for Ambari, Jonathan Hurley and Nate Cole.
Bugs: AMBARI-12419
https://issues.apache.org/jira/browse/AMBARI-12419
Repository: ambari
Description
-------
The issue is noticed in an RU cluster where rolling upgrade has to be performed with ambari2.1.0. After installing dal bits we are setting final flag for a property 'tez.am.resource.memory.mb' to final which you can see in V3 config of the cluster. Then enabling security and HA is performed. After these operations we see that the final flag was turned off. Upon checking the versions, V4 doesn't have this final flag and changes between V3 and V4 is that, security is enabled at V4. (HiveServer2 Authentication is set to kerberos in V4 not in V3).
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 8b4b1e2
ambari-server/src/test/java/org/apache/ambari/server/state/ConfigHelperTest.java 1376d29
Diff: https://reviews.apache.org/r/36508/diff/
Testing
-------
unit tests are in progress
Thanks,
Dmytro Sen
Re: Review Request 36508: Final flag not preserved after enabling
security
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36508/#review91743
-----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ConfigureAction.java (lines 237 - 241)
<https://reviews.apache.org/r/36508/#comment145360>
ConfigureAction is not the place for this change. It should be in UpgradeResourceProvider.processConfigurations(), where we make new configs from the stack values.
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ConfigureAction.java (lines 449 - 459)
<https://reviews.apache.org/r/36508/#comment145361>
Should not be done here.
ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java (lines 681 - 691)
<https://reviews.apache.org/r/36508/#comment145364>
You're changing the behavior of this method; should have a test.
- Nate Cole
On July 15, 2015, 10:36 a.m., Dmytro Sen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36508/
> -----------------------------------------------------------
>
> (Updated July 15, 2015, 10:36 a.m.)
>
>
> Review request for Ambari, Jonathan Hurley and Nate Cole.
>
>
> Bugs: AMBARI-12419
> https://issues.apache.org/jira/browse/AMBARI-12419
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The issue is noticed in an RU cluster where rolling upgrade has to be performed with ambari2.1.0. After installing dal bits we are setting final flag for a property 'tez.am.resource.memory.mb' to final which you can see in V3 config of the cluster. Then enabling security and HA is performed. After these operations we see that the final flag was turned off. Upon checking the versions, V4 doesn't have this final flag and changes between V3 and V4 is that, security is enabled at V4. (HiveServer2 Authentication is set to kerberos in V4 not in V3).
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ConfigureAction.java c717582
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 8b4b1e2
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog170.java c54039f
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog200.java 2c9bf30
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog170Test.java 93f7f8c
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog200Test.java 484c18d
>
> Diff: https://reviews.apache.org/r/36508/diff/
>
>
> Testing
> -------
>
> unit tests are in progress
>
>
> Thanks,
>
> Dmytro Sen
>
>
Re: Review Request 36508: Final flag not preserved after enabling
security
Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36508/
-----------------------------------------------------------
(Updated Июль 15, 2015, 2:36 п.п.)
Review request for Ambari, Jonathan Hurley and Nate Cole.
Bugs: AMBARI-12419
https://issues.apache.org/jira/browse/AMBARI-12419
Repository: ambari
Description
-------
The issue is noticed in an RU cluster where rolling upgrade has to be performed with ambari2.1.0. After installing dal bits we are setting final flag for a property 'tez.am.resource.memory.mb' to final which you can see in V3 config of the cluster. Then enabling security and HA is performed. After these operations we see that the final flag was turned off. Upon checking the versions, V4 doesn't have this final flag and changes between V3 and V4 is that, security is enabled at V4. (HiveServer2 Authentication is set to kerberos in V4 not in V3).
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ConfigureAction.java c717582
ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 8b4b1e2
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog170.java c54039f
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog200.java 2c9bf30
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog170Test.java 93f7f8c
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog200Test.java 484c18d
Diff: https://reviews.apache.org/r/36508/diff/
Testing
-------
unit tests are in progress
Thanks,
Dmytro Sen