[GitHub] [incubator-superset] betodealmeida commented on a change in pull request #10456: Handle ROW data stored as string

[GitBox <gi...@apache.org>]

betodealmeida commented on a change in pull request #10456:
URL: https://github.com/apache/incubator-superset/pull/10456#discussion_r461837421



##########
File path: superset/db_engine_specs/presto.py
##########
@@ -653,12 +656,15 @@ def expand_data(  # pylint: disable=too-many-locals
                 # expand columns; we append them to the left so they are added
                 # immediately after the parent
                 expanded = get_children(column)
-                to_process.extendleft((column, level) for column in expanded)
+                to_process.extendleft((column, level) for column in expanded[::-1])

Review comment:
       I reversed `expanded` so that sub-columns are added in the right order, otherwise we get:
   
   ```
   a ROW(b, c) => a, a.c, a.b
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org