You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by "vy (via GitHub)" <gi...@apache.org> on 2024/09/15 20:14:11 UTC
[PR] Enable `docker` profile in CI for `log4j-layout-template-json-test` (logging-log4j2)
vy opened a new pull request, #2952:
URL: https://github.com/apache/logging-log4j2/pull/2952
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Enable `docker` profile in CI for `log4j-layout-template-json-test` (logging-log4j2)
Posted by "ppkarwasz (via GitHub)" <gi...@apache.org>.
ppkarwasz commented on PR #2952:
URL: https://github.com/apache/logging-log4j2/pull/2952#issuecomment-2352332016
FYI: I added:
```xml
<settings xmlns="http://maven.apache.org/SETTINGS/1.0.0"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="
http://maven.apache.org/SETTINGS/1.0.0
https://maven.apache.org/xsd/settings-1.0.0.xsd">
<!-- Enable Docker profiles in Log4j tests -->
<activeProfiles>
<activeProfile>docker</activeProfile>
</activeProfiles>
</settings>
```
We can add it to `BUILDING.adoc` as a copy-paste example.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Enable `docker` profile in CI for `log4j-layout-template-json-test` (logging-log4j2)
Posted by "vy (via GitHub)" <gi...@apache.org>.
vy commented on PR #2952:
URL: https://github.com/apache/logging-log4j2/pull/2952#issuecomment-2352258995
> Should we activate the `docker` profile by default on machines that have `/var/run/docker.sock`?
I think we should do neither. In particular, bootstrapping an ELK stack is a pretty resource intensive process, I doubt if it will succeed without an OOM on every developer machine.
> Or maybe we should ask the reviewers of a release to activate `docker` in their Maven settings if they have Docker installed?
I don't think we _should_, but I will update the review kit to reflect on the `docker` Maven profile – reviewers can choose for themselves.
> * The Docker image versions in these tests are somehow dated, but unfortunately Elastic Search does not provide a `latest` tag. Should we add [org.elastisearch:elasticsearch](https://mvnrepository.com/artifact/org.elasticsearch/elasticsearch/8.15.1) to the dependency management of this module, so Dependabot can update the version regularly? My guess is that the Docker images are published shortly after the `elasticsearch` artifact is out.
Addressed this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Enable `docker` profile in CI for `log4j-layout-template-json-test` (logging-log4j2)
Posted by "ppkarwasz (via GitHub)" <gi...@apache.org>.
ppkarwasz commented on code in PR #2952:
URL: https://github.com/apache/logging-log4j2/pull/2952#discussion_r1760742770
##########
log4j-parent/pom.xml:
##########
@@ -105,7 +105,14 @@
<commons-lang3.version>3.17.0</commons-lang3.version>
<commons-logging.version>1.3.4</commons-logging.version>
<disruptor.version>4.0.0</disruptor.version>
- <elasticsearch.version>7.17.24</elasticsearch.version>
+ <disruptor.version>3.4.4</disruptor.version>
Review Comment:
```suggestion
```
The correct version is already defined above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Enable `docker` profile in CI for `log4j-layout-template-json-test` (logging-log4j2)
Posted by "ppkarwasz (via GitHub)" <gi...@apache.org>.
ppkarwasz commented on PR #2952:
URL: https://github.com/apache/logging-log4j2/pull/2952#issuecomment-2352118562
I am wondering about a couple of things:
- Should we activate the `docker` profile by default on machines that have `/var/run/docker.sock`? Or maybe we should ask the reviewers of a release to activate `docker` in their Maven settings if they have Docker installed?
- The Docker image versions in these tests are somehow dated, but unfortunately Elastic Search does not provide a `latest` tag. Should we add [org.elastisearch:elasticsearch](https://mvnrepository.com/artifact/org.elasticsearch/elasticsearch/8.15.1) to the dependency management of this module, so Dependabot can update the version regularly? My guess is that the Docker images are published shortly after the `elasticsearch` artifact is out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Enable `docker` profile in CI for `log4j-layout-template-json-test` (logging-log4j2)
Posted by "vy (via GitHub)" <gi...@apache.org>.
vy merged PR #2952:
URL: https://github.com/apache/logging-log4j2/pull/2952
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org