You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/02/20 18:13:40 UTC

[GitHub] frankfliu commented on a change in pull request #14000: MXNET-1302 Exclude commons-codec and commons-io from assembled JAR

frankfliu commented on a change in pull request #14000: MXNET-1302 Exclude commons-codec and commons-io from assembled JAR
URL: https://github.com/apache/incubator-mxnet/pull/14000#discussion_r258609659
 
 

 ##########
 File path: scala-package/pom.xml
 ##########
 @@ -393,6 +393,13 @@
       <groupId>commons-codec</groupId>
       <artifactId>commons-codec</artifactId>
       <version>1.10</version>
+      <scope>provided</scope>
+    </dependency>
+    <dependency>
+      <groupId>commons-io</groupId>
+      <artifactId>commons-io</artifactId>
+      <version>2.1</version>
+      <scope>provided</scope>
 
 Review comment:
   The same for commons-io, this should not be provided.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services