You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@netbeans.apache.org by ma...@apache.org on 2017/10/11 17:46:09 UTC

[23/24] incubator-netbeans git commit: [NETBEANS-54] Modules review xml.lexer

[NETBEANS-54] Modules review xml.lexer

- no external library
- checked Rat report: excluded test-data from rat (no IP value)
- disable tests that fail because referenced files were not donated
- skimmed through module, did not notice additional problems

Project: http://git-wip-us.apache.org/repos/asf/incubator-netbeans/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-netbeans/commit/ed10c5af
Tree: http://git-wip-us.apache.org/repos/asf/incubator-netbeans/tree/ed10c5af
Diff: http://git-wip-us.apache.org/repos/asf/incubator-netbeans/diff/ed10c5af

Branch: refs/heads/master
Commit: ed10c5af2e8c40f9e6f1bcabd9330ace533a4593
Parents: bce3d24
Author: Matthias Bläsing <mb...@doppel-helix.eu>
Authored: Fri Oct 6 23:37:07 2017 +0200
Committer: Matthias Bläsing <mb...@doppel-helix.eu>
Committed: Wed Oct 11 19:04:54 2017 +0200

----------------------------------------------------------------------
 nbbuild/build.xml                                              | 2 ++
 .../unit/src/org/netbeans/api/xml/lexer/XMLTokenIdTest.java    | 6 ++++--
 2 files changed, 6 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-netbeans/blob/ed10c5af/nbbuild/build.xml
----------------------------------------------------------------------
diff --git a/nbbuild/build.xml b/nbbuild/build.xml
index 729b68c..b98d30f 100644
--- a/nbbuild/build.xml
+++ b/nbbuild/build.xml
@@ -1986,6 +1986,8 @@ It is possible to use -Ddebug.port=3234 -Ddebug.pause=y to start the system in d
                 <exclude name="xml.xdm/test/unit/src/org/netbeans/modules/xml/xdm/**/*.xml" /> <!-- test data -->
                 <exclude name="xml.xdm/test/unit/src/org/netbeans/modules/xml/xdm/**/*.xsd" /> <!-- test data -->
                 <exclude name="xml.xdm/test/unit/src/org/netbeans/modules/xml/xdm/**/*.bpel" /> <!-- test data -->
+                <exclude name="xml.lexer/test/unit/src/org/netbeans/api/xml/lexer/resources/*.dtd" /> <!-- test data -->
+                <exclude name="xml.lexer/test/unit/src/org/netbeans/api/xml/lexer/resources/*.xml" /> <!-- test data -->
                 <exclude name="xml.text/src/org/netbeans/modules/xml/text/resources/DTDExample" /> <!-- GUI sample file to demonstrate syntax highlighting -->
                 <exclude name="xml.text/src/org/netbeans/modules/xml/text/resources/XMLExample" /> <!-- GUI sample file to demonstrate syntax highlighting -->
                 <exclude name="xml.text/test/qa-functional/src/org/netbeans/modules/xml/text/**/data/**" /> <!-- test data -->

http://git-wip-us.apache.org/repos/asf/incubator-netbeans/blob/ed10c5af/xml.lexer/test/unit/src/org/netbeans/api/xml/lexer/XMLTokenIdTest.java
----------------------------------------------------------------------
diff --git a/xml.lexer/test/unit/src/org/netbeans/api/xml/lexer/XMLTokenIdTest.java b/xml.lexer/test/unit/src/org/netbeans/api/xml/lexer/XMLTokenIdTest.java
index 6d1f427..829a7ce 100644
--- a/xml.lexer/test/unit/src/org/netbeans/api/xml/lexer/XMLTokenIdTest.java
+++ b/xml.lexer/test/unit/src/org/netbeans/api/xml/lexer/XMLTokenIdTest.java
@@ -35,11 +35,13 @@ public class XMLTokenIdTest extends AbstractTestCase {
         TestSuite suite = new TestSuite();
         suite.addTest(new XMLTokenIdTest("testTokens"));
         //regression tests on XMLLexer
-        suite.addTest(new XMLTokenIdTest("testParse1"));
+//        Disabled as referenced files were partly not donated by oracle to apache
+//        suite.addTest(new XMLTokenIdTest("testParse1"));
         suite.addTest(new XMLTokenIdTest("testParse2"));
         suite.addTest(new XMLTokenIdTest("testParse3"));
         //measure performace
-        suite.addTest(new XMLTokenIdTest("testParsePerformance"));
+//        Disabled as referenced files were partly not donated by oracle to apache
+//        suite.addTest(new XMLTokenIdTest("testParsePerformance"));
         return suite;
     }