You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Wendy Smoak (JIRA)" <ji...@codehaus.org> on 2006/12/18 00:39:40 UTC
[jira] Created: (MASSEMBLY-169) Document new elements in the
assembly descriptor as "Since 2.2"
Document new elements in the assembly descriptor as "Since 2.2"
---------------------------------------------------------------
Key: MASSEMBLY-169
URL: http://jira.codehaus.org/browse/MASSEMBLY-169
Project: Maven 2.x Assembly Plugin
Issue Type: Improvement
Affects Versions: 2.2
Reporter: Wendy Smoak
Attachments: assembly-since-2.2.patch
The assembly.html page includes elements introduced after the 2.1 release. These need to be documented as "Since 2.2" to avoid confusion.
(Another option would be for modello:xdoc to generate something based on the <version> in the model.)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MASSEMBLY-169) Document new elements in the
assembly descriptor as "Since 2.2"
Posted by "Wendy Smoak (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MASSEMBLY-169?page=comments#action_83160 ]
Wendy Smoak commented on MASSEMBLY-169:
---------------------------------------
Dennis, this looks great. I think users will adapt to the different version numbers for the model vs. the plugin.
> Document new elements in the assembly descriptor as "Since 2.2"
> ---------------------------------------------------------------
>
> Key: MASSEMBLY-169
> URL: http://jira.codehaus.org/browse/MASSEMBLY-169
> Project: Maven 2.x Assembly Plugin
> Issue Type: Improvement
> Affects Versions: 2.2
> Reporter: Wendy Smoak
> Attachments: assembly-since-2.2.patch
>
>
> The assembly.html page includes elements introduced after the 2.1 release. These need to be documented as "Since 2.2" to avoid confusion.
> (Another option would be for modello:xdoc to generate something based on the <version> in the model.)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MASSEMBLY-169) Document new elements in the
assembly descriptor as "Since 2.2"
Posted by "John Casey (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MASSEMBLY-169?page=all ]
John Casey updated MASSEMBLY-169:
---------------------------------
Priority: Blocker (was: Major)
Fix Version/s: 2.2
> Document new elements in the assembly descriptor as "Since 2.2"
> ---------------------------------------------------------------
>
> Key: MASSEMBLY-169
> URL: http://jira.codehaus.org/browse/MASSEMBLY-169
> Project: Maven 2.x Assembly Plugin
> Issue Type: Improvement
> Affects Versions: 2.2
> Reporter: Wendy Smoak
> Priority: Blocker
> Fix For: 2.2
>
> Attachments: assembly-since-2.2.patch
>
>
> The assembly.html page includes elements introduced after the 2.1 release. These need to be documented as "Since 2.2" to avoid confusion.
> (Another option would be for modello:xdoc to generate something based on the <version> in the model.)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MASSEMBLY-169) Document new elements in the
assembly descriptor as "Since 2.2"
Posted by "Dennis Lundberg (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MASSEMBLY-169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_88949 ]
Dennis Lundberg commented on MASSEMBLY-169:
-------------------------------------------
I've updated the dependency on modello to the release 1.0-alpha-14 version. That makes it possible to use the features in there, if we want to. To do that we need to add some more info to the modello-maven-plugin configuration.
John's comment on version numbers are interesting. We need to make up our mind on how we want to proceed with the whole versioning scheme.
> Document new elements in the assembly descriptor as "Since 2.2"
> ---------------------------------------------------------------
>
> Key: MASSEMBLY-169
> URL: http://jira.codehaus.org/browse/MASSEMBLY-169
> Project: Maven 2.x Assembly Plugin
> Issue Type: Improvement
> Affects Versions: 2.2
> Reporter: Wendy Smoak
> Priority: Blocker
> Fix For: 2.2
>
> Attachments: assembly-since-2.2.patch
>
>
> The assembly.html page includes elements introduced after the 2.1 release. These need to be documented as "Since 2.2" to avoid confusion.
> (Another option would be for modello:xdoc to generate something based on the <version> in the model.)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MASSEMBLY-169) Document new elements in the
assembly descriptor as "Since 2.2"
Posted by "Dennis Lundberg (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MASSEMBLY-169?page=comments#action_83269 ]
Dennis Lundberg commented on MASSEMBLY-169:
-------------------------------------------
The code has been committed to modello now.
I made an additional change so that the since column will not appear unless you specify a firstVersion that is less than the version of the model.
> Document new elements in the assembly descriptor as "Since 2.2"
> ---------------------------------------------------------------
>
> Key: MASSEMBLY-169
> URL: http://jira.codehaus.org/browse/MASSEMBLY-169
> Project: Maven 2.x Assembly Plugin
> Issue Type: Improvement
> Affects Versions: 2.2
> Reporter: Wendy Smoak
> Attachments: assembly-since-2.2.patch
>
>
> The assembly.html page includes elements introduced after the 2.1 release. These need to be documented as "Since 2.2" to avoid confusion.
> (Another option would be for modello:xdoc to generate something based on the <version> in the model.)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (MASSEMBLY-169) Document new elements in the
assembly descriptor as "Since 2.2"
Posted by "John Casey (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MASSEMBLY-169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Casey closed MASSEMBLY-169.
--------------------------------
Assignee: John Casey
Resolution: Fixed
applied, thanks.
> Document new elements in the assembly descriptor as "Since 2.2"
> ---------------------------------------------------------------
>
> Key: MASSEMBLY-169
> URL: http://jira.codehaus.org/browse/MASSEMBLY-169
> Project: Maven 2.x Assembly Plugin
> Issue Type: Improvement
> Affects Versions: 2.2
> Reporter: Wendy Smoak
> Assigned To: John Casey
> Priority: Blocker
> Fix For: 2.2
>
> Attachments: assembly-since-2.2.patch
>
>
> The assembly.html page includes elements introduced after the 2.1 release. These need to be documented as "Since 2.2" to avoid confusion.
> (Another option would be for modello:xdoc to generate something based on the <version> in the model.)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MASSEMBLY-169) Document new elements in the
assembly descriptor as "Since 2.2"
Posted by "Dennis Lundberg (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MASSEMBLY-169?page=comments#action_82870 ]
Dennis Lundberg commented on MASSEMBLY-169:
-------------------------------------------
I tried to solve this in Modello. The downside with that is that the versions available in Modello are for the model and not the plugin, since that part of Modello doesn't even know what a Maven plugin is. Might be confusing for end users. What do you think?
Anyway, here's an example showing how it would look for the maven-assembly plugin:
- http://people.apache.org/~dennisl/maven-assembly-plugin/assembly.html
- http://people.apache.org/~dennisl/maven-assembly-plugin/component.html
> Document new elements in the assembly descriptor as "Since 2.2"
> ---------------------------------------------------------------
>
> Key: MASSEMBLY-169
> URL: http://jira.codehaus.org/browse/MASSEMBLY-169
> Project: Maven 2.x Assembly Plugin
> Issue Type: Improvement
> Affects Versions: 2.2
> Reporter: Wendy Smoak
> Attachments: assembly-since-2.2.patch
>
>
> The assembly.html page includes elements introduced after the 2.1 release. These need to be documented as "Since 2.2" to avoid confusion.
> (Another option would be for modello:xdoc to generate something based on the <version> in the model.)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MASSEMBLY-169) Document new elements in the
assembly descriptor as "Since 2.2"
Posted by "John Casey (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MASSEMBLY-169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Casey updated MASSEMBLY-169:
---------------------------------
Fix Version/s: (was: 2.2)
2.2-beta-1
> Document new elements in the assembly descriptor as "Since 2.2"
> ---------------------------------------------------------------
>
> Key: MASSEMBLY-169
> URL: http://jira.codehaus.org/browse/MASSEMBLY-169
> Project: Maven 2.x Assembly Plugin
> Issue Type: Improvement
> Affects Versions: 2.2
> Reporter: Wendy Smoak
> Assigned To: John Casey
> Priority: Blocker
> Fix For: 2.2-beta-1
>
> Attachments: assembly-since-2.2.patch
>
>
> The assembly.html page includes elements introduced after the 2.1 release. These need to be documented as "Since 2.2" to avoid confusion.
> (Another option would be for modello:xdoc to generate something based on the <version> in the model.)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MASSEMBLY-169) Document new elements in the
assembly descriptor as "Since 2.2"
Posted by "Wendy Smoak (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MASSEMBLY-169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_89074 ]
Wendy Smoak commented on MASSEMBLY-169:
---------------------------------------
The different version numbers for artifacts vs. models are already a fact of life. For example, Maven 2.0.x uses maven-model 4.0.x.
IMO we need a visual marker that something is "different", and then to explain how to interpret the information. I remain convinced that users will adapt to it, and that it's better than the confusion we have now.
+1 to go ahead with the changes in modello-maven-plugin and start using this.
> Document new elements in the assembly descriptor as "Since 2.2"
> ---------------------------------------------------------------
>
> Key: MASSEMBLY-169
> URL: http://jira.codehaus.org/browse/MASSEMBLY-169
> Project: Maven 2.x Assembly Plugin
> Issue Type: Improvement
> Affects Versions: 2.2
> Reporter: Wendy Smoak
> Priority: Blocker
> Fix For: 2.2
>
> Attachments: assembly-since-2.2.patch
>
>
> The assembly.html page includes elements introduced after the 2.1 release. These need to be documented as "Since 2.2" to avoid confusion.
> (Another option would be for modello:xdoc to generate something based on the <version> in the model.)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MASSEMBLY-169) Document new elements in the
assembly descriptor as "Since 2.2"
Posted by "Dennis Lundberg (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MASSEMBLY-169?page=comments#action_82900 ]
Dennis Lundberg commented on MASSEMBLY-169:
-------------------------------------------
After working a bit more on this I have published results that are slightly more sophisticated. The plugin now has the ability to take a parameter "firstVersion". It is used to ensure that only things that were added *after* firstVersion will be noted in the "since" column.
If I specify firstVersion=1.0.0 for the assembly-plugin I get these results:
- http://people.apache.org/~dennisl/maven-assembly-plugin-2/assembly.html
- http://people.apache.org/~dennisl/maven-assembly-plugin-2/component.html
If you don't specify anything for firstVersion it defaults to version, which means that nothing will show up in the "since" column. That is except for the heading, which I haven't figured out how to remove cleanly. But I see that as a minor problem.
> Document new elements in the assembly descriptor as "Since 2.2"
> ---------------------------------------------------------------
>
> Key: MASSEMBLY-169
> URL: http://jira.codehaus.org/browse/MASSEMBLY-169
> Project: Maven 2.x Assembly Plugin
> Issue Type: Improvement
> Affects Versions: 2.2
> Reporter: Wendy Smoak
> Attachments: assembly-since-2.2.patch
>
>
> The assembly.html page includes elements introduced after the 2.1 release. These need to be documented as "Since 2.2" to avoid confusion.
> (Another option would be for modello:xdoc to generate something based on the <version> in the model.)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MASSEMBLY-169) Document new elements in the
assembly descriptor as "Since 2.2"
Posted by "John Franey (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MASSEMBLY-169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_87947 ]
John Franey commented on MASSEMBLY-169:
---------------------------------------
-1 on using different version numbers for the model vs. the plugin. This issue comes from the need to reduce confusion. If the document states that a feature of version 2.2 is available since 1.1.0, users WILL be confused. Users will complain.
I think the model's version plan and plugin version plan should be loosely coincident. This means that only when the model changes, the new version should be the version of the plugin which required the change. Wendy's patch implies the same approach. This policy should likely be more broadly used than only in the assembly plugin, so please advise.
I (as a novice maven developer) want to help sort out this issue (as a way of getting my feet wet). It appears there are two applied solutions. Only one should be chosen, but , in my observation, the issue is half in one and half in the other. Wendy's direct patch does not depend on Dennis' change to modello and Dennis' change to modello (1.0-alpha-14) isn't used by current (public) checkout of the plugin (rev 495495). However, the issue has a declared dependency on this version of modello plugin.
I want to play around with manipulating the version elements in the model for this, but modello's webpage doesn't give me enough information. Apparently, it doesn't provide a source code site, or any examples (or I missed it). Also, the modello plugin 1.0-alpha-14-SNAPSHOT doesn't seem to have Dennis' change. Maybe I'm using it wrong, but the 'Since' column is not appearing when I generate a site using this version of the modello plugin.
Thanks.
Regards,
John
> Document new elements in the assembly descriptor as "Since 2.2"
> ---------------------------------------------------------------
>
> Key: MASSEMBLY-169
> URL: http://jira.codehaus.org/browse/MASSEMBLY-169
> Project: Maven 2.x Assembly Plugin
> Issue Type: Improvement
> Affects Versions: 2.2
> Reporter: Wendy Smoak
> Priority: Blocker
> Fix For: 2.2
>
> Attachments: assembly-since-2.2.patch
>
>
> The assembly.html page includes elements introduced after the 2.1 release. These need to be documented as "Since 2.2" to avoid confusion.
> (Another option would be for modello:xdoc to generate something based on the <version> in the model.)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira