[GitHub] [incubator-celeborn] zhongqiangczq commented on a diff in pull request #979: [CELEBORN-12] Retry on CommitFile request

[GitBox <gi...@apache.org>]

zhongqiangczq commented on code in PR #979:
URL: https://github.com/apache/incubator-celeborn/pull/979#discussion_r1025970138


##########
client/src/main/scala/org/apache/celeborn/client/LifecycleManager.scala:
##########
@@ -1605,21 +1605,29 @@ class LifecycleManager(appId: String, val conf: CelebornConf) extends RpcEndpoin
     }
   }
 
-  private def requestCommitFiles(
+  private def requestCommitFilesWithRetry(
       endpoint: RpcEndpointRef,
       message: CommitFiles): CommitFilesResponse = {
-    try {
-      endpoint.askSync[CommitFilesResponse](message)
-    } catch {
-      case e: Exception =>
-        logError(s"AskSync CommitFiles for ${message.shuffleId} failed.", e)
-        CommitFilesResponse(
-          StatusCode.FAILED,
-          List.empty.asJava,
-          List.empty.asJava,
-          message.masterIds,
-          message.slaveIds)
+    val maxRetries = conf.requestCommitFilesMaxRetries
+    var retryTimes = 0
+    while (retryTimes < maxRetries) {
+      try {
+        return endpoint.askSync[CommitFilesResponse](message)
+      } catch {
+        case e: Exception =>
+          retryTimes += 1

Review Comment:
   1. whether should need judge exception type like timeoutException? 
   2. whether  should wait somestimes before next retry?
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org