[GitHub] [trafficcontrol] jrushford commented on a change in pull request #3556: Default unavailable_server_retry_responses

[GitBox <gi...@apache.org>]

jrushford commented on a change in pull request #3556: Default unavailable_server_retry_responses
URL: https://github.com/apache/trafficcontrol/pull/3556#discussion_r282299895
 
 

 ##########
 File path: traffic_ops/app/lib/API/Configs/ApacheTrafficServer.pm
 ##########
 @@ -2617,13 +2617,8 @@ sub parent_dot_config { #fix qstring - should be ignore for quika
 				}
 				$text .= "$parents round_robin=$mso_algorithm qstring=$parent_qstring go_direct=false parent_is_proxy=false";
 
-				if ( $ats_major_version >= 6 && $parent_retry ne "" ) {
-					if ( $unavailable_server_retry_responses ne "" && $unavailable_server_retry_responses =~ /^"(?:\d{3},)+\d{3}"\s*$/) {
 
 Review comment:
   The ATS feature for unavailable_server_retry allows you to specify a comma separated list of 5xx codes such as unavailable_response_codes=500,503,5xx.  So if you set parent_retry to either 'both' or 'unavailable_server_retry', then you would configure the list of 5xx codes.  If you don't configure the list, it defaults to 503 and tells you so with the warning message.  So, in traffic control if no list is specified, then default it to 503 and you won't see the warning message from ATS.  You're only allowed 5xx codes on this list, ATS validates that and will reject the config if there are any codes not 5xx.  ATS will not crash, your parent.config line won't be loaded though

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services