You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@impala.apache.org by ta...@apache.org on 2016/12/10 06:14:05 UTC
incubator-impala git commit: IMPALA-4638: Run queries with MT_DOP
through admission control.
Repository: incubator-impala
Updated Branches:
refs/heads/master 1e683d4ee -> 48792eb92
IMPALA-4638: Run queries with MT_DOP through admission control.
The bug was a simple oversight: A TODO that was not addressed.
Testing: I examined query profiles before and after this
change with and without MT_DOP set. After this patch all
queries (with and without MT_DOP) go through admission control.
Change-Id: I3e05697a59e14617fb6a13ce8e0410820823fd3a
Reviewed-on: http://gerrit.cloudera.org:8080/5447
Reviewed-by: Alex Behm <al...@cloudera.com>
Tested-by: Internal Jenkins
Project: http://git-wip-us.apache.org/repos/asf/incubator-impala/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-impala/commit/48792eb9
Tree: http://git-wip-us.apache.org/repos/asf/incubator-impala/tree/48792eb9
Diff: http://git-wip-us.apache.org/repos/asf/incubator-impala/diff/48792eb9
Branch: refs/heads/master
Commit: 48792eb92f010af99246a14d5a3570dfed662dfd
Parents: 1e683d4
Author: Alex Behm <al...@cloudera.com>
Authored: Fri Dec 9 14:51:17 2016 -0800
Committer: Internal Jenkins <cl...@gerrit.cloudera.org>
Committed: Sat Dec 10 05:01:19 2016 +0000
----------------------------------------------------------------------
be/src/scheduling/simple-scheduler.cc | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/48792eb9/be/src/scheduling/simple-scheduler.cc
----------------------------------------------------------------------
diff --git a/be/src/scheduling/simple-scheduler.cc b/be/src/scheduling/simple-scheduler.cc
index a0b4a35..ff0337c 100644
--- a/be/src/scheduling/simple-scheduler.cc
+++ b/be/src/scheduling/simple-scheduler.cc
@@ -787,9 +787,7 @@ Status SimpleScheduler::Schedule(QuerySchedule* schedule) {
}
schedule->SetUniqueHosts(unique_hosts);
- // TODO-MT: call AdmitQuery()
- bool is_mt_execution = schedule->request().query_ctx.request.query_options.mt_dop > 0;
- if (!is_mt_execution && !FLAGS_disable_admission_control) {
+ if (!FLAGS_disable_admission_control) {
RETURN_IF_ERROR(admission_controller_->AdmitQuery(schedule));
}
return Status::OK();