You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "zclllyybb (via GitHub)" <gi...@apache.org> on 2023/03/13 06:22:45 UTC
[GitHub] [doris] zclllyybb opened a new pull request, #17727: [optimize-WIP](functions)
zclllyybb opened a new pull request, #17727:
URL: https://github.com/apache/doris/pull/17727
# Proposed changes
## Problem summary
make functions with only one argument to be automatically transformed when it's a constant column.
## Checklist(Required)
* [ ] Does it affect the original behavior
* [ ] Has unit tests been added
* [ ] Has document been added or modified
* [ ] Does it need to update dependencies
* [x] Is this PR support rollback (If NO, please explain WHY)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] zclllyybb commented on pull request #17727: [optimize-WIP](functions) optimize const_column to full convert
Posted by "zclllyybb (via GitHub)" <gi...@apache.org>.
zclllyybb commented on PR #17727:
URL: https://github.com/apache/doris/pull/17727#issuecomment-1467704751
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] HappenLee commented on a diff in pull request #17727: [optimize-WIP](functions)
Posted by "HappenLee (via GitHub)" <gi...@apache.org>.
HappenLee commented on code in PR #17727:
URL: https://github.com/apache/doris/pull/17727#discussion_r1133491701
##########
be/src/vec/functions/function_bitmap.cpp:
##########
@@ -272,8 +272,7 @@ class FunctionBitmapAlwaysNull : public IFunction {
auto& null_map = res_null_map->get_data();
auto& res = res_data_column->get_data();
- ColumnPtr argument_column =
- block.get_by_position(arguments[0]).column->convert_to_full_column_if_const();
+ ColumnPtr argument_column = block.get_by_position(arguments[0]).column;
Review Comment:
use reference
##########
be/src/vec/functions/function_bitmap.cpp:
##########
@@ -272,8 +272,7 @@ class FunctionBitmapAlwaysNull : public IFunction {
auto& null_map = res_null_map->get_data();
auto& res = res_data_column->get_data();
- ColumnPtr argument_column =
- block.get_by_position(arguments[0]).column->convert_to_full_column_if_const();
+ ColumnPtr argument_column = block.get_by_position(arguments[0]).column;
Review Comment:
use reference
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] zclllyybb commented on pull request #17727: [optimize-WIP](functions) optimize const_column to full convert
Posted by "zclllyybb (via GitHub)" <gi...@apache.org>.
zclllyybb commented on PR #17727:
URL: https://github.com/apache/doris/pull/17727#issuecomment-1465848217
run be ut
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #17727: [optimize-WIP](functions) optimize const_column to full convert
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #17727:
URL: https://github.com/apache/doris/pull/17727#issuecomment-1465728314
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] HappenLee merged pull request #17727: [optimize-WIP](functions) optimize const_column to full convert
Posted by "HappenLee (via GitHub)" <gi...@apache.org>.
HappenLee merged PR #17727:
URL: https://github.com/apache/doris/pull/17727
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #17727: [optimize-WIP](functions) optimize const_column to full convert
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #17727:
URL: https://github.com/apache/doris/pull/17727#issuecomment-1465733390
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #17727: [optimize-WIP](functions) optimize const_column to full convert
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #17727:
URL: https://github.com/apache/doris/pull/17727#issuecomment-1465789781
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] zclllyybb commented on pull request #17727: [optimize-WIP](functions) optimize const_column to full convert
Posted by "zclllyybb (via GitHub)" <gi...@apache.org>.
zclllyybb commented on PR #17727:
URL: https://github.com/apache/doris/pull/17727#issuecomment-1465847887
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #17727: [optimize-WIP](functions)
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #17727:
URL: https://github.com/apache/doris/pull/17727#issuecomment-1465584035
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] HappenLee commented on a diff in pull request #17727: [optimize-WIP](functions)
Posted by "HappenLee (via GitHub)" <gi...@apache.org>.
HappenLee commented on code in PR #17727:
URL: https://github.com/apache/doris/pull/17727#discussion_r1133492904
##########
be/src/vec/functions/functions_comparison.h:
##########
@@ -112,9 +112,9 @@ struct GenericComparisonImpl {
static void NO_INLINE vector_constant(const IColumn& a, const IColumn& b,
PaddedPODArray<UInt8>& c) {
- auto b_materialized = b.clone_resized(1)->convert_to_full_column_if_const();
- for (size_t i = 0, size = a.size(); i < size; ++i)
- c[i] = Op::apply(a.compare_at(i, 0, *b_materialized, 1), 0);
+ for (size_t i = 0, size = a.size(); i < size; ++i){
Review Comment:
the change seems will cause coredump
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] HappenLee commented on a diff in pull request #17727: [optimize-WIP](functions) optimize const_column to full convert
Posted by "HappenLee (via GitHub)" <gi...@apache.org>.
HappenLee commented on code in PR #17727:
URL: https://github.com/apache/doris/pull/17727#discussion_r1133615797
##########
be/src/vec/functions/function_bitmap.cpp:
##########
@@ -744,8 +744,7 @@ class FunctionBitmapToArray : public IFunction {
dest_nested_column = dest_nested_nullable_col->get_nested_column_ptr();
auto& dest_nested_null_map = dest_nested_nullable_col->get_null_map_column().get_data();
- auto arg_col =
- block.get_by_position(arguments[0]).column->convert_to_full_column_if_const();
+ auto arg_col = block.get_by_position(arguments[0]).column;
Review Comment:
use reference
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #17727: [optimize-WIP](functions) optimize const_column to full convert
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #17727:
URL: https://github.com/apache/doris/pull/17727#issuecomment-1467716645
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #17727: [optimize-WIP](functions) optimize const_column to full convert
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #17727:
URL: https://github.com/apache/doris/pull/17727#issuecomment-1465888593
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 34.52 seconds
stream load tsv: 474 seconds loaded 74807831229 Bytes, about 150 MB/s
stream load json: 41 seconds loaded 2358488459 Bytes, about 54 MB/s
stream load orc: 75 seconds loaded 1101869774 Bytes, about 14 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230313103324_clickbench_pr_113542.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org