You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commons-dev@ws.apache.org by "Andreas Veithen (JIRA)" <ji...@apache.org> on 2008/04/28 21:03:55 UTC

[jira] Created: (WSCOMMONS-335) Add a getOutputFormat method to MTOMXMLStreamWriter

Add a getOutputFormat method to MTOMXMLStreamWriter
---------------------------------------------------

                 Key: WSCOMMONS-335
                 URL: https://issues.apache.org/jira/browse/WSCOMMONS-335
             Project: WS-Commons
          Issue Type: Improvement
          Components: AXIOM
            Reporter: Andreas Veithen
            Priority: Minor


The MTOMXMLStreamWriter class has a setOutputFormat method as well as delegate methods for most of the getters and setters of the OutputFormat object, but it does not have a getOutputFormat method. This would be useful to get access to all the information stored in the OutputFormat object, in particular to the properties introduced by WSCOMMONS-287.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WSCOMMONS-335) Add a getOutputFormat method to MTOMXMLStreamWriter

Posted by "Andreas Veithen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WSCOMMONS-335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12593034#action_12593034 ] 

Andreas Veithen commented on WSCOMMONS-335:
-------------------------------------------

Sound like a good idea. Note that the Javadoc of OMOutputFormat already says that "It is advised to set all the properties at the creation time of the OMOutputFormat and not to change them later."

> Add a getOutputFormat method to MTOMXMLStreamWriter
> ---------------------------------------------------
>
>                 Key: WSCOMMONS-335
>                 URL: https://issues.apache.org/jira/browse/WSCOMMONS-335
>             Project: WS-Commons
>          Issue Type: Improvement
>          Components: AXIOM
>            Reporter: Andreas Veithen
>            Priority: Minor
>   Original Estimate: 0.08h
>  Remaining Estimate: 0.08h
>
> The MTOMXMLStreamWriter class has a setOutputFormat method as well as delegate methods for most of the getters and setters of the OutputFormat object, but it does not have a getOutputFormat method. This would be useful to get access to all the information stored in the OutputFormat object, in particular to the properties introduced by WSCOMMONS-287.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (WSCOMMONS-335) Add a getOutputFormat method to MTOMXMLStreamWriter

Posted by "Andreas Veithen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WSCOMMONS-335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andreas Veithen resolved WSCOMMONS-335.
---------------------------------------

    Resolution: Fixed
      Assignee: Andreas Veithen

Implemented solution (A) as suggested by Rich.

> Add a getOutputFormat method to MTOMXMLStreamWriter
> ---------------------------------------------------
>
>                 Key: WSCOMMONS-335
>                 URL: https://issues.apache.org/jira/browse/WSCOMMONS-335
>             Project: WS-Commons
>          Issue Type: Improvement
>          Components: AXIOM
>            Reporter: Andreas Veithen
>            Assignee: Andreas Veithen
>            Priority: Minor
>   Original Estimate: 0.08h
>  Remaining Estimate: 0.08h
>
> The MTOMXMLStreamWriter class has a setOutputFormat method as well as delegate methods for most of the getters and setters of the OutputFormat object, but it does not have a getOutputFormat method. This would be useful to get access to all the information stored in the OutputFormat object, in particular to the properties introduced by WSCOMMONS-287.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WSCOMMONS-335) Add a getOutputFormat method to MTOMXMLStreamWriter

Posted by "Rich Scheuerle (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WSCOMMONS-335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12593028#action_12593028 ] 

Rich Scheuerle commented on WSCOMMONS-335:
------------------------------------------

This sounds like a great idea.

My only concern is that changes to the OMOutputFormat during an MTOMXMLStreamWriter write could cause instability.

We could do:
  (A) Allow direct access to the OMOutputFormat object and provide comments to indicate that it should not be modified.  OR
  (B) Introduce a OMOutputFormatQuery interface that only provides access to the query operations (of course these could still be overridden).  OR
  (C) Make a copy of the OMOutputFormat.


I think I prefer (A) with ample comments.

Others ?


> Add a getOutputFormat method to MTOMXMLStreamWriter
> ---------------------------------------------------
>
>                 Key: WSCOMMONS-335
>                 URL: https://issues.apache.org/jira/browse/WSCOMMONS-335
>             Project: WS-Commons
>          Issue Type: Improvement
>          Components: AXIOM
>            Reporter: Andreas Veithen
>            Priority: Minor
>   Original Estimate: 0.08h
>  Remaining Estimate: 0.08h
>
> The MTOMXMLStreamWriter class has a setOutputFormat method as well as delegate methods for most of the getters and setters of the OutputFormat object, but it does not have a getOutputFormat method. This would be useful to get access to all the information stored in the OutputFormat object, in particular to the properties introduced by WSCOMMONS-287.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.